<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://avatar-cdn.atlassian.com/fd9b1205d379fbc32e2789c4ba389054?s=48&d=https%3A%2F%2Fsecure.gravatar.com%2Favatar%2Ffd9b1205d379fbc32e2789c4ba389054%3Fd%3Dmm%26s%3D48%26noRedirect%3Dtrue" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="tadhg.pearson" id="email_tadhg.pearson" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=tadhg.pearson" style="color:#6c797f;; color: #3b73af; text-decoration: none">Tadhg Pearson</a> <strong>updated</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-12281" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-42aaaac3-c763-41ce-b285-38246c76287b" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HHH-12281" style="color: #3b73af; text-decoration: none">HHH-12281</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-12281" style="color: #3b73af; text-decoration: none">SELECT - FOR UPDATE NOWAIT hangs if lock cannot be acquired</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Change By:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="tadhg.pearson" id="email_tadhg.pearson" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=tadhg.pearson" style="color:#6c797f;; color: #3b73af; text-decoration: none">Tadhg Pearson</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <span class="diffcontext">When using `find` to SELECT - FOR UPDATE NOWAIT, no exception is ever returned to the blocked thread, and it hangs.<br><br>The original test was in Spring Data JPA (see https://jira.spring.io/browse/DATAJPA-1259): I've tried my best to paraphase the test into straight Hibernate, but I don't have access to the tools here so there might be some bugs.<br><br>{code:java}<br>entityManager.find(ActivationLock.class, key, LockModeType.PESSIMISTIC_WRITE, Collections.singletonMap("javax.persistence.lock.timeout", 0));<br>{code}<br><br>where the full test is<br><br>{code:java}<br>@Entity<br>@Table(name = "CONF_ACTIVATION_LOCK")<br>public class ActivationLock {<br> <br> @EmbeddedId<br> ActivationLockKey key;<br> <br> ... Getters, setters, equals<br>}<br>{code}<br><br><br>{code:java}<br>@Embeddable<br>public class ActivationLockKey implements Serializable {<br> <br> private Long configId;<br> <br> @Convert(converter = NetworkConverter.class) // Writes only the first char of the string<br> private NetworkEnum network<br> <br>... Getters, setters, equals... <br>}<br>{code}<br><br><br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br>{code:java}<br></span> <span class="diffcontext">@Component // Config is on the abstract test, enables transaction management and scans this package for components<br>public class ActivationLockTest extends AbstractOracleDrivenUnitTests {<br> <br> @PersistenceContext EntityManager underTest;<br> <br> @Test<br> public void testFindAll() throws Exception {<br> ActivationLockKey key = new ActivationLockKey(42L, NetworkEnum.PRODUCTION);<br> ActivationLock requested = new ActivationLock(key);<br> if(!underTest.exists(key)){<br> initRow(requested);<br> }<br> <br> AtomicBoolean ready = new AtomicBoolean(false);<br> AtomicBoolean contended = new AtomicBoolean(false);<br> AtomicBoolean done = new AtomicBoolean(false);<br> <br> new Thread(() -> lockRows(requested, ready, contended, done)).start();<br> new Thread(() -> contendRows(requested, ready, contended)).start();<br> <br> Awaitility.await().atMost(20, TimeUnit.SECONDS).until(done::get);<br> }<br> <br> @Transactional<br> public void initRow(ActivationLock requested) {<br> ActivationLock created = underTest.persist(requested.getKey());<br> assertEquals(created, requested);<br> }<br> <br> @Transactional<br> public void contendRows(ActivationLock requested, AtomicBoolean ready, AtomicBoolean contended) {<br> Awaitility.await().until(ready::get);<br> try {<br> List<ActivationLock> lockedRows = underTest.find(ActivationLock.class, requested.getKey(), LockModeType.PESSIMISTIC_WRITE, Collections.singletonMap("javax.persistence.lock.timeout", 0)); //This thread gets stuck here<br> //Should have thrown an exception by now<br> assertNull(lockedRows); // Did we just get null instead of an exception?<br> fail();<br> }<br> catch (Exception e){<br> System.out.println("Failed");<br> //Good! What did we get?<br> e.printStackTrace();<br> }<br> contended.set(true);<br> }<br> <br> @Transactional<br> public void lockRows(ActivationLock requested, AtomicBoolean ready, AtomicBoolean contended, AtomicBoolean done) {<br> List<ActivationLock> lockedRows = underTest.find(ActivationLock.class, requested.getKey(), LockModeType.PESSIMISTIC_WRITE, Collections.singletonMap("javax.persistence.lock.timeout", 0));<br> assertEquals(lockedRows.get(0), requested);<br> ready.set(true);<br> Awaitility.await().until(contended::get); //This thread waits forever here<br> done.set(true);<br> }<br> <br>}<br></span> <span class="diffaddedchars" style="background-color:#ddfade;">{code}<br><br></span> <span class="diffcontext">The code issues the SQL I would expect, I see this SQL twice in the logs<br><br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br>{noformat}<br></span> <span class="diffcontext">Hibernate: <br> select<br> CONFIG_ID <br> from<br> CONF_ACTIVATION_LOCK <br> where<br> CONFIG_ID =? <br> and NETWORK =? for update<br> nowait<br></span> <span class="diffaddedchars" style="background-color:#ddfade;">{noformat}</span> <span class="diffcontext"><br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br><br></span> <span class="diffcontext">I would except some kind of exception, but in fact we just deadlock where I marked, and Awaitility kills the test after the timeout.<br><br>Please let me know if you need more details!</span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HHH-12281?inbox=true&",
"name": "View Issue"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-12281#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-1dacf324-3574-48a5-899d-5e39481ea411" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-12281#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-mobile-separated-links" class="mobile-resize-text" width="100%" colspan="2" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> Get Jira notifications on your phone! Download the Jira Cloud app for <a href="https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail" style="color: #3b73af; text-decoration: none">Android</a> or <a href="https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8" style="color: #3b73af; text-decoration: none">iOS</a>
<hr> </td>
</tr>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v1001.0.0-SNAPSHOT#100085-<span title="5dcb56559ef41b36794e21ac775f41e45860e0ed" data-commit-id="5dcb56559ef41b36794e21ac775f41e45860e0ed}">sha1:5dcb565</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px; opacity: 0.150"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-5a79a60f-4e84-4557-9b81-8463280f71c8" alt="Atlassian logo" title="Atlassian logo" width="192" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
<img src="https://u4043402.ct.sendgrid.net/wf/open?upn=YNXLe5Uzuivj8jGpuXra04BSJ-2BS7raa1puTAtyVUP-2F0UG25sB-2BHToWWBMcbXwnNUxDhKZaP8Iky3cHpgKavY-2BsRiBTlNJe4UAdK8qgF4Dpp1cn41ZqAP5hJGnFPkswjt3MEgEuCgEdhOyLyHmnQbIPdaDr67o9Cie-2BEAM8U3WJu7PU3pWY20ZCgz0K254v8qFFnCNNxCEG8Nq4n5-2FLwBoH5PfDEFZyhTZTymPrelsocuCW80oulZmBvQszAHbqlxOeDPZhFUV5zS5lxAbZiTVshEL-2FoF4Afw9PWw-2FeFQAn3Gjqps552Lh-2BgOwwaHWP0NIng5heZUmMi-2B5MFivCQk96fRonlcOWTLI1EgiHxbC2VvaNzYG4gZu6n1XwAKPCItvsSpOGf4D-2BuZWQRLsOj27w3ccAmxqmnjVSqWZaep7QsC2VzTq4oMMN0Q2QG9yukqsBLoSAVsYqqN58jf-2BYgwwQ-3D-3D" alt="" width="1" height="1" border="0" style="height:1px !important;width:1px !important;border-width:0 !important;margin-top:0 !important;margin-bottom:0 !important;margin-right:0 !important;margin-left:0 !important;padding-top:0 !important;padding-bottom:0 !important;padding-right:0 !important;padding-left:0 !important;"/>
</body>
</html>