<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://avatar-cdn.atlassian.com/2d08b9a73e22d20401282aa1c8d66102?s=48&d=https%3A%2F%2Fhibernate.atlassian.net%2Fsecure%2Fuseravatar%3FownerId%3Dcrancran%26avatarId%3D18440%26noRedirect%3Dtrue" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="crancran" id="email_crancran" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=crancran" style="color:#6c797f;; color: #3b73af; text-decoration: none">Chris Cranford</a> <strong>commented</strong> on <a href="https://hibernate.atlassian.net/browse/HHH-12852" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-bb3c7781-b194-41d0-9bbb-1d0184b95071" height="16" width="16" border="0" align="absmiddle" alt="Bug"> HHH-12852</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-12852" style="color: #3b73af; text-decoration: none">Re: strange behavior of collection property mod columns</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <p style="margin: 10px 0 0; margin-top: 0"><a href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=vipcxj" class="user-hover" rel="vipcxj" style="color: #3b73af; text-decoration: none">Xj Chen</a>, I'll answer your initial question here but should you have further ones, I'd suggest we have those conversations on the forums or HipChat as they'll not pollute this jira with unrelated discussions and we avoid pinging watchers and such on closed topics.</p> <p style="margin: 10px 0 0">When using the <tt>ValidityAuditStrategy</tt> and a record is updated or deleted, the original audit row insert will always set REVEND to null as well as the optionally enabled REVEND_TSTMP field. That particular strategy deals with setting those values in subsequent update statements.</p> <p style="margin: 10px 0 0">So for example, in a transaction where I remove an element from the element-collection (I persisted in a separate transaction for clarity):</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-comment" style="color: #808080">// Happens when I execute entity.getEmbeddables().clear()
</span>DELETE FROM BasicTestEntity_embeddables WHERE BasicTestEntity_id = ?
binding parameter [1] as [INTEGER] - [1]
<span class="code-comment" style="color: #808080">// Revision entity
</span>INSERT INTO REVINFO (REVTSMP, REV) values (?, ?)
binding parameter [1] as [TIMESTAMP] - [(a timestamp value here)]
binding parameter [2] as [INTEGER] - [2]
<span class="code-comment" style="color: #808080">// Create an audit row <span class="code-keyword" style="color: #000091; color: #808080">for</span> the removal of the element-collection element
</span>INSERT INTO BasicTestEntity_embeddables_AUD (REVEND, REVEND_TSTMP, REV, REVTYPE, BasicTestEntity_id, embeddables_ORDER, data) values (?, ?, ?, ?, ?, ?, ?)
binding parameter [1] as [INTEER] - [<span class="code-keyword" style="color: #000091">null</span>]
binding parameter [2] as [TIMESTAMP] - [<span class="code-keyword" style="color: #000091">null</span>]
binding parameter [3] as [INTEGER] - [2]
binding parameter [4] as [INTEGER] - [2]
binding parameter [5] as [INTEGER] - [1]
binding parameter [6] as [INTEGER] - [0]
binding parameter [7] as [VARCHAR] - [data]
<span class="code-comment" style="color: #808080">// Create an audit row <span class="code-keyword" style="color: #000091; color: #808080">for</span> the modified BasicTestEntity
</span>INSERT INTO BasicTestEnttiy_AUD (REVTYPE, REVEND, REVEND_TSTMP, value, value_MOD, embeddables_MOD, id, REV) values (?, ?, ?, ?, ?, ?, ?, ?)
binding parameter [1] as [INTEGER] - [1]
binding parameter [2] as [INTEGER] - [<span class="code-keyword" style="color: #000091">null</span>]
binding parameter [3] as [TIMESTAMP] - [<span class="code-keyword" style="color: #000091">null</span>]
binding parameter [4] as [VARCHAR] - [value]
binding parameter [5] as [BOOLEAN] - [<span class="code-keyword" style="color: #000091">true</span>]
binding parameter [6] as [BOOLEAN] - [<span class="code-keyword" style="color: #000091">true</span>]
binding parameter [7] as [INTEGER] - [1]
binding parameter [8] as [INTEGER} - [2]
<span class="code-comment" style="color: #808080">// Set the validity audit strategy values <span class="code-keyword" style="color: #000091; color: #808080">for</span> the element-collection element
</span>UPDATE BasicTestEntity_embeddables_AUD SET REVEND=?, REVEND_TSTMP=? WHERE REV=? AND REVTYPE=? AND BasicTestEntity_id=? AND embeddables_ORDER=?
binding parameter [1] as [INTEGER] - [2]
binding parameter [2] as [TIMESTAMP] - [(a timestamp value here)]
binding parameter [3] as [INTEGER] - [1]
binding parameter [4] as [INTEGER] - [0]
binding parameter [5] as [INTEGER] - [1]
binding parameter [6] as [INTEGER] - [0]
<span class="code-comment" style="color: #808080">// Set the validity audit strategy values <span class="code-keyword" style="color: #000091; color: #808080">for</span> the BasicTestEntity entity
</span>UPDATE BasicTestEntity_AUD SET REVEND=?, REVEND_TSTMP=? WHERE id=? AND REV<>? AND REVEND IS NULL
binding parameter [1] as [INTEGER] - [2]
binding parameter [2] as [TIMESTAMP] - [(a timestamp value here)]
binding parameter [3] as [INTEGER] - [1]
binding parameter [4] as [INTEGER] - [2]
</pre>
</div>
</div> <p style="margin: 10px 0 0">The key here is the last two operations in this transaction where the UPDATE statements are executed. The first deals with updating the special columns in the element-collection by locating the proper record and setting the 2 column values accordingly. Once the child records have been modified, we lastly update the root entity table. </p> <p style="margin: 10px 0 0">In a situation where an entity participates in certain inheritance strategies, you may have several entity tables that will be updated to make sure that the two columns are synchronized to support proper partitioning of the table data across that type of table relationship.</p> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HHH-12852?inbox=true&focusedCommentId=103344&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-103344",
"name": "View Comment"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-12852#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-dcb7fc6b-22a5-4234-883c-fe9a4758a88c" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-12852#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-mobile-separated-links" class="mobile-resize-text" width="100%" colspan="2" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> Get Jira notifications on your phone! Download the Jira Cloud app for <a href="https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail" style="color: #3b73af; text-decoration: none">Android</a> or <a href="https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8" style="color: #3b73af; text-decoration: none">iOS</a>
<hr> </td>
</tr>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v1001.0.0-SNAPSHOT#100090-<span title="32fefe6eee1885c39d1b0617fdf7bd1fad911d3c" data-commit-id="32fefe6eee1885c39d1b0617fdf7bd1fad911d3c}">sha1:32fefe6</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px; opacity: 0.150"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-2da923a1-d673-4e20-95f4-11b7388da517" alt="Atlassian logo" title="Atlassian logo" width="192" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>