<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://avatar-cdn.atlassian.com/2a8bdd4ffd282b7185c74b52ab452617?s=48&d=https%3A%2F%2Fsecure.gravatar.com%2Favatar%2F2a8bdd4ffd282b7185c74b52ab452617%3Fd%3Dmm%26s%3D48%26noRedirect%3Dtrue" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="yrodiere" id="email_yrodiere" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=yrodiere" style="color:#6c797f;; color: #3b73af; text-decoration: none">Yoann Rodière</a> <strong>updated</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiNmM4MTA1NDg2Nzg2NGFkZGFiODcwYWNjOTgyZjA5ZmQiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">Hibernate Search</a> / <a href="https://hibernate.atlassian.net/browse/HSEARCH-3444?atlOrigin=eyJpIjoiNmM4MTA1NDg2Nzg2NGFkZGFiODcwYWNjOTgyZjA5ZmQiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-c257373c-77c2-44ca-9128-7b75ef519b63" height="16" width="16" border="0" align="absmiddle" alt="Improvement" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HSEARCH-3444?atlOrigin=eyJpIjoiNmM4MTA1NDg2Nzg2NGFkZGFiODcwYWNjOTgyZjA5ZmQiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">HSEARCH-3444</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HSEARCH-3444?atlOrigin=eyJpIjoiNmM4MTA1NDg2Nzg2NGFkZGFiODcwYWNjOTgyZjA5ZmQiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">Reduce the verbosity of the predicate/projection/sort DSLs</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Change By:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="yrodiere" id="email_yrodiere" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=yrodiere" style="color:#6c797f;; color: #3b73af; text-decoration: none">Yoann Rodière</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <span class="diffcontext">The DSLs in Search 6 are relatively verbose, even when using the lambda syntax:<br><br>{code}<br>FullTextEntityManager fullTextEntityManager = Search.getFullTextEntityManager( entityManager );<br><br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">FullTextSearchTarget</span> <span class="diffaddedchars" style="background-color:#ddfade;">FullTextQuery</span> <span class="diffcontext"><</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">Book</span> <span class="diffaddedchars" style="background-color:#ddfade;">MyProjectionBean</span> <span class="diffcontext">></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> target</span> <span class="diffaddedchars" style="background-color:#ddfade;"> query</span> <span class="diffcontext"> = fullTextEntityManager.search( Book.class )</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">;<br><br>FullTextQuery<MyProjectionBean> query = target</span> <span class="diffcontext">.query()<br> .asProjection( f -><br> f.composite(<br> MyProjectionBean::new,<br> f.field( "id_stored", Long.class )<br> f.field( "title", String.class )<br> ).toProjection()<br> )<br> .predicate( f -> f.match()<br> .onFields( "title", "authors.name" )<br> .matching( "Refactoring: Improving the Design of Existing Code" )<br> .toPredicate()<br> )<br> .sort( f -> f.byField( "title" ).asc()<br> .then().byField( "subtitle" ).asc()<br> .toSort()<br> )<br> .build();<br><br>List<MyProjectionBean> result = query.getResultList();<br>{code}<br><br>We could try to improve on that.<br>One idea would be to remove the need to call the {{toPredicate}}, {{toProjection}} and {{toSort}} methods even at the top level:<br><br>{code}<br>FullTextEntityManager fullTextEntityManager = Search.getFullTextEntityManager( entityManager );<br><br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">FullTextSearchTarget</span> <span class="diffaddedchars" style="background-color:#ddfade;">FullTextQuery</span> <span class="diffcontext"><</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">Book</span> <span class="diffaddedchars" style="background-color:#ddfade;">MyProjectionBean</span> <span class="diffcontext">></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> target</span> <span class="diffaddedchars" style="background-color:#ddfade;"> query</span> <span class="diffcontext"> = fullTextEntityManager.search( Book.class )</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">;<br><br>FullTextQuery<MyProjectionBean> query = target</span> <span class="diffcontext">.query()<br> .asProjection( f -> f.composite(<br> MyProjectionBean::new,<br> f.field( "id_stored", Long.class )<br> f.field( "title", String.class )<br> ) )<br> .predicate( f -> f.match()<br> .onFields( "title", "authors.name" )<br> .matching( "Refactoring: Improving the Design of Existing Code" )<br> )<br> .sort( f -> f.byField( "title" ).asc()<br> .then().byField( "subtitle" ).asc()<br> )<br> .build();<br><br>List<MyProjectionBean> result = query.getResultList();<br>{code}<br><br>That would, however, remove the ability to returned a cached {{SearchPredicate}}/{{SearchProjection}}/{{SearchSort}} object from the lambda: the lambda would be expected to return a {{Search(Predicate/Projection/Sort)TerminalContext}}.<br><br>Maybe we should add a method to the DSL to convert a {{SearchPredicate}}/{{SearchProjection}}/{{SearchSort}} to a {{Search(Predicate/Projection/Sort)TerminalContext}}? Something like {{f.from(searchPredicate)}}? If we do that, it could make sense to change the naming around {{SearchPredicate}}/{{SearchProjection}}/{{SearchSort}}: we could make it more obvious that these are mainly for re-use, and are not really necessary if you don't cache them. Maybe rename them to {{ReusablePredicate}}, or something similar?</span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HSEARCH-3444?inbox=true&",
"name": "View Issue"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HSEARCH-3444#add-comment?atlOrigin=eyJpIjoiNmM4MTA1NDg2Nzg2NGFkZGFiODcwYWNjOTgyZjA5ZmQiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-3915edc2-d0d2-4be1-a83b-a91c1c34f68e" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HSEARCH-3444#add-comment?atlOrigin=eyJpIjoiNmM4MTA1NDg2Nzg2NGFkZGFiODcwYWNjOTgyZjA5ZmQiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-mobile-separated-links" class="mobile-resize-text" width="100%" colspan="2" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> Get Jira notifications on your phone! Download the Jira Cloud app for <a href="https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail" style="color: #3b73af; text-decoration: none">Android</a> or <a href="https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8" style="color: #3b73af; text-decoration: none">iOS</a>
<hr> </td>
</tr>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v1001.0.0-SNAPSHOT#100095-<span title="5a641b03f56e78917ddbb278b2358a464df84b87" data-commit-id="5a641b03f56e78917ddbb278b2358a464df84b87}">sha1:5a641b0</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px; opacity: 0.150"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-c166ecfe-ed3a-4c50-bca3-3fd460a295a1" alt="Atlassian logo" title="Atlassian logo" width="192" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
<img border="0" width="1" height="1" alt="" src="http://atlassian.et.e.sparkpost.com/q/7fjaBMyafLvovdwHJcW0yQ~~/AAAAAQA~/RgRd71ehPlcLYXRsYXNzaWFudXNCCgAAISQOXEeOwdVSIGhpYmVybmF0ZS1pc3N1ZXNAbGlzdHMuamJvc3Mub3JnWAQAAAAE">
</body>
</html>