<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://avatar-cdn.atlassian.com/2a8bdd4ffd282b7185c74b52ab452617?s=48&d=https%3A%2F%2Fsecure.gravatar.com%2Favatar%2F2a8bdd4ffd282b7185c74b52ab452617%3Fd%3Dmm%26s%3D48%26noRedirect%3Dtrue" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="yrodiere" style="color:#6c797f;; color: #3b73af; text-decoration: none" id="email_yrodiere" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A58fa1ced-171a-4c00-97e8-5d70d442cc4b"> Yoann Rodière </a> <strong>updated</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiZTBlNzFmYjg0YTNhNDk1ZjkwOTA4YmM2ODM2ZmE4YjAiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">Hibernate Search</a> / <a href="https://hibernate.atlassian.net/browse/HSEARCH-3047?atlOrigin=eyJpIjoiZTBlNzFmYjg0YTNhNDk1ZjkwOTA4YmM2ODM2ZmE4YjAiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-0b400dfa-541a-49fe-9fcf-ee203a44512d" height="16" width="16" border="0" align="absmiddle" alt="Task" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HSEARCH-3047?atlOrigin=eyJpIjoiZTBlNzFmYjg0YTNhNDk1ZjkwOTA4YmM2ODM2ZmE4YjAiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">HSEARCH-3047</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HSEARCH-3047?atlOrigin=eyJpIjoiZTBlNzFmYjg0YTNhNDk1ZjkwOTA4YmM2ODM2ZmE4YjAiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">Search 6 groundwork - Implement the missing field types and default bridges compared to Search 5</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Change By:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="yrodiere" style="color:#6c797f;; color: #3b73af; text-decoration: none" id="email_yrodiere" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A58fa1ced-171a-4c00-97e8-5d70d442cc4b"> Yoann Rodière </a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">In</span> <span class="diffaddedchars" style="background-color:#ddfade;">The idea is to add support for all types that were supported in Search 5.<br><br>You can find the types supported in Search 5 by having a look at implementations of</span> <span class="diffcontext"> {{org.hibernate.search.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">v6poc</span> <span class="diffaddedchars" style="background-color:#ddfade;">bridge</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">backend</span> <span class="diffaddedchars" style="background-color:#ddfade;">spi</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">document</span> <span class="diffaddedchars" style="background-color:#ddfade;">BridgeProvider}}</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">model</span> <span class="diffaddedchars" style="background-color:#ddfade;"> This should essentially include all primary types, java</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">IndexSchemaFieldContext</span> <span class="diffaddedchars" style="background-color:#ddfade;">util.Date, java.util.Calendar, the java.time types, the numeric types (Short, Double, Float, ...), BigDecimal and BigInteger, and maybe more.<br><br>Only the boxed versions of types ({{Integer</span> <span class="diffcontext">}}</span> <span class="diffaddedchars" style="background-color:#ddfade;">, not {{int}}) actually require code in the backend to support them, the others should be supported automatically thanks to existing code in the mapper</span> <span class="diffcontext">.<br><br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">See in Search 5</span> <span class="diffaddedchars" style="background-color:#ddfade;">The code changed a bit since HSEARCH-3265, but on a higher level the list of tasks will be fairly similar.<br><br>For each type, we need to</span> <span class="diffcontext">:<br><br>*</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> NumericBridgeProvider</span> <span class="diffaddedchars" style="background-color:#ddfade;"> Implement the backend support:</span> <span class="diffcontext"><br>*</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> JavaTimeBridgeProvider<br></span> <span class="diffcontext">*</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> BasicJDKTypesBridgeProvider<br><br>Do not forget</span> <span class="diffaddedchars" style="background-color:#ddfade;"> Add a {{asMyType()}} method in the field type definition API, and the appropriate implementation in each backend (Lucene + ES). Please look at existing implementations for similar types first, you may be able</span> <span class="diffcontext"> to</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> change</span> <span class="diffaddedchars" style="background-color:#ddfade;"> reuse code. In particular in</span> <span class="diffcontext"> the</span> <span class="diffaddedchars" style="background-color:#ddfade;"> Lucene backend, there is a common pattern for all numeric types.<br>** Update the</span> <span class="diffcontext"> implementations of</span> <span class="diffaddedchars" style="background-color:#ddfade;"> the</span> <span class="diffcontext"> {{</span> <span class="diffaddedchars" style="background-color:#ddfade;">as(Class<?>)}} method in the same interface to support the new type<br>** Add integration tests to the backend TCK. This mainly means implementing a {{</span> <span class="diffcontext">org.hibernate.search.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">v6poc</span> <span class="diffaddedchars" style="background-color:#ddfade;">integrationtest</span> <span class="diffcontext">.backend.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">document</span> <span class="diffaddedchars" style="background-color:#ddfade;">tck</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">model</span> <span class="diffaddedchars" style="background-color:#ddfade;">testsupport</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">IndexSchemaFieldContext</span> <span class="diffaddedchars" style="background-color:#ddfade;">types.FieldTypeDescriptor}} and referencing your implementation from {{org.hibernate.search.integrationtest.backend.tck.testsupport.types.FieldTypeDescriptor</span> <span class="diffcontext">#</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">as</span> <span class="diffaddedchars" style="background-color:#ddfade;">getAll</span> <span class="diffcontext">}}</span> <span class="diffaddedchars" style="background-color:#ddfade;">. See {{org.hibernate.search.integrationtest.backend.tck.testsupport.types.LongFieldTypeDescriptor}} for an example. After you implemented that, run {{org.hibernate.search.integrationtest.backend.tck.search.predicate.MatchSearchPredicateIT#match}} and check that your type appears in the list of tests.<br>* Implement the mapper support<br>** Register a default value bridge for the type in {{org.hibernate.search.mapper.pojo.bridge.impl.BridgeResolver#BridgeResolver}}. Generally a {{PassThroughValueBridge}} should be enough, but in some cases you may want to add a specific implementation (java.util.Calendar in particular, see below).<br>** Where that makes sense (= the type could reasonably be used</span> <span class="diffcontext"> as</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> appropriate</span> <span class="diffaddedchars" style="background-color:#ddfade;"> an entity ID), register a default identifier bridge for the type in {{org</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> <br></span> <span class="diffaddedchars" style="background-color:#ddfade;">hibernate.search.mapper.pojo.bridge.impl.BridgeResolver#BridgeResolver}}.<br>** Add integration tests to the pojo mapper ITs. This mainly means implementing a {{org.hibernate.search.integrationtest.mapper.pojo.testsupport.types.PropertyTypeDescriptor}} and referencing your implementation from {{org.hibernate.search.integrationtest.mapper.pojo.testsupport.types.PropertyTypeDescriptor#getAll}}. See {{org.hibernate.search.integrationtest.mapper.pojo.testsupport.types.BoxedLongPropertyTypeDescriptor}} for an example. After you implemented that, run {{org.hibernate.search.integrationtest.mapper.pojo.mapping.definition.FieldDefaultBridgeIT}} and check that your type appears in the list of tests.<br>*** Note that for boxed/primitive types ({{Short}}/{{short}}) *you need an implementation for both the boxed type and the primitive type*.<br><br>Note there are particular cases: Calendar in particular doesn't need to be implemented in the backend; converting it to a ZonedDateTime should be enough. So you will only need to implement a bridge in the mapper similar to {{org.hibernate.search.mapper.pojo.bridge.builtin.impl.DefaultJavaUtilDateValueBridge}}, reference it from the bridge resolver and add mapper tests: nothing to do on the backend side.<br><br>As to the commits, I would recommend to not be more precise than, for each type one commit for the backend impls (both ES + Lucene), one for the backend tests, one for the mapper impl, one for the mapper tests. And I think you can safely squash that into just two commits, one for the backends and one for the mapper.</span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HSEARCH-3047?inbox=true&",
"name": "View Issue"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HSEARCH-3047#add-comment?atlOrigin=eyJpIjoiZTBlNzFmYjg0YTNhNDk1ZjkwOTA4YmM2ODM2ZmE4YjAiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-262c8a1f-f27a-4803-87b2-9977d4443735" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HSEARCH-3047#add-comment?atlOrigin=eyJpIjoiZTBlNzFmYjg0YTNhNDk1ZjkwOTA4YmM2ODM2ZmE4YjAiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-mobile-separated-links" class="mobile-resize-text" width="100%" colspan="2" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> Get Jira notifications on your phone! Download the Jira Cloud app for <a href="https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail" style="color: #3b73af; text-decoration: none">Android</a> or <a href="https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8" style="color: #3b73af; text-decoration: none">iOS</a>
<hr> </td>
</tr>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v1001.0.0-SNAPSHOT#100098-<span title="2dc97364c2ad9857f5b92845ad630db0a3006f6e" data-commit-id="2dc97364c2ad9857f5b92845ad630db0a3006f6e}">sha1:2dc9736</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px; opacity: 0.150"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-5655526a-7229-4358-8de2-b8743b9e3abc" alt="Atlassian logo" title="Atlassian logo" width="192" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
<img border="0" width="1" height="1" alt="" src="http://atlassian.et.e.sparkpost.com/q/aeav9iXP6sxtVaRN2qAlYw~~/AAAAAQA~/RgReO8oAPlcLYXRsYXNzaWFudXNCCgAAgJZaXCAtfsFSIGhpYmVybmF0ZS1pc3N1ZXNAbGlzdHMuamJvc3Mub3JnWAQAAAAE">
</body>
</html>