<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://avatar-cdn.atlassian.com/7676dfe87d69de94469a2ca96790e760?s=48&d=https%3A%2F%2Fsecure.gravatar.com%2Favatar%2F7676dfe87d69de94469a2ca96790e760%3Fd%3Dmm%26s%3D48%26noRedirect%3Dtrue" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="pablo.perich" style="color:#6c797f;; color: #3b73af; text-decoration: none" id="email_pablo.perich" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A0ccc0caa-9154-484a-82ee-eee2082e846e"> Pablo Perich </a> <strong>updated</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMmRiMmM5ODI5OTVkNDg5NzgwZGJkZjQxYjM5Mzg1YjMiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-13290?atlOrigin=eyJpIjoiMmRiMmM5ODI5OTVkNDg5NzgwZGJkZjQxYjM5Mzg1YjMiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-f503a9c8-76c1-43ae-a500-5a9f1455feff" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HHH-13290?atlOrigin=eyJpIjoiMmRiMmM5ODI5OTVkNDg5NzgwZGJkZjQxYjM5Mzg1YjMiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">HHH-13290</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-13290?atlOrigin=eyJpIjoiMmRiMmM5ODI5OTVkNDg5NzgwZGJkZjQxYjM5Mzg1YjMiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">GenerationTiming.ALWAYS with database generated values doesn't work as expected</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Change By:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="pablo.perich" style="color:#6c797f;; color: #3b73af; text-decoration: none" id="email_pablo.perich" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A0ccc0caa-9154-484a-82ee-eee2082e846e"> Pablo Perich </a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <span class="diffcontext">As is described in this post: https://stackoverflow.com/questions/36700139/hibernate-valuegenerationtype-applied-at-insert-but-not-update-time the generated values by database in timing “ALWAYS” is not working as expected<br><br>The method referenceColumnInSql is defined to return true and the method getDatabaseGeneratedReferencedColumnValue returns the value “current_timestamp”<br><br>So it is expected that the update statement also include the column and sets it’s value to “current_timestamp” but the column is missing in the update statemet and it is only included in the select statement to get the value from the database, but the value is never changed.<br><br>It is necesary to include the column in the update statement.<br><br>This is the annotation definition:<br>{code:java}<br>package com.halftau.db.annotations;<br><br>import com.halftau.db.behaviour.ModificationTimeGeneratorImpl;<br>import java.lang.annotation.Retention;<br>import java.lang.annotation.RetentionPolicy;<br>import org.hibernate.annotations.ValueGenerationType;<br><br>@ValueGenerationType(generatedBy = ModificationTimeGeneratorImpl.class)<br>@Retention(RetentionPolicy.RUNTIME)<br>public @interface ModificationTime {}<br>{code}<br><br>This is the implementation class definition:<br><br>{code:java}<br>package com.halftau.db.behaviour;<br><br>import com.halftau.db.annotations.ModificationTime;<br>import org.hibernate.tuple.AnnotationValueGeneration;<br>import org.hibernate.tuple.GenerationTiming;<br>import org.hibernate.tuple.ValueGenerator;<br><br>public class ModificationTimeGeneratorImpl implements AnnotationValueGeneration<ModificationTime> {<br> <br> @Override<br> public void initialize(ModificationTime annotation, Class<?> propertyType) {<br> System.out.println("INICIALIZANDO MODIFICATION TIME");<br> }<br><br> /**<br> * Generate value on ALWAYS<br> * @return when to generate the value<br> */<br> @Override<br> public GenerationTiming getGenerationTiming() {<br> return GenerationTiming.ALWAYS;<br> }<br><br> /**<br> * Returns null because the value is generated by the database.<br> * @return null<br> */<br> @Override<br> public ValueGenerator<?> getValueGenerator() {<br> return null;<br> }<br><br> /**<br> * Returns true because the value is generated by the database.<br> * @return true<br> */<br> @Override<br> public boolean referenceColumnInSql() {<br> return true;<br> }<br><br> /**<br> * Returns the database-generated value<br> * @return database-generated value<br> */<br> @Override<br> public String getDatabaseGeneratedReferencedColumnValue() {<br> return "LOCALTIMESTAMP";<br> } <br>}<br>{code}<br><br>when I insert the entity in the database, I got these statements:<br><br>{noformat}<br> Hibernate:<br> select<br> nextval ('project_proj_id_SEQ')<br> Hibernate:<br> /* insert com.halftau.tasks.entities.Project<br> */ insert<br> into<br> project<br> (acco_id, alive, description, destruction_time, external_id, modification_time, name, proj_id, tena_id)<br> values<br> (?, ?, ?, ?, ?, LOCALTIMESTAMP, ?, ?, ?)<br> Hibernate:<br> /* get generated state com.halftau.tasks.entities.Project */ select<br> project_.creation_time as creation5_2_,<br> project_.modification_time as modifica9_2_<br> from<br> project project_<br> where<br> project_.proj_id=?<br> and project_.tena_id=?<br>{noformat}<br><br>Which is correct. It references the column "modification_time" (Annotated with the ModificationTime annotation in the entity definition) and set que insert statement using "LOCALTIMESTAMP" as defined in the getDatabaseGeneratedReferencedColumnValue() method.<br><br>But when I update the entity I get these statements:<br><br>{noformat}<br> Hibernate:<br> /* update<br> com.halftau.tasks.entities.Project */ update<br> project<br> set<br> alive=?,<br> description=?,<br> destruction_time=?,<br> external_id=?,<br> name=?<br> where<br> proj_id=?<br> and tena_id=?<br> Hibernate:<br> /* get generated state com.halftau.tasks.entities.Project */ select<br> project_.modification_time as modifica9_2_<br> from<br> project project_<br> where<br> project_.proj_id=?<br> and project_.tena_id=?<br>{noformat}<br><br>Which is</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> crearly</span> <span class="diffaddedchars" style="background-color:#ddfade;"> clearly</span> <span class="diffcontext"> wrong, because it doesn't reference the column in the UPDATE statement (should set "modification_time=LOCALTIMESTAMP") but it query the value to get the "updated generated" value. But the value doesn't change, because the field is missing in the update statement.<br><br>I tried to generate a test case for this submission, but i can't make it work. But it seems to me that the information here is very clear and you can check it easily.<br><br>Thanks<br>Pablo Perich<br><br><br></span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HHH-13290?inbox=true&",
"name": "View Issue"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-13290#add-comment?atlOrigin=eyJpIjoiMmRiMmM5ODI5OTVkNDg5NzgwZGJkZjQxYjM5Mzg1YjMiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-e58b8ec1-a256-46bb-a4ea-4187b4c2a5fa" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-13290#add-comment?atlOrigin=eyJpIjoiMmRiMmM5ODI5OTVkNDg5NzgwZGJkZjQxYjM5Mzg1YjMiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-mobile-separated-links" class="mobile-resize-text" width="100%" colspan="2" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> Get Jira notifications on your phone! Download the Jira Cloud app for <a href="https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail" style="color: #3b73af; text-decoration: none">Android</a> or <a href="https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8" style="color: #3b73af; text-decoration: none">iOS</a>
<hr> </td>
</tr>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v1001.0.0-SNAPSHOT#100098-<span title="88964317cbc829ed7f3dfb9b00f54648b6405b36" data-commit-id="88964317cbc829ed7f3dfb9b00f54648b6405b36}">sha1:8896431</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px; opacity: 0.150"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-db6c9ceb-3e90-429f-9ec6-0c2995592983" alt="Atlassian logo" title="Atlassian logo" width="192" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
<img border="0" width="1" height="1" alt="" src="http://atlassian.et.e.sparkpost.com/q/tvy8kCIrY_tugwjkGLN_xw~~/AAAAAQA~/RgReVscTPlcLYXRsYXNzaWFudXNCCgAAk5N1XHcG4ZhSIGhpYmVybmF0ZS1pc3N1ZXNAbGlzdHMuamJvc3Mub3JnWAQAAAAE">
</body>
</html>