<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://avatar-cdn.atlassian.com/6fdbefbff8c445a8a4e37a11f2db1624?s=48&d=https%3A%2F%2Fsecure.gravatar.com%2Favatar%2F6fdbefbff8c445a8a4e37a11f2db1624%3Fd%3Dmm%26s%3D48%26noRedirect%3Dtrue" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="scott.marlow" style="color:#6c797f;; color: #3b73af; text-decoration: none" id="email_scott.marlow" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Aff72c345-4c9e-4140-98cc-5cd4fedbdfac"> Scott Marlow </a> <strong>created</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNzM2ODlmYWI3MDY3NGE2YjkyZTIzYWU2ZDg5OGZjM2IiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-13433?atlOrigin=eyJpIjoiNzM2ODlmYWI3MDY3NGE2YjkyZTIzYWU2ZDg5OGZjM2IiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-b4f9eced-bf41-4529-9b0b-8fddffa82cbb" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HHH-13433?atlOrigin=eyJpIjoiNzM2ODlmYWI3MDY3NGE2YjkyZTIzYWU2ZDg5OGZjM2IiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">HHH-13433</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-13433?atlOrigin=eyJpIjoiNzM2ODlmYWI3MDY3NGE2YjkyZTIzYWU2ZDg5OGZjM2IiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">EntityManager.find() should only check for roll-back-only condition if there is an active JTA transaction, otherwise ORM should throw throw convert( e, lockOptions )</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Issue Type:</th>
<td class="has-icon" style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <img src="cid:jira-generated-image-avatar-b4f9eced-bf41-4529-9b0b-8fddffa82cbb" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"> Bug </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Affects Versions:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> 5.3.9, 5.3.10 </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Assignee:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> Unassigned </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Created:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> 11/Jun/2019 06:10 AM </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Fix Versions:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> 6.0.0.Alpha3, 5.3.11 </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Priority:</th>
<td class="has-icon" style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <img src="cid:jira-generated-image-static-major-f79b78a4-fb51-42b8-8d6c-c31689786b92" height="16" width="16" border="0" align="absmiddle" alt="Major" style="vertical-align: text-bottom"> Major </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Reporter:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="scott.marlow" style="color:#6c797f;; color: #3b73af; text-decoration: none" id="email_scott.marlow" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Aff72c345-4c9e-4140-98cc-5cd4fedbdfac"> Scott Marlow </a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0; margin-top: 0"> <span class="jira-issue-macro resolved" data-jira-key="HHH-12472"> <a href="https://hibernate.atlassian.net/browse/HHH-12472" class="jira-issue-macro-key issue-link" title="WildFly (IronJacamar) - EntityManager#find with roll-back-only leads to exception rather than return null" style="color: #3b73af; text-decoration: none"> <img class="icon" src="https://hibernate.atlassian.net/secure/viewavatar?size=xsmall&avatarId=12150&avatarType=issuetype"> HHH-12472 </a> <span class="aui-lozenge aui-lozenge-subtle aui-lozenge-success jira-macro-single-issue-export-pdf" style="background: #cccccc; border: 1px solid #cccccc; border-radius: 3px; color: #333333; display: inline-block; font-size: 11px; font-weight: bold; line-height: 99%; margin: 0; padding: 2px 5px; text-align: center; text-decoration: none; text-transform: uppercase; background-color: #ffffff; border-color: #cccccc; color: #333333" bgcolor="#ffffff">Closed</span> </span> added a check for roll-back-only condition, however, we should first check for active JTA transaction. </p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">I suggest a change from:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
        <span class="code-keyword" style="color: #000091">public</span> <T> T find(<span class="code-object" style="color: #910091">Class</span><T> entityClass, <span class="code-object" style="color: #910091">Object</span> primaryKey, LockModeType lockModeType, Map<<span class="code-object" style="color: #910091">String</span>, <span class="code-object" style="color: #910091">Object</span>> properties) {
                checkOpen();
                LockOptions lockOptions = <span class="code-keyword" style="color: #000091">null</span>;
                <span class="code-keyword" style="color: #000091">try</span> {
                        getLoadQueryInfluencers().getEffectiveEntityGraph().applyConfiguredGraph( properties );
                        <span class="code-keyword" style="color: #000091">final</span> IdentifierLoadAccess<T> loadAccess = byId( entityClass );
                        loadAccess.with( determineAppropriateLocalCacheMode( properties ) );
                        <span class="code-keyword" style="color: #000091">if</span> ( lockModeType != <span class="code-keyword" style="color: #000091">null</span> ) {
                                <span class="code-keyword" style="color: #000091">if</span> ( !LockModeType.NONE.equals( lockModeType) ) {
                                        checkTransactionNeededForUpdateOperation();
                                }
                                lockOptions = buildLockOptions( lockModeType, properties );
                                loadAccess.with( lockOptions );
                        }
                        <span class="code-keyword" style="color: #000091">return</span> loadAccess.load( (Serializable) primaryKey );
                }
                <span class="code-keyword" style="color: #000091">catch</span> ( EntityNotFoundException ignored ) {
                        <span class="code-comment" style="color: #808080">// DefaultLoadEventListener.returnNarrowedProxy may <span class="code-keyword" style="color: #000091; color: #808080">throw</span> ENFE (see HHH-7861 <span class="code-keyword" style="color: #000091; color: #808080">for</span> details),
</span>                        <span class="code-comment" style="color: #808080">// which find() should not <span class="code-keyword" style="color: #000091; color: #808080">throw</span>. Find() should <span class="code-keyword" style="color: #000091; color: #808080">return</span> <span class="code-keyword" style="color: #000091; color: #808080">null</span> <span class="code-keyword" style="color: #000091; color: #808080">if</span> the entity was not found.
</span>                        <span class="code-keyword" style="color: #000091">if</span> ( log.isDebugEnabled() ) {
                                <span class="code-object" style="color: #910091">String</span> entityName = entityClass != <span class="code-keyword" style="color: #000091">null</span> ? entityClass.getName(): <span class="code-keyword" style="color: #000091">null</span>;
                                <span class="code-object" style="color: #910091">String</span> identifierValue = primaryKey != <span class="code-keyword" style="color: #000091">null</span> ? primaryKey.toString() : <span class="code-keyword" style="color: #000091">null</span> ;
                                log.ignoringEntityNotFound( entityName, identifierValue );
                        }
                        <span class="code-keyword" style="color: #000091">return</span> <span class="code-keyword" style="color: #000091">null</span>;
                }
                <span class="code-keyword" style="color: #000091">catch</span> ( ObjectDeletedException e ) {
                        <span class="code-comment" style="color: #808080">//the spec is silent about people doing remove() find() on the same PC
</span>                        <span class="code-keyword" style="color: #000091">return</span> <span class="code-keyword" style="color: #000091">null</span>;
                }
                <span class="code-keyword" style="color: #000091">catch</span> ( ObjectNotFoundException e ) {
                        <span class="code-comment" style="color: #808080">//should not happen on the entity itself with get
</span>                        <span class="code-keyword" style="color: #000091">throw</span> <span class="code-keyword" style="color: #000091">new</span> IllegalArgumentException( e.getMessage(), e );
                }
                <span class="code-keyword" style="color: #000091">catch</span> ( MappingException | TypeMismatchException | ClassCastException e ) {
                        <span class="code-keyword" style="color: #000091">throw</span> exceptionConverter.convert( <span class="code-keyword" style="color: #000091">new</span> IllegalArgumentException( e.getMessage(), e ) );
                }
                <span class="code-keyword" style="color: #000091">catch</span> ( JDBCException e ) {
                        <span class="code-keyword" style="color: #000091">if</span> ( accessTransaction().getRollbackOnly() ) {
                                <span class="code-comment" style="color: #808080">// assume <span class="code-keyword" style="color: #000091; color: #808080">this</span> is the similar to the WildFly / IronJacamar <span class="code-quote" style="color: #009100; color: #808080">"feature"</span> described under HHH-12472
</span>                                <span class="code-keyword" style="color: #000091">return</span> <span class="code-keyword" style="color: #000091">null</span>;
                        }
                        <span class="code-keyword" style="color: #000091">else</span> {
                                <span class="code-keyword" style="color: #000091">throw</span> exceptionConverter.convert( e, lockOptions );
                        }
                }
                <span class="code-keyword" style="color: #000091">catch</span> ( RuntimeException e ) {
                        <span class="code-keyword" style="color: #000091">throw</span> exceptionConverter.convert( e, lockOptions );
                }
                <span class="code-keyword" style="color: #000091">finally</span> {
                        getLoadQueryInfluencers().getEffectiveEntityGraph().clear();
                }
        }
</pre>
</div>
</div> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">Change instead to:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
        <span class="code-keyword" style="color: #000091">public</span> <T> T find(<span class="code-object" style="color: #910091">Class</span><T> entityClass, <span class="code-object" style="color: #910091">Object</span> primaryKey, LockModeType lockModeType, Map<<span class="code-object" style="color: #910091">String</span>, <span class="code-object" style="color: #910091">Object</span>> properties) {
                checkOpen();
                LockOptions lockOptions = <span class="code-keyword" style="color: #000091">null</span>;
                <span class="code-keyword" style="color: #000091">try</span> {
                        getLoadQueryInfluencers().getEffectiveEntityGraph().applyConfiguredGraph( properties );
                        <span class="code-keyword" style="color: #000091">final</span> IdentifierLoadAccess<T> loadAccess = byId( entityClass );
                        loadAccess.with( determineAppropriateLocalCacheMode( properties ) );
                        <span class="code-keyword" style="color: #000091">if</span> ( lockModeType != <span class="code-keyword" style="color: #000091">null</span> ) {
                                <span class="code-keyword" style="color: #000091">if</span> ( !LockModeType.NONE.equals( lockModeType) ) {
                                        checkTransactionNeededForUpdateOperation();
                                }
                                lockOptions = buildLockOptions( lockModeType, properties );
                                loadAccess.with( lockOptions );
                        }
                        <span class="code-keyword" style="color: #000091">return</span> loadAccess.load( (Serializable) primaryKey );
                }
                <span class="code-keyword" style="color: #000091">catch</span> ( EntityNotFoundException ignored ) {
                        <span class="code-comment" style="color: #808080">// DefaultLoadEventListener.returnNarrowedProxy may <span class="code-keyword" style="color: #000091; color: #808080">throw</span> ENFE (see HHH-7861 <span class="code-keyword" style="color: #000091; color: #808080">for</span> details),
</span>                        <span class="code-comment" style="color: #808080">// which find() should not <span class="code-keyword" style="color: #000091; color: #808080">throw</span>. Find() should <span class="code-keyword" style="color: #000091; color: #808080">return</span> <span class="code-keyword" style="color: #000091; color: #808080">null</span> <span class="code-keyword" style="color: #000091; color: #808080">if</span> the entity was not found.
</span>                        <span class="code-keyword" style="color: #000091">if</span> ( log.isDebugEnabled() ) {
                                <span class="code-object" style="color: #910091">String</span> entityName = entityClass != <span class="code-keyword" style="color: #000091">null</span> ? entityClass.getName(): <span class="code-keyword" style="color: #000091">null</span>;
                                <span class="code-object" style="color: #910091">String</span> identifierValue = primaryKey != <span class="code-keyword" style="color: #000091">null</span> ? primaryKey.toString() : <span class="code-keyword" style="color: #000091">null</span> ;
                                log.ignoringEntityNotFound( entityName, identifierValue );
                        }
                        <span class="code-keyword" style="color: #000091">return</span> <span class="code-keyword" style="color: #000091">null</span>;
                }
                <span class="code-keyword" style="color: #000091">catch</span> ( ObjectDeletedException e ) {
                        <span class="code-comment" style="color: #808080">//the spec is silent about people doing remove() find() on the same PC
</span>                        <span class="code-keyword" style="color: #000091">return</span> <span class="code-keyword" style="color: #000091">null</span>;
                }
                <span class="code-keyword" style="color: #000091">catch</span> ( ObjectNotFoundException e ) {
                        <span class="code-comment" style="color: #808080">//should not happen on the entity itself with get
</span>                        <span class="code-keyword" style="color: #000091">throw</span> <span class="code-keyword" style="color: #000091">new</span> IllegalArgumentException( e.getMessage(), e );
                }
                <span class="code-keyword" style="color: #000091">catch</span> ( MappingException | TypeMismatchException | ClassCastException e ) {
                        <span class="code-keyword" style="color: #000091">throw</span> exceptionConverter.convert( <span class="code-keyword" style="color: #000091">new</span> IllegalArgumentException( e.getMessage(), e ) );
                }
                <span class="code-keyword" style="color: #000091">catch</span> ( JDBCException e ) {
<span class="code-comment" style="color: #808080">// Note one line change is below.
</span>                        <span class="code-keyword" style="color: #000091">if</span> ( accessTransaction().isActive() && accessTransaction().getRollbackOnly() && accessTransaction().getRollbackOnly() ) {
                                <span class="code-comment" style="color: #808080">// assume <span class="code-keyword" style="color: #000091; color: #808080">this</span> is the similar to the WildFly / IronJacamar <span class="code-quote" style="color: #009100; color: #808080">"feature"</span> described under HHH-12472
</span>                                <span class="code-keyword" style="color: #000091">return</span> <span class="code-keyword" style="color: #000091">null</span>;
                        }
                        <span class="code-keyword" style="color: #000091">else</span> {
                                <span class="code-keyword" style="color: #000091">throw</span> exceptionConverter.convert( e, lockOptions );
                        }
                }
                <span class="code-keyword" style="color: #000091">catch</span> ( RuntimeException e ) {
                        <span class="code-keyword" style="color: #000091">throw</span> exceptionConverter.convert( e, lockOptions );
                }
                <span class="code-keyword" style="color: #000091">finally</span> {
                        getLoadQueryInfluencers().getEffectiveEntityGraph().clear();
                }
        }
</pre>
</div>
</div> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">I'll try the above change locally and check if the current ORM testsuite still passes (on ORM master branch).</p> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HHH-13433?inbox=true&",
"name": "View Issue"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-13433#add-comment?atlOrigin=eyJpIjoiNzM2ODlmYWI3MDY3NGE2YjkyZTIzYWU2ZDg5OGZjM2IiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-2dc29411-d356-42dc-b148-f04efc95dde2" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-13433#add-comment?atlOrigin=eyJpIjoiNzM2ODlmYWI3MDY3NGE2YjkyZTIzYWU2ZDg5OGZjM2IiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-mobile-separated-links" class="mobile-resize-text" width="100%" colspan="2" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> Get Jira notifications on your phone! Download the Jira Cloud app for <a href="https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail" style="color: #3b73af; text-decoration: none">Android</a> or <a href="https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8" style="color: #3b73af; text-decoration: none">iOS</a>
<hr> </td>
</tr>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v1001.0.0-SNAPSHOT#100104-<span title="e74401839afd1d2be5e433a87b424508c0665600" data-commit-id="e74401839afd1d2be5e433a87b424508c0665600}">sha1:e744018</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px; opacity: 0.150"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-93c3ddfa-d42b-4ec7-a867-3d80b099f6a5" alt="Atlassian logo" title="Atlassian logo" width="192" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
<img border="0" width="1" height="1" alt="" src="http://atlassian.et.e.sparkpost.com/q/6hthVoIj9MybUHckYCW4pg~~/AAAAAQA~/RgRe4NuuPlcLYXRsYXNzaWFudXNCCgAALqj_XMrVaJBSIGhpYmVybmF0ZS1pc3N1ZXNAbGlzdHMuamJvc3Mub3JnWAQAAAAE">
</body>
</html>