<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/98425049e9f0a2d236e002c6340bc9f6?d=https%3A%2F%2Favatar-management--avatars.us-west-2.prod.public.atl-paas.net%2Finitials%2FMK-2.png&size=48&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="mariuskleber" style="color:#6c797f;; color: #3b73af; text-decoration: none" id="email_mariuskleber" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ace03a44f-1826-4c69-8b75-43d36df84ffb"> Marius Kleber </a> <strong>updated</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiYTM5ZjU2ODczZDY1NDRkMmFkMGMxZDIwNDM1OTRlYTAiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-13612?atlOrigin=eyJpIjoiYTM5ZjU2ODczZDY1NDRkMmFkMGMxZDIwNDM1OTRlYTAiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-e28ee989-cf8a-4c74-87ab-04eb71c95138" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HHH-13612?atlOrigin=eyJpIjoiYTM5ZjU2ODczZDY1NDRkMmFkMGMxZDIwNDM1OTRlYTAiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">HHH-13612</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-13612?atlOrigin=eyJpIjoiYTM5ZjU2ODczZDY1NDRkMmFkMGMxZDIwNDM1OTRlYTAiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">Quoted table name in FROM clause in @Formula gets wrongly qualified with generated alias</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Change By:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="mariuskleber" style="color:#6c797f;; color: #3b73af; text-decoration: none" id="email_mariuskleber" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ace03a44f-1826-4c69-8b75-43d36df84ffb"> Marius Kleber </a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <span class="diffcontext">h3. SUMMARY<br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br></span> <span class="diffcontext">An entity attribute mapped with the {{@Formula}} annotation that contains a subselect as value, that in turn contains a table name in the FROM clause which is quoted, leads to a wrongly generated SQL. Quoting the table name in the FROM clause may be necessary depending on the underlying DBMS, if the table name is also a reserved keyword. In my case it's a table named {{transaction}} (as in the SQL keyword) that needs quoting for the underlying HSQLDB.<br><br>h3. STEPS TO REPRODUCE<br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br></span> <span class="diffcontext"># Map an entity attribute via the {{@Formula}} annotation and set the following query as value: {{(SELECT t.value_a FROM \</span> <span class="diffaddedchars" style="background-color:#ddfade;">\</span> <span class="diffcontext">"table\</span> <span class="diffaddedchars" style="background-color:#ddfade;">\</span> <span class="diffcontext">" t WHERE t.value_b = outer_value)}}<br># Trigger a load of such an entity<br><br>h3. EXPECTED RESULT<br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br></span> <span class="diffcontext">Generation of the following SQL: <br>{{select ..., (SELECT t.value_a FROM "table" t WHERE t.value_b = outerTable0_.outer_value) as formula0_ from OuterTable outerTable0_ ...}}<br>Note that the quoted table name in the FROM clause in the subselect is not qualified with the generated alias from the outer table, but verbatim.<br><br>h3. ACTUAL RESULT<br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br></span> <span class="diffcontext">Generation of the following SQL: <br>{{select ..., (SELECT t.value_a FROM outerTable0_."table" t WHERE t.value_b = outerTable0_.outer_value) as formula0_ from OuterTable outerTable0_ ...}}<br>Note that the quoted table name in the FROM clause in the subselect is qualified with the generated alias from the outer table.<br><br>h3. MORE DETAILS<br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br></span> <span class="diffcontext">Omitting the quotes for the table name leads to an exception if HSQLDB is used as DBMS: {{org.hsqldb.HsqlException: unexpected token: SELECT}}. It seems that HSQLDB can't handle the unquoted use of the SQL keyword {{transaction}} in the FROM clause and thus fails to compile the subselect (see e.g. [this|https://sourceforge.net/p/hsqldb/discussion/73674/thread/33dea69d/] discussion for a similar example). Properly quoting the table name helps. This has been verified via overwriting the wrong qualification in the generated SQL at runtime.<br>PostgreSQL on the other hand handles the unquoted use well.<br><br>h3. REPRODUCER TEST CASE<br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">{code:java|title=</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br>*</span> <span class="diffcontext">org.hibernate.sql.TemplateTest</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">}</span> <span class="diffaddedchars" style="background-color:#ddfade;">*</span> <span class="diffcontext"><br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br>{code:java}</span> <span class="diffcontext"> ...<br> @Test<br> public void testQuotedTableNameNotQualified() {<br> String fragment = "(SELECT t.value_a FROM \"table\" t WHERE t.value_b = outer_value)";<br> String template = Template.renderWhereStringTemplate( fragment, Template.TEMPLATE, DIALECT, FUNCTION_REGISTRY );<br><br> assertEquals("(SELECT t.value_a FROM \"table\" t WHERE t.value_b = " + Template.TEMPLATE + ".outer_value)", template);<br> }<br> ...</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">{code}<br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br></span> <span class="diffcontext">The test case fails on 5.3.7.Final and on 5.4.5-SNAPSHOT.<br><br>h3. PROPOSED FIX<br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">{code:java|title=</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br>*</span> <span class="diffcontext">org.hibernate.sql.Template</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">}</span> <span class="diffaddedchars" style="background-color:#ddfade;">*</span> <span class="diffcontext"><br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br>{code:java}</span> <span class="diffcontext">--- hibernate-core/src/main/java/org/hibernate/sql/Template.java (revision ea301a7084fbbde81b749e64908369aa382d0962)<br>+++ hibernate-core/src/main/java/org/hibernate/sql/Template.java (date 1567533972000)<br>@@ -193,7 +193,7 @@<br> isOpenQuote = false;<br> }<br> <br>- if ( isOpenQuote ) {<br>+ if ( isOpenQuote && !inFromClause ) {<br> result.append( placeholder ).append( '.' );<br> }<br> }</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br><br></span> <span class="diffcontext">{code}<br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br></span> <span class="diffcontext">The fix is probably not the best solution as there may be use cases that require qualification in the FROM clause.</span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HHH-13612?inbox=true&",
"name": "View Issue"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-13612#add-comment?atlOrigin=eyJpIjoiYTM5ZjU2ODczZDY1NDRkMmFkMGMxZDIwNDM1OTRlYTAiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-203889c6-f580-4f86-af02-0170607c5ab6" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-13612#add-comment?atlOrigin=eyJpIjoiYTM5ZjU2ODczZDY1NDRkMmFkMGMxZDIwNDM1OTRlYTAiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-mobile-separated-links" class="mobile-resize-text" width="100%" colspan="2" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> Get Jira notifications on your phone! Download the Jira Cloud app for <a href="https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail" style="color: #3b73af; text-decoration: none">Android</a> or <a href="https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8" style="color: #3b73af; text-decoration: none">iOS</a>
<hr> </td>
</tr>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v1001.0.0-SNAPSHOT#100108-<span title="4e1c99e10ced234b7c6e62a2060596340b7761b6" data-commit-id="4e1c99e10ced234b7c6e62a2060596340b7761b6}">sha1:4e1c99e</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px; opacity: 0.150"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-f694d4fd-eb73-4873-bba5-5acb559c9d65" alt="Atlassian logo" title="Atlassian logo" width="192" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
<img border="0" width="1" height="1" alt="" src="http://atlassian.et.e.sparkpost.com/q/nz_wP25T5tea68lhvt2z4A~~/AAAAAQA~/RgRfT_tLPlcLYXRsYXNzaWFudXNCCgAAy8duXXpuSOdSIGhpYmVybmF0ZS1pc3N1ZXNAbGlzdHMuamJvc3Mub3JnWAQAAAAE">
</body>
</html>