<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/2d131cda7494bc190560169512e52be2?d=https%3A%2F%2Favatar-management--avatars.us-west-2.prod.public.atl-paas.net%2Finitials%2FLD-2.png&size=48&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="mimmoz81" style="color:#6c797f;; color: #3b73af; text-decoration: none" id="email_mimmoz81" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ac46239ee-34b9-47b5-9333-e8e44e4f6917"> Luca Domenichini </a> <strong>updated</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiYmI2MjdjMmE0ZjA2NDBlY2I1ZDExNjMwODQ2ODdhNzYiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-13639?atlOrigin=eyJpIjoiYmI2MjdjMmE0ZjA2NDBlY2I1ZDExNjMwODQ2ODdhNzYiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-3dfedc63-8c76-4375-8c8c-1878368ee482" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HHH-13639?atlOrigin=eyJpIjoiYmI2MjdjMmE0ZjA2NDBlY2I1ZDExNjMwODQ2ODdhNzYiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">HHH-13639</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-13639?atlOrigin=eyJpIjoiYmI2MjdjMmE0ZjA2NDBlY2I1ZDExNjMwODQ2ODdhNzYiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">Schema Validation fails with a database sequence not returning BIGINT / Long column type in its definition</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Change By:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="mimmoz81" style="color:#6c797f;; color: #3b73af; text-decoration: none" id="email_mimmoz81" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ac46239ee-34b9-47b5-9333-e8e44e4f6917"> Luca Domenichini </a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <span class="diffcontext">When enabling the schema validation through {{hibernate.hbm2ddl.auto=validate}}, starting from ORM 5.4.0.CR1 up to 5.4.5.Final, due to [HHH-12973] fix and 1db476dbd5ec4f852472b953d50a8caa073efd6d commit, the validation of a sequence not being of BIGINT type fails.<br><br>In class {{org.hibernate.tool.schema.extract.internal.SequenceInformationExtractorLegacyImpl}}, method {{extractMetadata()}} calls {{resultSetStartValueSize()}} that in turn calls {{resultSet.getLong(column)}}.<br>If the sequence is defined as<br>{{CREATE SEQUENCE \[dbo].\[SampleSequence] }}<br>{{AS \[int]}}<br>{{START WITH 1}}<br>{{INCREMENT BY 1}}<br>{{MINVALUE 1}}<br>{{MAXVALUE 100}}<br><br><br>the underlying jdbc type will be INT, resulting in a java.lang.Integer and causing this exception during schema validation (even if that sequence is not used at all):<br><br>{{javax.persistence.PersistenceException: \[PersistenceUnit: PromagWMS] Unable to build Hibernate SessionFactory}}<br>{{at org.hibernate.jpa.boot.internal.EntityManagerFactoryBuilderImpl.persistenceException(EntityManagerFactoryBuilderImpl.java:1012) ~\[hibernate-core-5.4.5.Final.jar:5.4.5.Final]}}<br>{{at org.hibernate.jpa.boot.internal.EntityManagerFactoryBuilderImpl.build(EntityManagerFactoryBuilderImpl.java:938) ~\[hibernate-core-5.4.5.Final.jar:5.4.5.Final]}}<br>{{at org.hibernate.jpa.HibernatePersistenceProvider.createEntityManagerFactory(HibernatePersistenceProvider.java:56) ~\[hibernate-core-5.4.5.Final.jar:5.4.5.Final]}}<br>{{at javax.persistence.Persistence.createEntityManagerFactory(Persistence.java:79) ~\[javax.persistence-api-2.2.jar:2.2]}}<br>{{... 4 more \[...]}}<br>{{Caused by: java.lang.ClassCastException: java.lang.Integer cannot be cast to java.lang.Long}}<br>{{at com.microsoft.sqlserver.jdbc.SQLServerResultSet.getLong(SQLServerResultSet.java:2328) ~\[mssql-jdbc-7.4.1.jre8.jar:?]}}<br>{{at com.zaxxer.hikari.pool.HikariProxyResultSet.getLong(HikariProxyResultSet.java) ~\[HikariCP-3.4.1.jar:?]}}<br>{{at org.hibernate.tool.schema.extract.internal.SequenceInformationExtractorLegacyImpl.resultSetStartValueSize(SequenceInformationExtractorLegacyImpl.java:129) ~\[hibernate-core-5.4.5.Final.jar:5.4.5.Final]}}<br>{{at org.hibernate.tool.schema.extract.internal.SequenceInformationExtractorLegacyImpl.extractMetadata(SequenceInformationExtractorLegacyImpl.java:59) ~\[hibernate-core-5.4.5.Final.jar:5.4.5.Final]}}<br>{{at org.hibernate.tool.schema.extract.internal.DatabaseInformationImpl.initializeSequences(DatabaseInformationImpl.java:65) ~\[hibernate-core-5.4.5.Final.jar:5.4.5.Final]}}<br>{{at org.hibernate.tool.schema.extract.internal.DatabaseInformationImpl.<init>(DatabaseInformationImpl.java:59) ~\[hibernate-core-5.4.5.Final.jar:5.4.5.Final]}}<br>{{at org.hibernate.tool.schema.internal.Helper.buildDatabaseInformation(Helper.java:155) ~\[hibernate-core-5.4.5.Final.jar:5.4.5.Final]}}<br>{{at org.hibernate.tool.schema.internal.AbstractSchemaValidator.doValidation(AbstractSchemaValidator.java:61) ~\[hibernate-core-5.4.5.Final.jar:5.4.5.Final]}}<br>{{at org.hibernate.tool.schema.spi.SchemaManagementToolCoordinator.performDatabaseAction(SchemaManagementToolCoordinator.java:192) ~\[hibernate-core-5.4.5.Final.jar:5.4.5.Final]}}<br>{{at org.hibernate.tool.schema.spi.SchemaManagementToolCoordinator.process(SchemaManagementToolCoordinator.java:73) ~\[hibernate-core-5.4.5.Final.jar:5.4.5.Final]}}<br>{{at org.hibernate.internal.SessionFactoryImpl.<init>(SessionFactoryImpl.java:320) ~\[hibernate-core-5.4.5.Final.jar:5.4.5.Final]}}<br>{{at org.hibernate.boot.internal.SessionFactoryBuilderImpl.build(SessionFactoryBuilderImpl.java:462) ~\[hibernate-core-5.4.5.Final.jar:5.4.5.Final]}}<br>{{at org.hibernate.jpa.boot.internal.EntityManagerFactoryBuilderImpl.build(EntityManagerFactoryBuilderImpl.java:935) ~\[hibernate-core-5.4.5.Final.jar:5.4.5.Final]}}<br>{{at org.hibernate.jpa.HibernatePersistenceProvider.createEntityManagerFactory(HibernatePersistenceProvider.java:56) ~\[hibernate-core-5.4.5.Final.jar:5.4.5.Final]}}<br>{{at javax.persistence.Persistence.createEntityManagerFactory(Persistence.java:79) ~\[javax.persistence-api-2.2.jar:2.2]}}<br>{{... 4 more \[...]}}<br><br><br>My workaround for MSSQL and my specific use-case, is just to change the sequence query string by using a custom dialect that converts columns into BIGINT type:<br>{{@Override}}<br>{{public String getQuerySequencesString() \{}}<br>{{return "SELECT sequence_name"}}<br>{{+ ", sequence_catalog"}}<br>{{+ ", sequence_schema"}}<br>{{+ ", CONVERT(BIGINT, start_value) start_value"}}<br>{{+ ", CONVERT(BIGINT, minimum_value) minimum_value"}}<br>{{+ ", CONVERT(BIGINT, maximum_value) maximum_value"}}<br>{{+ ", CONVERT(BIGINT, increment) increment"}}<br>{{+ " FROM INFORMATION_SCHEMA.SEQUENCES";}}<br>{{}}}<br><br><br>Since class {{SequenceInformationExtractorLegacyImpl}} just casts those columns to java.lang.Long, I think a similar approach should be taken for every possible dialect</span> <span class="diffaddedchars" style="background-color:#ddfade;">, or the explicit cast to Long should be changed to something more robust</span> <span class="diffcontext">..</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">.</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br><br></span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HHH-13639?inbox=true&",
"name": "View Issue"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-13639#add-comment?atlOrigin=eyJpIjoiYmI2MjdjMmE0ZjA2NDBlY2I1ZDExNjMwODQ2ODdhNzYiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-3c194cfd-f8ab-4f1d-b888-19c6478e0b59" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-13639#add-comment?atlOrigin=eyJpIjoiYmI2MjdjMmE0ZjA2NDBlY2I1ZDExNjMwODQ2ODdhNzYiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-mobile-separated-links" class="mobile-resize-text" width="100%" colspan="2" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> Get Jira notifications on your phone! Download the Jira Cloud app for <a href="https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail" style="color: #3b73af; text-decoration: none">Android</a> or <a href="https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8" style="color: #3b73af; text-decoration: none">iOS</a>
<hr> </td>
</tr>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v1001.0.0-SNAPSHOT#100110-<span title="2b29835068c3c32b592ae6c8a189efa3b1e7fc2a" data-commit-id="2b29835068c3c32b592ae6c8a189efa3b1e7fc2a}">sha1:2b29835</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px; opacity: 0.150"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-eecd74f8-d4f3-4d39-bdaf-b146edc8b96d" alt="Atlassian logo" title="Atlassian logo" width="192" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
<img border="0" width="1" height="1" alt="" src="http://atlassian.et.e.sparkpost.com/q/61txQsZhBmFfH0xt8xmIoA~~/AAAAAQA~/RgRfavaUPlcLYXRsYXNzaWFudXNCCgAAFMOJXf8CgBxSIGhpYmVybmF0ZS1pc3N1ZXNAbGlzdHMuamJvc3Mub3JnWAQAAAAE">
</body>
</html>