<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/4a2efbb7626343fb9c04bc3075b6bd73?d=https%3A%2F%2Favatar-management--avatars.us-west-2.prod.public.atl-paas.net%2Finitials%2FCD-2.png&size=48&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="ChristophDreis" style="color:#6c797f;; color: #3b73af; text-decoration: none" id="email_ChristophDreis" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A28629985-c0e1-4d5c-9179-b7fab9c270f3"> Christoph Dreis </a> <strong>created</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNzRmNDkyZTgyMjQ0NDY5Nzg4NTA4ZTEzYjkzYWU5OWYiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-13675?atlOrigin=eyJpIjoiNzRmNDkyZTgyMjQ0NDY5Nzg4NTA4ZTEzYjkzYWU5OWYiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-e0910874-ff3b-4d62-95a0-88475b37b728" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HHH-13675?atlOrigin=eyJpIjoiNzRmNDkyZTgyMjQ0NDY5Nzg4NTA4ZTEzYjkzYWU5OWYiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">HHH-13675</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-13675?atlOrigin=eyJpIjoiNzRmNDkyZTgyMjQ0NDY5Nzg4NTA4ZTEzYjkzYWU5OWYiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">Optimize PersistentBag.groupByEqualityHash()</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Issue Type:</th>
<td class="has-icon" style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <img src="cid:jira-generated-image-avatar-e0910874-ff3b-4d62-95a0-88475b37b728" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"> Bug </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Affects Versions:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> 5.4.6 </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Assignee:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> Unassigned </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Components:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> hibernate-core </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Created:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> 17/Oct/2019 13:53 PM </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Priority:</th>
<td class="has-icon" style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <img src="cid:jira-generated-image-static-minor-dcb63c34-070e-4d2c-a35b-cbb6e96f9513" height="16" width="16" border="0" align="absmiddle" alt="Minor" style="vertical-align: text-bottom"> Minor </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Reporter:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="ChristophDreis" style="color:#6c797f;; color: #3b73af; text-decoration: none" id="email_ChristophDreis" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A28629985-c0e1-4d5c-9179-b7fab9c270f3"> Christoph Dreis </a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0; margin-top: 0">Hi,</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">I just noticed a possible optimization opportunity in PersistentBag that should save a few cycles. The idea is to:</p>
<ul>
<li>introduce a check for empty inputs</li>
<li>desugar the Stream API in a vanilla loop</li>
</ul> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">In an isolated benchmark this shows the following improvements for a non empty list:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
Benchmark Mode Cnt Score Error Units
MyBenchmark.testOld thrpt 10 4918160,848 ± 476333,853 ops/s
MyBenchmark.testOld:·gc.alloc.rate thrpt 10 3674,990 ± 356,040 MB/sec
MyBenchmark.testOld:·gc.alloc.rate.norm thrpt 10 784,000 ± 0,001 B/op
MyBenchmark.testOld:·gc.churn.G1_Eden_Space thrpt 10 3691,743 ± 424,599 MB/sec
MyBenchmark.testOld:·gc.churn.G1_Eden_Space.norm thrpt 10 787,379 ± 38,252 B/op
MyBenchmark.testOld:·gc.churn.G1_Old_Gen thrpt 10 0,008 ± 0,005 MB/sec
MyBenchmark.testOld:·gc.churn.G1_Old_Gen.norm thrpt 10 0,002 ± 0,001 B/op
MyBenchmark.testOld:·gc.count thrpt 10 132,000 counts
MyBenchmark.testOld:·gc.time thrpt 10 132,000 ms
MyBenchmark.testDesugared thrpt 10 7748712,133 ± 678271,480 ops/s
MyBenchmark.testDesugared:·gc.alloc.rate thrpt 10 3781,201 ± 331,242 MB/sec
MyBenchmark.testDesugared:·gc.alloc.rate.norm thrpt 10 512,000 ± 0,001 B/op
MyBenchmark.testDesugared:·gc.churn.G1_Eden_Space thrpt 10 3748,724 ± 388,681 MB/sec
MyBenchmark.testDesugared:·gc.churn.G1_Eden_Space.norm thrpt 10 507,465 ± 21,594 B/op
MyBenchmark.testDesugared:·gc.churn.G1_Old_Gen thrpt 10 0,006 ± 0,005 MB/sec
MyBenchmark.testDesugared:·gc.churn.G1_Old_Gen.norm thrpt 10 0,001 ± 0,001 B/op
MyBenchmark.testDesugared:·gc.count thrpt 10 124,000 counts
MyBenchmark.testDesugared:·gc.time thrpt 10 126,000 ms
</pre>
</div>
</div> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">For an empty list the following results are produced (testNew being the one with the additional isEmpty() check):</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
Benchmark Mode Cnt Score Error Units
MyBenchmark.testNew thrpt 10 271737559,697 ± 26986324,099 ops/s
MyBenchmark.testNew:·gc.alloc.rate thrpt 10 0,001 ± 0,001 MB/sec
MyBenchmark.testNew:·gc.alloc.rate.norm thrpt 10 ? 10?? B/op
MyBenchmark.testNew:·gc.count thrpt 10 ? 0 counts
MyBenchmark.testOld thrpt 10 16822457,057 ± 923755,443 ops/s
MyBenchmark.testOld:·gc.alloc.rate thrpt 10 4361,487 ± 239,553 MB/sec
MyBenchmark.testOld:·gc.alloc.rate.norm thrpt 10 272,000 ± 0,001 B/op
MyBenchmark.testOld:·gc.churn.G1_Eden_Space thrpt 10 4348,023 ± 243,096 MB/sec
MyBenchmark.testOld:·gc.churn.G1_Eden_Space.norm thrpt 10 271,328 ± 15,091 B/op
MyBenchmark.testOld:·gc.churn.G1_Old_Gen thrpt 10 0,005 ± 0,005 MB/sec
MyBenchmark.testOld:·gc.churn.G1_Old_Gen.norm thrpt 10 ? 10?? B/op
MyBenchmark.testOld:·gc.count thrpt 10 133,000 counts
MyBenchmark.testOld:·gc.time thrpt 10 136,000 ms
MyBenchmark.testOldDesugared thrpt 10 98931889,728 ± 3022778,400 ops/s
MyBenchmark.testOldDesugared:·gc.alloc.rate thrpt 10 4526,090 ± 138,244 MB/sec
MyBenchmark.testOldDesugared:·gc.alloc.rate.norm thrpt 10 48,000 ± 0,001 B/op
MyBenchmark.testOldDesugared:·gc.churn.G1_Eden_Space thrpt 10 4527,010 ± 229,722 MB/sec
MyBenchmark.testOldDesugared:·gc.churn.G1_Eden_Space.norm thrpt 10 48,015 ± 2,202 B/op
MyBenchmark.testOldDesugared:·gc.churn.G1_Old_Gen thrpt 10 0,006 ± 0,004 MB/sec
MyBenchmark.testOldDesugared:·gc.churn.G1_Old_Gen.norm thrpt 10 ? 10?? B/op
MyBenchmark.testOldDesugared:·gc.count thrpt 10 132,000 counts
MyBenchmark.testOldDesugared:·gc.time thrpt 10 133,000 ms
</pre>
</div>
</div> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">PR is attached.</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">Cheers,<br> Christoph</p> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HHH-13675?inbox=true&",
"name": "View Issue"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-13675#add-comment?atlOrigin=eyJpIjoiNzRmNDkyZTgyMjQ0NDY5Nzg4NTA4ZTEzYjkzYWU5OWYiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-3d537006-f258-444d-a386-2e413a973c8a" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-13675#add-comment?atlOrigin=eyJpIjoiNzRmNDkyZTgyMjQ0NDY5Nzg4NTA4ZTEzYjkzYWU5OWYiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-mobile-separated-links" class="mobile-resize-text" width="100%" colspan="2" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> Get Jira notifications on your phone! Download the Jira Cloud app for <a href="https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail" style="color: #3b73af; text-decoration: none">Android</a> or <a href="https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8" style="color: #3b73af; text-decoration: none">iOS</a>
<hr> </td>
</tr>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v1001.0.0-SNAPSHOT#100113-<span title="b2b9d899e1c28b8c6b0ef89532caaf5f19be9b80" data-commit-id="b2b9d899e1c28b8c6b0ef89532caaf5f19be9b80}">sha1:b2b9d89</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px; opacity: 0.150"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-0bd17be5-4dff-45c1-9c18-7130379b957c" alt="Atlassian logo" title="Atlassian logo" width="192" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
<img border="0" width="1" height="1" alt="" src="http://atlassian.et.e.sparkpost.com/q/Rh7H8oPqkyR_02bWIGJVFQ~~/AAAAAQA~/RgRfighLPlcLYXRsYXNzaWFudXNCCgAAy9SoXZNL14NSIGhpYmVybmF0ZS1pc3N1ZXNAbGlzdHMuamJvc3Mub3JnWAQAAAAE">
</body>
</html>