<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/9a811dc08e94899d343eefca1ebdab20?d=https%3A%2F%2Favatar-management--avatars.us-west-2.prod.public.atl-paas.net%2Finitials%2FFS-2.png&size=48&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="fscheffold" style="color:#6c797f;; color: #3b73af; text-decoration: none" id="email_fscheffold" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5c8f9c247792242c86137410"> Frank S </a> <strong>updated</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMDFhNDdlOTI4NjA0NGRjNmExNzEwZDk4ZDkxYWY0NDEiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-13768?atlOrigin=eyJpIjoiMDFhNDdlOTI4NjA0NGRjNmExNzEwZDk4ZDkxYWY0NDEiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-87c8f17d-b78f-4805-8ec6-e10e91baf57e" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HHH-13768?atlOrigin=eyJpIjoiMDFhNDdlOTI4NjA0NGRjNmExNzEwZDk4ZDkxYWY0NDEiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">HHH-13768</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-13768?atlOrigin=eyJpIjoiMDFhNDdlOTI4NjA0NGRjNmExNzEwZDk4ZDkxYWY0NDEiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">Flush / Version Increment not consistent</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Change By:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="fscheffold" style="color:#6c797f;; color: #3b73af; text-decoration: none" id="email_fscheffold" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5c8f9c247792242c86137410"> Frank S </a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <span class="diffcontext">As mentioned in</span> <span class="diffaddedchars" style="background-color:#ddfade;"> [</span> <span class="diffcontext"> HHH-8487</span> <span class="diffaddedchars" style="background-color:#ddfade;">]</span> <span class="diffcontext"> flush to the database is always done before accessing an entity via native SQL or HQL query when FlushModeType.AUTO is enabled.<br><br>So the @Version annotated property is always incremented when an update / merge with fetch with SQL of an entity occurs.<br>But when doing an update to an entity and access it with {{entityManager.find( )}} the version is not incremented. So this behavior is inconsistent according to fetching over SQL.<br>Should a flush to the database not also be done when calling {{entityManager.find( )}}?<br><br>Consider the testcase below as example:<br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br></span> <span class="diffcontext">{code:java}</span> <span class="diffaddedchars" style="background-color:#ddfade;">package org.hibernate.bugs;</span> <span class="diffcontext"><br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br>import org.apache.log4j.Logger;<br>import org.junit.After;<br>import org.junit.Before;<br>import org.junit.Test;<br><br>import javax.persistence.*;<br><br>import java.util.List;<br><br>import static org.hamcrest.CoreMatchers.is;<br>import static org.junit.Assert.assertThat;<br><br>/**<br> * This template demonstrates how to develop a test case for Hibernate ORM, using the Java Persistence API.<br> */<br></span> <span class="diffcontext">public class JPAUnitTestCase {<br><br> Logger LOG = Logger.getLogger(JPAUnitTestCase.class);<br><br> private EntityManagerFactory entityManagerFactory;<br> private EntityManager entityManager;<br><br> @Before<br> public void init() {<br> entityManagerFactory = Persistence.createEntityManagerFactory("templatePU");<br> entityManager = entityManagerFactory.createEntityManager();<br><br>// entityManager.setFlushMode(FlushModeType.COMMIT);<br> entityManager.setFlushMode(FlushModeType.AUTO);<br> }<br><br> @After<br> public void destroy() {<br> entityManager.close();<br> entityManagerFactory.close();<br> }<br><br><br> @Test<br> public void hhh123Test() throws Exception {<br><br> entityManager.getTransaction().begin();<br><br> TableB b = new TableB();<br> b.setName("name b");<br> b.setDescription("Bsome description");<br> entityManager.persist(b);<br><br> TableA a = new TableA();<br> a.setName("name a");<br> a.setDescription("some description");<br> entityManager.persist(a);<br><br> {<br> a.setDescription("some new description 1");<br> entityManager.merge(a);<br> TableA aFetch = entityManager.find(TableA.class, a.getId());<br> //version is not incremented, no flush<br> assertThat(aFetch.getVersion(), is(0L));<br> }<br><br> {<br> // flush is executed and version is incremented<br> Query query = entityManager.createQuery("select entity from table_a entity where id = :id").setParameter("id", a.getId());<br> TableA aFetch = (TableA) query.getSingleResult();<br> assertThat(aFetch.getVersion(), is(1L));<br> }<br><br> {<br> a.setDescription("some new description 2");<br> entityManager.merge(a);<br> TableA aFetch = entityManager.find(TableA.class, a.getId());<br> //version is not incremented, no flush<br> assertThat(aFetch.getVersion(), is(1L));<br> //do native query<br><br> List resultList = entityManager.createNativeQuery("select * from table_b", TableB.class).getResultList();<br> // flush is executed and version of TableA is incremented<br> TableB bFetch = (TableB) resultList.get(0);<br> assertThat(bFetch.getVersion(), is(0L));<br> aFetch = entityManager.find(TableA.class, a.getId());<br> assertThat(aFetch.getVersion(), is(2L));<br> }<br><br> LOG.info("Do commit");<br><br> entityManager.getTransaction().commit();<br><br><br> }<br><br> @Entity(name = "table_a")<br> public static class TableA {<br><br><br> @Version<br> @Column<br> private Long version;<br><br> @Id<br> @GeneratedValue<br> @Column(name = "oId", updatable = false, nullable = false)<br> private Long id;<br><br> @Column(nullable = true)<br> private String name;<br><br> @Column(nullable = true)<br> private String description;<br><br> public Long getVersion() {<br> return version;<br> }<br><br> public void setVersion(Long version) {<br> this.version = version;<br> }<br><br> public Long getId() {<br> return id;<br> }<br><br> public void setId(Long id) {<br> this.id = id;<br> }<br><br> public String getName() {<br> return name;<br> }<br><br> public void setName(String name) {<br> this.name = name;<br> }<br><br> public String getDescription() {<br> return description;<br> }<br><br> public void setDescription(String description) {<br> this.description = description;<br> }<br><br> @Override<br> public String toString() {<br> return String.format("TableA{version=%d, id=%d, name='%s', description='%s'}", version, id, name, description);<br> }<br> }<br><br> @Entity(name = "table_b")<br> public static class TableB {<br><br><br> @Version<br> @Column<br> private Long version;<br><br> @Id<br> @GeneratedValue<br> @Column(name = "oId", updatable = false, nullable = false)<br> private Long id;<br><br> @Column(nullable = true)<br> private String name;<br><br> @Column(nullable = true)<br> private String description;<br><br> public Long getVersion() {<br> return version;<br> }<br><br> public void setVersion(Long version) {<br> this.version = version;<br> }<br><br> public Long getId() {<br> return id;<br> }<br><br> public void setId(Long id) {<br> this.id = id;<br> }<br><br> public String getName() {<br> return name;<br> }<br><br> public void setName(String name) {<br> this.name = name;<br> }<br><br> public String getDescription() {<br> return description;<br> }<br><br> public void setDescription(String description) {<br> this.description = description;<br> }<br><br> @Override<br> public String toString() {<br> return String.format("TableB{version=%d, id=%d, name='%s', description='%s'}", version, id, name, description);<br> }<br> }<br>}<br>{code</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">:java</span> <span class="diffcontext">}</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br><br></span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HHH-13768?inbox=true&",
"name": "View Issue"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-13768#add-comment?atlOrigin=eyJpIjoiMDFhNDdlOTI4NjA0NGRjNmExNzEwZDk4ZDkxYWY0NDEiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-3a7b9755-9573-4e30-86ef-f24c5839b526" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-13768#add-comment?atlOrigin=eyJpIjoiMDFhNDdlOTI4NjA0NGRjNmExNzEwZDk4ZDkxYWY0NDEiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-mobile-separated-links" class="mobile-resize-text" width="100%" colspan="2" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> Get Jira notifications on your phone! Download the Jira Cloud app for <a href="https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail" style="color: #3b73af; text-decoration: none">Android</a> or <a href="https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8" style="color: #3b73af; text-decoration: none">iOS</a>
<hr> </td>
</tr>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v1001.0.0-SNAPSHOT#100115-<span title="452a40ba816a4d3cc50e8b462446c99285defd62" data-commit-id="452a40ba816a4d3cc50e8b462446c99285defd62}">sha1:452a40b</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px; opacity: 0.150"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-668d6aed-a82c-4bf3-87fb-82c9dde3ee63" alt="Atlassian logo" title="Atlassian logo" width="192" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
<img border="0" width="1" height="1" alt="" src="http://atlassian.et.e.sparkpost.com/q/FZ6vlZKobIWcP35aGOGxBQ~~/AAAAAQA~/RgRfz09GPlcLYXRsYXNzaWFudXNCCgAAxhvuXco3tN5SIGhpYmVybmF0ZS1pc3N1ZXNAbGlzdHMuamJvc3Mub3JnWAQAAAAE">
</body>
</html>