<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://avatar-management--avatars.us-west-2.prod.public.atl-paas.net/initials/JM-3.png?size=48&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="jan.matussek" style="color:#6c797f;; color: #3b73af; text-decoration: none" id="email_jan.matussek" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5e0d108bb783d60db09fd46a"> Jan Matussek </a> <strong>updated</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNGNmN2Q5M2I4Y2Y2NGEyZDhhNjM2ZTVjOTNiN2U5ZWYiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-13836?atlOrigin=eyJpIjoiNGNmN2Q5M2I4Y2Y2NGEyZDhhNjM2ZTVjOTNiN2U5ZWYiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-82ba7afb-b1fc-4a08-834c-cc7ece83466d" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HHH-13836?atlOrigin=eyJpIjoiNGNmN2Q5M2I4Y2Y2NGEyZDhhNjM2ZTVjOTNiN2U5ZWYiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">HHH-13836</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-13836?atlOrigin=eyJpIjoiNGNmN2Q5M2I4Y2Y2NGEyZDhhNjM2ZTVjOTNiN2U5ZWYiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">OneToOne Unidirectional relation does not work properly</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Change By:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="jan.matussek" style="color:#6c797f;; color: #3b73af; text-decoration: none" id="email_jan.matussek" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5e0d108bb783d60db09fd46a"> Jan Matussek </a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <span class="diffcontext">Hello,<br><br>we upgraded our maven dependencies and after the migration from hibernate orm 5.3.10 to 5.4.10 our unidirectional relation does not work any more. Here are the entities:<br><br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">{code:java}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">import org.hibernate.annotations.Type;<br><br>import javax.persistence.*;<br>import java.util.UUID;<br><br>@Entity<br>@Table(name = "Parent")<br>public class ParentEntity {<br> @Id<br> @Column(name = "id")<br> @GeneratedValue<br> @Type(type = "org.hibernate.type.UUIDCharType")<br> public UUID id;<br><br> @OneToOne(cascade = CascadeType.ALL, orphanRemoval = true)<br> @JoinColumn(name = "id")<br> public ChildEntity child;<br><br> public UUID getId() {<br> return id;<br> }<br><br> public void setId(UUID id) {<br> this.id = id;<br> }<br><br> public ChildEntity getChild() {<br> return child;<br> }<br><br> public void setChild(ChildEntity child) {<br> this.child = child;<br> }<br>}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">{code}<br><br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">{code:java}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">import org.hibernate.annotations.Type;<br><br>import javax.persistence.*;<br>import java.util.UUID;<br><br>@Entity<br>@Table(name = "Child")<br>public class ChildEntity {<br> @Id<br> @Column(name = "id")<br> @Type(type = "org.hibernate.type.UUIDCharType")<br> public UUID id;<br><br> public UUID getId() {<br> return id;<br> }<br><br> public void setId(UUID id) {<br> this.id = id;<br> }<br>}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">{code}<br><br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">As you can see we have only the relation from ParentEntity to ChildEntity with @OneToOne annotation.<br><br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">When I create the parent entity and the child entity everything is ok so far. When I delete the parent entity I expect that the child will be deleted first and the parent afterwards. In 5.3.10 I have this order but in 5.4.10 the order is the other way (the parent will be deleted first and the child afterwards).<br><br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">{code:java}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">public class App {<br><br> public static void main(String[] args) {<br> ParentEntity parent = new ParentEntity();<br><br> Transaction transaction = null;<br> try (Session session = HibernateUtil.getSessionFactory().openSession()) {<br> transaction = session.beginTransaction();<br> session.save(parent);<br> ChildEntity child = new ChildEntity();<br> child.setId(parent.getId());<br> session.save(child);<br><br> parent.setChild(child);<br> session.update(parent);<br><br> transaction.commit();<br> } catch (Exception e) {<br> e.printStackTrace();<br> if (transaction != null) {<br> transaction.rollback();<br> }<br> }<br><br> try (Session session = HibernateUtil.getSessionFactory().openSession()) {<br> transaction = session.beginTransaction();<br> session.delete(parent);<br> transaction.commit();<br> } catch (Exception e) {<br> e.printStackTrace();<br> if (transaction != null) {<br> transaction.rollback();<br> }<br> }<br> }<br>}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">{code}<br><br>The sql log in 5.3.10 is the following:<br><br> !image-2020-01-30-15-49-43-223.png|</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">thumbnail</span> <span class="diffaddedchars" style="background-color:#ddfade;">width=200,height=183</span> <span class="diffcontext">!</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br><br></span> <span class="diffcontext"> <br><br>The sql log in 5.4.10 is the following:<br><br> !image-2020-01-30-15-50-21-707.png|</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">thumbnail</span> <span class="diffaddedchars" style="background-color:#ddfade;">width=200,height=183</span> <span class="diffcontext">!</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br><br></span> <span class="diffcontext"> <br><br>As you can see the delete order has changed.<br><br>As far as I have seen it has something to do with the following ticket</span> <span class="diffaddedchars" style="background-color:#ddfade;"> [</span> <span class="diffcontext"> https://hibernate.atlassian.net/browse/HHH-12436</span> <span class="diffaddedchars" style="background-color:#ddfade;">|https://hibernate.atlassian.net/browse/HHH-12436]</span> <span class="diffcontext"> and the changes in the hibernate class org.hibernate.cfg.OneToOneSecondPass#doSecondPass.<br><br>There is the following code:<br><br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">{code:java}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">final ForeignKeyDirection foreignKeyDirection = !BinderHelper.isEmptyAnnotationValue( mappedBy )<br> ? ForeignKeyDirection.TO_PARENT<br> : ForeignKeyDirection.FROM_PARENT;<br> value.setForeignKeyType(foreignKeyDirection);</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">{code}<br><br>hibernate will set the foreignKeyDirection to FROM_PARENT in case mappedBy is not set (which is the case see above). <br><br>In hibernate 5.3.10 the following if statement returned true and in 5.4.10 this returns false:<br><br>{code:java}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">org.hibernate.engine.internal.Cascade#cascadeProperty <br>if ( cascadeAssociationNow( cascadePoint, associationType ) )</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> <br></span> <span class="diffcontext">{code}<br><br></span> <span class="diffaddedchars" style="background-color:#ddfade;">I assume the above if statement is not the bug but in this line the bug will have it’s impact.</span> <span class="diffcontext"><br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br><br><br></span> <span class="diffcontext">Here is a simple example: <br>[https://gitlab.com/jmatussek/hibernate-issue-unidirectional-onetoone|https://gitlab.com/jmatussek/hibernate-issue-unidirectional-onetoone]<br><br>To reproduce my issue just change the hibernate version in pom.xml.<br><br>To me it looks like a bug cause the behavior is different. In case I am wrong could you tell me how to create a unidirectional relation correctly?<br><br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br><br></span> <span class="diffcontext">Regards<br><br>Jan</span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HHH-13836?inbox=true&",
"name": "View Issue"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-13836#add-comment?atlOrigin=eyJpIjoiNGNmN2Q5M2I4Y2Y2NGEyZDhhNjM2ZTVjOTNiN2U5ZWYiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-b5836f38-7108-4139-a10d-2d51a06124ec" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-13836#add-comment?atlOrigin=eyJpIjoiNGNmN2Q5M2I4Y2Y2NGEyZDhhNjM2ZTVjOTNiN2U5ZWYiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-mobile-separated-links" class="mobile-resize-text" width="100%" colspan="2" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> Get Jira notifications on your phone! Download the Jira Cloud app for <a href="https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail" style="color: #3b73af; text-decoration: none">Android</a> or <a href="https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8" style="color: #3b73af; text-decoration: none">iOS</a>
<hr> </td>
</tr>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v1001.0.0-SNAPSHOT#100118-<span title="63bcc696318c73a2159c03214cf79bc5e066871b" data-commit-id="63bcc696318c73a2159c03214cf79bc5e066871b}">sha1:63bcc69</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px; opacity: 0.150"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-ee2a8172-5e8c-481a-97c3-bebf94ae68e1" alt="Atlassian logo" title="Atlassian logo" width="192" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
<img border="0" width="1" height="1" alt="" src="http://atlassian.et.e.sparkpost.com/q/9aN4Q_pWTFyjf0L80TV70A~~/AAAAAQA~/RgRgFCRDPlcLYXRsYXNzaWFudXNCCgAAw_AyXmMI0iNSIGhpYmVybmF0ZS1pc3N1ZXNAbGlzdHMuamJvc3Mub3JnWAQAAAAE">
</body>
</html>