<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/4fb54519294cbeb79043236cb28e9503?d=https%3A%2F%2Favatar-management--avatars.us-west-2.prod.public.atl-paas.net%2Finitials%2FJR-3.png&size=48&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="joy.reistad" style="color:#6c797f;; color: #3b73af; text-decoration: none" id="email_joy.reistad" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Aa0625ae6-266a-49f2-86e2-38b4407fdbd4"> Joy Reistad </a> <strong>updated</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiODkxY2IyMGUxMDZlNDBlZmJhODAzNTEzMzMxNGQ0NDIiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-13942?atlOrigin=eyJpIjoiODkxY2IyMGUxMDZlNDBlZmJhODAzNTEzMzMxNGQ0NDIiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-e91b7d95-2ac4-459c-80c9-2a237ee67695" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HHH-13942?atlOrigin=eyJpIjoiODkxY2IyMGUxMDZlNDBlZmJhODAzNTEzMzMxNGQ0NDIiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">HHH-13942</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-13942?atlOrigin=eyJpIjoiODkxY2IyMGUxMDZlNDBlZmJhODAzNTEzMzMxNGQ0NDIiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">>= 5.4.4.Final Causes Version issue with QueryDSL</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Change By:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="joy.reistad" style="color:#6c797f;; color: #3b73af; text-decoration: none" id="email_joy.reistad" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Aa0625ae6-266a-49f2-86e2-38b4407fdbd4"> Joy Reistad </a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <span class="diffcontext">My team uses hibernate-core and hibernate-c3p0. <br>we recently tried to upgrade from version 5.4.1.Final to latest (5.4.14.Final) however this caused our version field to stop updating.<br>Dug in and found this change starts happening on version 5.4.4.Final.<br><br>Hibernate usage:<br>We use hibernate with queryDSL and javax.persistence<br>We use javax.Persistence to create an entityManagerFactory with a set of hibernate properties <br><br>{code:java}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">ImmutableMap.Builder<String, String> properties = ImmutableMap.<String, String>builder()<br> .put("hibernate.connection.url", dbConnectionString)<br> .put("hibernate.connection.user", dbUser)<br> .put("hibernate.connection.password", dbPassword)<br> .put("hibernate.c3p0.min_size", minDbConnections)<br> .put("hibernate.c3p0.max_size", maxDbConnections)<br> .put("hibernate.c3p0.timeout", connectionTimeout)<br> .put("hibernate.c3p0.preferredTestQuery", "/* ping */ SELECT 1")<br> .put("hibernate.connection.Charset", "utf8")<br> .put("hibernate.connection.characterEncoding", "utf8")<br> .put("hibernate.connection.useUnicode", "true");<br><br>if (connectionTestOnCheckout) {<br> properties.put("hibernate.c3p0.testConnectionOnCheckout", "true");<br>} else {<br> if (connectionTestOnCheckin) {<br> properties.put("hibernate.c3p0.testConnectionOnCheckin", "true");<br> }<br> properties.put("hibernate.c3p0.idle_test_period", dbIdleCheckInterval);<br>}<br><br>entityManagerFactory = Persistence.createEntityManagerFactory(persistenceUnitName, properties.build());</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">{code}<br><br>We use the javax.persistence @Entity annotations to represent our object being stored int the db. And we have a version attribute with the @Version annotation<br><br>{code:java}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">import</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> java.util.UUID;<br><br>import</span> <span class="diffcontext"> javax.persistence.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">CascadeType;<br>import javax.persistence.</span> <span class="diffcontext">Column;<br>import javax.persistence.Convert;<br>import javax.persistence.Entity;<br>import javax.persistence.GeneratedValue;<br>import javax.persistence.Id;<br>import javax.persistence.Table;<br>import javax.persistence.Version;<br><br><br>@Entity<br>@Table(name = "obj", schema = "schema")<br>public class MyObject {<br><br> public MyObject() {<br> }<br><br> @Id<br> @Column(name = "id")<br> @GeneratedValue(strategy = GenerationType.IDENTITY)<br> private Long id;<br><br> @Version<br> @Column(name = "version")<br> private Long version;<br><br> public Long getId() {<br> return id;<br> }<br><br> public MyObject setId(Long id) {<br> this.id = id;<br> return this;<br> }<br><br> public Long getVersion() {<br> return version;<br> }<br><br> public MyObject setVersion(Long version) {<br> this.version = version;<br> return this;<br> }<br>}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">{code}<br><br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">*</span> <span class="diffcontext">We use the LockModeType.WRITE on some of our JPAQueries to force an update to the version object when needed. <br>however since the hibernate update, entityManager.clear() is clearing the version updates, so the version is not updated ever*<br><br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">{code:java}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">MyObj myObj = new MyObj().setVersion(1L);<br>EntityManager em = entityManagerFactory.createEntityManager();<br>em.getTransaction().begin();<br>em.persist(myObj);<br>em.getTransaction().commit();<br>em.close();<br>MyTransaction transaction = new MyTransaction(entityManagerFactory.createEntityManager());<br>transaction.incrementVersion(myObj.getId);<br>transaction.commit();</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">{code}<br><br>{code:java}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br>mport</span> <span class="diffaddedchars" style="background-color:#ddfade;">import</span> <span class="diffcontext"> javax.persistence.EntityManager;<br>import javax.persistence.FlushModeType;<br>import javax.persistence.LockModeType;<br>import javax.persistence.RollbackException;<br><br>import com.querydsl.jpa.impl.JPAQuery;<br>import com.querydsl.jpa.impl.JPAQueryFactory;<br><br>public class MyTransaction{<br><br> private final EntityManager entityManager;<br> private final JPAQueryFactory queryFactory;<br><br> public MyTransaction(EntityManager entityManager) {<br> this.entityManager = entityManager<br> this.queryFactory = new JPAQueryFactory(entityManager);<br> entityManager.setFlushMode(FlushModeType.COMMIT);<br> entityManager.getTransaction().begin();<br> }<br><br> public void commit() {<br> //Detaches all JPA managed entities, so that only our explicit updates are persisted. version should still be automatically updated via QueryDSL.<br> entityManager.clear(); <br> try {<br> entityManager.getTransaction().commit();<br> } catch (RollbackException e) {<br> throw e;<br> }<br> }<br><br> public void incrementVersion(Long id) {<br> //QMyObj is a Querydsl query type for MyObj<br> JPAQuery<MyObj> query = queryFactory.selectFrom(QMyObj.myObj)<br> .where(QMyObj.myObj.id.eq(id));<br> query.setLockMode(LockModeType.WRITE);<br> query.fetchOne();<br> }<br><br> public void close() {<br> try {<br> if (entityManager.isJoinedToTransaction()) {<br> entityManager.getTransaction().rollback();<br> }<br> } finally {<br> entityManager.close();<br> }<br> }</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">{code}<br><br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br><br><br><br></span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HHH-13942?inbox=true&",
"name": "View Issue"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-13942#add-comment?atlOrigin=eyJpIjoiODkxY2IyMGUxMDZlNDBlZmJhODAzNTEzMzMxNGQ0NDIiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-70bd9f05-1a0e-45f9-8538-11fd831f51e4" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-13942#add-comment?atlOrigin=eyJpIjoiODkxY2IyMGUxMDZlNDBlZmJhODAzNTEzMzMxNGQ0NDIiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-mobile-separated-links" class="mobile-resize-text" width="100%" colspan="2" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> Get Jira notifications on your phone! Download the Jira Cloud app for <a href="https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail" style="color: #3b73af; text-decoration: none">Android</a> or <a href="https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8" style="color: #3b73af; text-decoration: none">iOS</a>
<hr> </td>
</tr>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v1001.0.0-SNAPSHOT#100124-<span title="c13ca0d2346d3575a7eef03463f11fc590402f53" data-commit-id="c13ca0d2346d3575a7eef03463f11fc590402f53}">sha1:c13ca0d</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px; opacity: 0.150"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-c3f9b5b5-f624-4862-b180-700a02f947ac" alt="Atlassian logo" title="Atlassian logo" width="192" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>