<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5"> <!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/2a8bdd4ffd282b7185c74b52ab452617?d=https%3A%2F%2Favatar-management--avatars.us-west-2.prod.public.atl-paas.net%2Finitials%2FYR-6.png&size=48&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="yrodiere" style="color:#6c797f;; color: #3b73af; text-decoration: none" id="email_yrodiere" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A58fa1ced-171a-4c00-97e8-5d70d442cc4b"> Yoann Rodière </a> <strong>created</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr> <!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiMTA3YThkY2QzN2VjNDIwMGJjNGUxZTRiNGI5ZjhkZWIiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">Hibernate Search</a> / <a href="https://hibernate.atlassian.net/browse/HSEARCH-3903?atlOrigin=eyJpIjoiMTA3YThkY2QzN2VjNDIwMGJjNGUxZTRiNGI5ZjhkZWIiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-6fd8c1cb-4a88-4576-981c-7380c6f38d64" height="16" width="16" border="0" align="absmiddle" alt="New Feature" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HSEARCH-3903?atlOrigin=eyJpIjoiMTA3YThkY2QzN2VjNDIwMGJjNGUxZTRiNGI5ZjhkZWIiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">HSEARCH-3903</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HSEARCH-3903?atlOrigin=eyJpIjoiMTA3YThkY2QzN2VjNDIwMGJjNGUxZTRiNGI5ZjhkZWIiLCJwIjoiaiJ9" style="color: #3b73af; text-decoration: none">Filters based exclusively on mapper metadata for @IndexedEmbedded</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Issue Type:</th>
<td class="has-icon" style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <img src="cid:jira-generated-image-avatar-6fd8c1cb-4a88-4576-981c-7380c6f38d64" height="16" width="16" border="0" align="absmiddle" alt="New Feature" style="vertical-align: text-bottom"> New Feature </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Assignee:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> Unassigned </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Components:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> engine, mapper-pojo </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Created:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> 29/Apr/2020 01:18 AM </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Fix Versions:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> 6.0.0.Beta-backlog-low-priority </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Priority:</th>
<td class="has-icon" style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <img src="cid:jira-generated-image-static-major-0be7714f-b0b3-4c2a-9c26-e929ce26ea95" height="16" width="16" border="0" align="absmiddle" alt="Major" style="vertical-align: text-bottom"> Major </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Reporter:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="yrodiere" style="color:#6c797f;; color: #3b73af; text-decoration: none" id="email_yrodiere" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A58fa1ced-171a-4c00-97e8-5d70d442cc4b"> Yoann Rodière </a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0; margin-top: 0">The <tt>includePaths</tt> filter in <tt>@IndexedEmbedded</tt> refers to index field paths. This has several drawbacks:</p>
<ul>
<li>Part of the implementation has to be in the backend, which feels quite dirty.</li>
<li>This is not very consistent with the <tt>maxDepth</tt> filter, which applied to the <tt>@IndexedEmbedded</tt> only (depth of fields created within an included bridge is unlimited).</li>
<li>The filters cannot easily be applied to dynamic fields, so dynamic fields are always included as soon as their nearest static parent is included.</li>
<li>The filter can end up including some fields declared by a custom field bridge, but not others.
<ul>
<li>This does not make sense performance-wise as the fields will still be populated by the bridge, but ignored by the backend.</li>
<li>Worse, when we introduce support for bridge-defined predicates ( <span class="jira-issue-macro" data-jira-key="HSEARCH-3320"> <a href="https://hibernate.atlassian.net/browse/HSEARCH-3320" class="jira-issue-macro-key issue-link" title="Predicates on bridge-registered object fields" style="color: #3b73af; text-decoration: none"> <img class="icon" src="https://hibernate.atlassian.net/secure/viewavatar?size=medium&avatarId=12151&avatarType=issuetype"> HSEARCH-3320 </a> <span class="aui-lozenge aui-lozenge-subtle aui-lozenge-complete jira-macro-single-issue-export-pdf" style="background: #cccccc; border: 1px solid #cccccc; border-radius: 3px; color: #333333; display: inline-block; font-size: 11px; font-weight: bold; line-height: 99%; margin: 0; padding: 2px 5px; text-align: center; text-decoration: none; text-transform: uppercase; background-color: #ffffff; border-color: #cccccc; color: #333333" bgcolor="#ffffff">Reopened</span> </span> ), we may end up with dysfunctional predicates because only some fields are present, while the bridge expects all fields to be present.</li>
</ul> </li>
<li>We are forced to use inference to detect which bridges should be included or excluded, based on the fields they declared.
<ul>
<li>This code is unnecessarily complex.</li>
<li>This code does not work correctly with field templates, since we cannot know in advance whether dynamic fields will be included. In particular:
<ul>
<li>Bridges that declare field templates, but only ever add dynamic fields that would not match the <tt>includePaths</tt>, are included nonetheless.</li>
<li>Bridges that do not declare anything and rely on field templates declared by a parent (which is legal) are excluded.</li>
</ul> </li>
</ul> </li>
</ul> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">We could get rid of most of the complexity by implementing filters differently, based on mapper metadata exclusively (mapping annotations and/or entity model).</p> <h4 style="margin: 10px 0 0; font-size: 14px; line-height: 1.500; margin: 20px 0 0"><a name="Solution1%3Apropertypaths" style="color: #3b73af; text-decoration: none"></a>Solution 1: property paths</h4> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">We could rely on property paths instead of field paths. Only bridges applied to included properties are themselves included.</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">The major drawback is that there wouldn't be any way to filter out type bridges.</p> <h4 style="margin: 10px 0 0; font-size: 14px; line-height: 1.500; margin: 20px 0 0"><a name="Solution2%3Agroups" style="color: #3b73af; text-decoration: none"></a>Solution 2: groups</h4> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">We could rely on "groups", similarly to the <tt>@LazyGroup</tt> support in Hibernate ORM, or to the group support in Hibernate Validator.</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">One assigns groups to every <tt>@Field</tt>/<tt>@IndexedEmbedded</tt>, then references the groups in <tt>@IncludedEmbedded(includeGroups = ...)</tt>.</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">The main problem with this solution is its complexity; Validator is using groups and I know they can be pretty complex to handle. We should definitely see what makes them so complex in Validator to avoid the same problems in Search.</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">For example:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
@Indexed
<span class="code-keyword" style="color: #000091">public</span> <span class="code-keyword" style="color: #000091">class </span>Level1Entity {
<span class="code-comment" style="color: #808080">// Will include id only
</span> @IndexedEmbedded
<span class="code-keyword" style="color: #000091">private</span> Level2Entity level2_1;
<span class="code-comment" style="color: #808080">// Will include id, name
</span> @IndexedEmbedded(includeGroups = {BuiltinGroups.DEFAULT, <span class="code-quote" style="color: #009100">"base"</span>})
<span class="code-keyword" style="color: #000091">private</span> Level2Entity level2_2;
<span class="code-comment" style="color: #808080">// Will include id, name, category
</span> @IndexedEmbedded(includeGroups = {BuiltinGroups.DEFAULT, <span class="code-quote" style="color: #009100">"base"</span>, <span class="code-quote" style="color: #009100">"advanced"</span>})
<span class="code-keyword" style="color: #000091">private</span> Level2Entity level2_3;
}
<span class="code-keyword" style="color: #000091">public</span> <span class="code-keyword" style="color: #000091">class </span>Level2Entity {
@GenericField <span class="code-comment" style="color: #808080">// Default group
</span> <span class="code-keyword" style="color: #000091">private</span> <span class="code-object" style="color: #910091">String</span> id;
@GenericField(groups = <span class="code-quote" style="color: #009100">"base"</span>)
<span class="code-keyword" style="color: #000091">private</span> <span class="code-object" style="color: #910091">String</span> name;
@GenericField(groups = <span class="code-quote" style="color: #009100">"advanced"</span>)
<span class="code-keyword" style="color: #000091">private</span> <span class="code-object" style="color: #910091">String</span> category;
}
</pre>
</div>
</div> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">It would prevent us from supporting the use case mentioned in <span class="jira-issue-macro" data-jira-key="HSEARCH-1112"> <a href="https://hibernate.atlassian.net/browse/HSEARCH-1112" class="jira-issue-macro-key issue-link" title="@IndexedEmbedded.includePaths should allow to pick paths that were excluded from the embedded entity" style="color: #3b73af; text-decoration: none"> <img class="icon" src="https://hibernate.atlassian.net/secure/viewavatar?size=medium&avatarId=12150&avatarType=issuetype"> HSEARCH-1112 </a> <span class="aui-lozenge aui-lozenge-subtle aui-lozenge-complete jira-macro-single-issue-export-pdf" style="background: #cccccc; border: 1px solid #cccccc; border-radius: 3px; color: #333333; display: inline-block; font-size: 11px; font-weight: bold; line-height: 99%; margin: 0; padding: 2px 5px; text-align: center; text-decoration: none; text-transform: uppercase; background-color: #ffffff; border-color: #cccccc; color: #333333" bgcolor="#ffffff">Open</span> </span> directly, but I believe the same effect could be achieved if we defined group filters as "overriding" instead of "composable": an <tt>@IndexedEmbedded(includeGroups = "a")</tt> that includes an <tt>@IndexedEmbedded(includeGroups = "b")</tt> would just act as if the contained <tt>@IndexedEmbedded</tt> included group "a", and only group "a".</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">For example:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
@Indexed
<span class="code-keyword" style="color: #000091">public</span> <span class="code-keyword" style="color: #000091">class </span>Level1Entity {
<span class="code-comment" style="color: #808080">// Will include level2.level3.a only
</span> @IndexedEmbedded(includeGroups = <span class="code-quote" style="color: #009100">"a"</span>)
<span class="code-keyword" style="color: #000091">private</span> Level2Entity level2;
}
<span class="code-keyword" style="color: #000091">public</span> <span class="code-keyword" style="color: #000091">class </span>Level2Entity {
@GenericField(groups = <span class="code-quote" style="color: #009100">"b"</span>)
<span class="code-keyword" style="color: #000091">private</span> <span class="code-object" style="color: #910091">String</span> name;
@IndexedEmbedded(includeGroups = <span class="code-quote" style="color: #009100">"b"</span>) <span class="code-comment" style="color: #808080">// includeGroups is overridden in Level1Entity
</span> <span class="code-keyword" style="color: #000091">private</span> <span class="code-object" style="color: #910091">String</span> id;
}
<span class="code-keyword" style="color: #000091">public</span> <span class="code-keyword" style="color: #000091">class </span>Level3Entity {
@GenericField(group = <span class="code-quote" style="color: #009100">"a"</span>)
<span class="code-keyword" style="color: #000091">private</span> <span class="code-object" style="color: #910091">String</span> a;
@GenericField(group = <span class="code-quote" style="color: #009100">"b"</span>)
<span class="code-keyword" style="color: #000091">private</span> <span class="code-object" style="color: #910091">String</span> b;
}
</pre>
</div>
</div> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">There are pros and cons:</p>
<ul>
<li>Pro: Groups would be much easier to implement and understand: the various filters defined in indexed-embedded entities would no longer be relevant.</li>
<li>Con: it would become harder to manage cycles through group filtering: you would no longer be able to rely on indexed-embedded entities to filter out cycles through groups (since their group filters are ignored).</li>
<li>Con: the behavior would not be consistent with that of <tt>maxDepth</tt>.</li>
</ul> <h4 style="margin: 10px 0 0; font-size: 14px; line-height: 1.500; margin: 20px 0 0"><a name="Next" style="color: #3b73af; text-decoration: none"></a>Next</h4> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">As a second step, we should probably deprecate <tt>includePaths</tt> and mark it for removal in a later major version (7+).</p> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HSEARCH-3903?inbox=true&",
"name": "View Issue"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HSEARCH-3903#add-comment?atlOrigin=eyJpIjoiMTA3YThkY2QzN2VjNDIwMGJjNGUxZTRiNGI5ZjhkZWIiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-7d12f51a-c71a-44bc-882e-c2788e5b1bb7" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HSEARCH-3903#add-comment?atlOrigin=eyJpIjoiMTA3YThkY2QzN2VjNDIwMGJjNGUxZTRiNGI5ZjhkZWIiLCJwIjoiaiJ9" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr> <!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-mobile-separated-links" class="mobile-resize-text" width="100%" colspan="2" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> Get Jira notifications on your phone! Download the Jira Cloud app for <a href="https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail" style="color: #3b73af; text-decoration: none">Android</a> or <a href="https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8" style="color: #3b73af; text-decoration: none">iOS</a>
<hr> </td>
</tr>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v1001.0.0-SNAPSHOT#100125-<span title="e06514a2667e545f88de4091f71bc969ebfd2dbc" data-commit-id="e06514a2667e545f88de4091f71bc969ebfd2dbc}">sha1:e06514a</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px; opacity: 0.150"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-2dccca96-fbd9-447d-bb75-3cefce08f024" alt="Atlassian logo" title="Atlassian logo" width="192" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>