[hornetq-commits] JBoss hornetq SVN: r8681 - in trunk/src/main/org/hornetq/core: server/impl and 1 other directory.

[do-not-reply at jboss.org]

Author: timfox
Date: 2009-12-11 12:53:34 -0500 (Fri, 11 Dec 2009)
New Revision: 8681

Modified:
   trunk/src/main/org/hornetq/core/remoting/impl/wireformat/SessionSendMessage.java
   trunk/src/main/org/hornetq/core/server/impl/ServerMessageImpl.java
Log:
removed unnecessary copy

Modified: trunk/src/main/org/hornetq/core/remoting/impl/wireformat/SessionSendMessage.java
===================================================================
--- trunk/src/main/org/hornetq/core/remoting/impl/wireformat/SessionSendMessage.java	2009-12-11 17:20:56 UTC (rev 8680)
+++ trunk/src/main/org/hornetq/core/remoting/impl/wireformat/SessionSendMessage.java	2009-12-11 17:53:34 UTC (rev 8681)
@@ -45,13 +45,6 @@
       super(PacketImpl.SESS_SEND, message);
 
       this.requiresResponse = requiresResponse;
-
-      // If the message hasn't already been copied when the headers/properties/body was changed since last send
-      // (which will prompt an invalidate(), which will cause a copy if not copied already)
-      // Then the message needs to be copied before sending - the previous send may be in the Netty write queue
-      // so we can't just use the same buffer. Also we can't just duplicate, since the extra data (requiresResponse)
-      // may be different on different calls
-      message.checkCopy();
    }
 
    public SessionSendMessage()

Modified: trunk/src/main/org/hornetq/core/server/impl/ServerMessageImpl.java
===================================================================
--- trunk/src/main/org/hornetq/core/server/impl/ServerMessageImpl.java	2009-12-11 17:20:56 UTC (rev 8680)
+++ trunk/src/main/org/hornetq/core/server/impl/ServerMessageImpl.java	2009-12-11 17:53:34 UTC (rev 8681)
@@ -51,7 +51,7 @@
 
    static
    {
-      // This is an estimate of how much memory a ServerMessageImpl takes up, exclusing body and properties
+      // This is an estimate of how much memory a ServerMessageImpl takes up, excluding body and properties
       // Note, it is only an estimate, it's not possible to be entirely sure with Java
       // This figure is calculated using the test utilities in org.hornetq.tests.unit.util.sizeof
       // The value is somewhat higher on 64 bit architectures, probably due to different alignment