[hornetq-commits] JBoss hornetq SVN: r8708 - in trunk: src/main/org/hornetq/core/config/impl and 2 other directories.

[do-not-reply at jboss.org]

Author: jmesnil
Date: 2010-01-04 11:56:10 -0500 (Mon, 04 Jan 2010)
New Revision: 8708

Modified:
   trunk/src/main/org/hornetq/core/config/Configuration.java
   trunk/src/main/org/hornetq/core/config/impl/ConfigurationImpl.java
   trunk/src/main/org/hornetq/core/management/HornetQServerControl.java
   trunk/tests/src/org/hornetq/tests/unit/core/config/impl/ConfigurationImplTest.java
Log:
HORNETQ-185: API review

* added missing Configuration.setMessageCounterSamplePeriod() method

Modified: trunk/src/main/org/hornetq/core/config/Configuration.java
===================================================================
--- trunk/src/main/org/hornetq/core/config/Configuration.java	2010-01-04 16:43:07 UTC (rev 8707)
+++ trunk/src/main/org/hornetq/core/config/Configuration.java	2010-01-04 16:56:10 UTC (rev 8708)
@@ -420,6 +420,13 @@
    long getMessageCounterSamplePeriod();
 
    /**
+    * Sets the sample period to take message counter snapshot.
+    * 
+    * @param newPeriod value must be greater than 1000ms
+    */
+   void setMessageCounterSamplePeriod(long period);
+
+   /**
     * Returns the maximum number of days kept in memory for message counter.
     */
    int getMessageCounterMaxDayHistory();

Modified: trunk/src/main/org/hornetq/core/config/impl/ConfigurationImpl.java
===================================================================
--- trunk/src/main/org/hornetq/core/config/impl/ConfigurationImpl.java	2010-01-04 16:43:07 UTC (rev 8707)
+++ trunk/src/main/org/hornetq/core/config/impl/ConfigurationImpl.java	2010-01-04 16:56:10 UTC (rev 8708)
@@ -804,6 +804,11 @@
    {
       return messageCounterSamplePeriod;
    }
+   
+   public void setMessageCounterSamplePeriod(long period)
+   {
+      this.messageCounterSamplePeriod = period;
+   }
 
    public int getMessageCounterMaxDayHistory()
    {

Modified: trunk/src/main/org/hornetq/core/management/HornetQServerControl.java
===================================================================
--- trunk/src/main/org/hornetq/core/management/HornetQServerControl.java	2010-01-04 16:43:07 UTC (rev 8707)
+++ trunk/src/main/org/hornetq/core/management/HornetQServerControl.java	2010-01-04 16:56:10 UTC (rev 8708)
@@ -182,9 +182,7 @@
    long getMessageCounterSamplePeriod();
 
    /**
-    * Sets the sample period to take message counter snapshot.
-    * 
-    * @param newPeriod value must be greater than 1000ms
+    * @see Configuration#setMessageCounterSamplePeriod(long)
     */
    void setMessageCounterSamplePeriod(long newPeriod) throws Exception;
 

Modified: trunk/tests/src/org/hornetq/tests/unit/core/config/impl/ConfigurationImplTest.java
===================================================================
--- trunk/tests/src/org/hornetq/tests/unit/core/config/impl/ConfigurationImplTest.java	2010-01-04 16:43:07 UTC (rev 8707)
+++ trunk/tests/src/org/hornetq/tests/unit/core/config/impl/ConfigurationImplTest.java	2010-01-04 16:56:10 UTC (rev 8708)
@@ -297,6 +297,10 @@
          conf.setMessageCounterEnabled(b);
          Assert.assertEquals(b, conf.isMessageCounterEnabled());
 
+         l = RandomUtil.randomPositiveLong();
+         conf.setMessageCounterSamplePeriod(l);
+         Assert.assertEquals(l, conf.getMessageCounterSamplePeriod());
+
          i = RandomUtil.randomInt();
          conf.setMessageCounterMaxDayHistory(i);
          Assert.assertEquals(i, conf.getMessageCounterMaxDayHistory());
@@ -514,6 +518,10 @@
       conf.setMessageCounterEnabled(b);
       Assert.assertEquals(b, conf.isMessageCounterEnabled());
 
+      l = RandomUtil.randomPositiveLong();
+      conf.setMessageCounterSamplePeriod(l);
+      Assert.assertEquals(l, conf.getMessageCounterSamplePeriod());
+
       i = RandomUtil.randomInt();
       conf.setMessageCounterMaxDayHistory(i);
       Assert.assertEquals(i, conf.getMessageCounterMaxDayHistory());