[infinispan-commits] Infinispan SVN: r204 - in trunk/core/src/main/java/org/infinispan/marshall/jboss: externalizers and 1 other directory.

[infinispan-commits at lists.jboss.org]

Author: galder.zamarreno at jboss.com
Date: 2009-04-30 14:46:02 -0400 (Thu, 30 Apr 2009)
New Revision: 204

Modified:
   trunk/core/src/main/java/org/infinispan/marshall/jboss/CustomObjectTable.java
   trunk/core/src/main/java/org/infinispan/marshall/jboss/externalizers/RequestIgnoredResponseExternalizer.java
Log:
No need for an externalizer for a singleton instance. Easier and more performant to just add it to the ObjectTable.

Modified: trunk/core/src/main/java/org/infinispan/marshall/jboss/CustomObjectTable.java
===================================================================
--- trunk/core/src/main/java/org/infinispan/marshall/jboss/CustomObjectTable.java	2009-04-30 18:45:13 UTC (rev 203)
+++ trunk/core/src/main/java/org/infinispan/marshall/jboss/CustomObjectTable.java	2009-04-30 18:46:02 UTC (rev 204)
@@ -23,6 +23,7 @@
 
 import net.jcip.annotations.Immutable;
 import org.infinispan.remoting.responses.RequestIgnoredResponse;
+import org.infinispan.remoting.responses.UnsuccessfulResponse;
 import org.jboss.marshalling.Marshaller;
 import org.jboss.marshalling.ObjectTable;
 import org.jboss.marshalling.Unmarshaller;
@@ -48,6 +49,8 @@
    public void init() {
       objects.add(RequestIgnoredResponse.INSTANCE);
       writers.put(RequestIgnoredResponse.INSTANCE, new CustomObjectWriter(index++));
+      objects.add(UnsuccessfulResponse.INSTANCE);
+      writers.put(UnsuccessfulResponse.INSTANCE, new CustomObjectWriter(index++));
    }
 
    public void stop() {

Modified: trunk/core/src/main/java/org/infinispan/marshall/jboss/externalizers/RequestIgnoredResponseExternalizer.java
===================================================================
--- trunk/core/src/main/java/org/infinispan/marshall/jboss/externalizers/RequestIgnoredResponseExternalizer.java	2009-04-30 18:45:13 UTC (rev 203)
+++ trunk/core/src/main/java/org/infinispan/marshall/jboss/externalizers/RequestIgnoredResponseExternalizer.java	2009-04-30 18:46:02 UTC (rev 204)
@@ -13,7 +13,11 @@
  *
  * @author Manik Surtani
  * @since 4.0
+ * @deprecated Not needed RequestIgnoredResponseExternalizer, it's more 
+ * performant adding singleton instance to ObjectTable, see 
+ * RequestIgnoredResponse example in CustomObjectTable
  */
+ at Deprecated
 public class RequestIgnoredResponseExternalizer implements Externalizer {
    public void writeExternal(Object o, ObjectOutput objectOutput) throws IOException {
    }