[infinispan-commits] Infinispan SVN: r258 - trunk/core/src/main/java/org/infinispan/container/entries.

[infinispan-commits at lists.jboss.org]

Author: manik.surtani at jboss.com
Date: 2009-05-12 09:12:10 -0400 (Tue, 12 May 2009)
New Revision: 258

Modified:
   trunk/core/src/main/java/org/infinispan/container/entries/ReadCommittedEntry.java
Log:
docs & comments

Modified: trunk/core/src/main/java/org/infinispan/container/entries/ReadCommittedEntry.java
===================================================================
--- trunk/core/src/main/java/org/infinispan/container/entries/ReadCommittedEntry.java	2009-05-12 13:11:00 UTC (rev 257)
+++ trunk/core/src/main/java/org/infinispan/container/entries/ReadCommittedEntry.java	2009-05-12 13:12:10 UTC (rev 258)
@@ -53,8 +53,15 @@
       this.lifespan = lifespan;
    }
 
+   // if this or any MVCC entry implementation ever needs to store a boolean, always use a flag instead.  This is far
+   // more space-efficient.  Note that this value will be stored in a byte, which means up to 8 flags can be stored in
+   // a single byte.  Always start shifting with 0, the last shift cannot be greater than 7.
    protected static enum Flags {
-      CHANGED(1), CREATED(1 << 1), REMOVED(1 << 2), VALID(1 << 3);
+      CHANGED(1), // same as 1 << 0
+      CREATED(1 << 1),
+      REMOVED(1 << 2),
+      VALID(1 << 3);
+
       final byte mask;
 
       Flags(int mask) {