[infinispan-commits] Infinispan SVN: r760 - trunk/core/src/main/java/org/infinispan/container.

[infinispan-commits at lists.jboss.org]

Author: mircea.markus
Date: 2009-09-03 05:07:52 -0400 (Thu, 03 Sep 2009)
New Revision: 760

Modified:
   trunk/core/src/main/java/org/infinispan/container/SimpleDataContainer.java
Log:
findbugs
Should be a static inner class
This class is an inner class, but does not use its embedded reference to the object which created it.?\194?\160 This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary.?\194?\160 If possible, the class should be made static

Modified: trunk/core/src/main/java/org/infinispan/container/SimpleDataContainer.java
===================================================================
--- trunk/core/src/main/java/org/infinispan/container/SimpleDataContainer.java	2009-09-03 09:06:57 UTC (rev 759)
+++ trunk/core/src/main/java/org/infinispan/container/SimpleDataContainer.java	2009-09-03 09:07:52 UTC (rev 760)
@@ -183,7 +183,7 @@
       }
    }
 
-   private class KeyIterator implements Iterator<Object> {
+   private static class KeyIterator implements Iterator<Object> {
       Iterator<Iterator<Object>> metaIterator;
       Iterator<Object> currentIterator;