[infinispan-commits] Infinispan SVN: r765 - trunk/core/src/main/java/org/infinispan/container.

[infinispan-commits at lists.jboss.org]

Author: mircea.markus
Date: 2009-09-03 05:20:21 -0400 (Thu, 03 Sep 2009)
New Revision: 765

Modified:
   trunk/core/src/main/java/org/infinispan/container/FIFODataContainer.java
Log:
findbugs:
  
Dead store to local variable
This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction. Often, this indicates an error, because the value computed is never used.
Note that Sun's javac compiler often generates dead stores for final local variables. Because FindBugs is a bytecode-based tool, there is no easy way to eliminate these false positives.

Modified: trunk/core/src/main/java/org/infinispan/container/FIFODataContainer.java
===================================================================
--- trunk/core/src/main/java/org/infinispan/container/FIFODataContainer.java	2009-09-03 09:18:02 UTC (rev 764)
+++ trunk/core/src/main/java/org/infinispan/container/FIFODataContainer.java	2009-09-03 09:20:21 UTC (rev 765)
@@ -259,7 +259,7 @@
          LinkedEntry l1 = tail.p;
          if (isMarkedForRemoval(l1) || entry.n != tail) break;
          if (tail.casPrev(l1, entry)) {
-            if (isMarkedForRemoval(entry.p)) entry = correctPrev(entry, tail);
+            if (isMarkedForRemoval(entry.p)) correctPrev(entry, tail);
             break;
          }
          backoffTime = backoff(backoffTime);