[infinispan-commits] Infinispan SVN: r799 - trunk/core/src/main/java/org/infinispan/config.

[infinispan-commits at lists.jboss.org]

Author: mircea.markus
Date: 2009-09-09 06:41:41 -0400 (Wed, 09 Sep 2009)
New Revision: 799

Modified:
   trunk/core/src/main/java/org/infinispan/config/AbstractNamedCacheConfigurationBean.java
Log:
finbugs
Exception is caught when Exception is not thrown in org.infinispan.config.AbstractNamedCacheConfigurationBean.inject(ComponentRegistry)

Modified: trunk/core/src/main/java/org/infinispan/config/AbstractNamedCacheConfigurationBean.java
===================================================================
--- trunk/core/src/main/java/org/infinispan/config/AbstractNamedCacheConfigurationBean.java	2009-09-09 10:29:18 UTC (rev 798)
+++ trunk/core/src/main/java/org/infinispan/config/AbstractNamedCacheConfigurationBean.java	2009-09-09 10:41:41 UTC (rev 799)
@@ -1,18 +1,19 @@
 package org.infinispan.config;
 
-import java.lang.reflect.Field;
-import java.lang.reflect.ParameterizedType;
-import java.lang.reflect.Type;
-import java.util.Collection;
-import java.util.List;
-
 import org.infinispan.factories.ComponentRegistry;
 import org.infinispan.factories.annotations.Inject;
 import org.infinispan.factories.scopes.Scope;
 import org.infinispan.factories.scopes.Scopes;
 import org.infinispan.lifecycle.ComponentStatus;
 import org.infinispan.util.ReflectionUtil;
+import org.infinispan.CacheException;
 
+import java.lang.reflect.Field;
+import java.lang.reflect.ParameterizedType;
+import java.lang.reflect.Type;
+import java.util.Collection;
+import java.util.List;
+
 /**
  * Adds named cache specific features to the {@link org.infinispan.config.AbstractConfigurationBean}.
  *
@@ -40,8 +41,10 @@
                   fieldValueThis.inject(cr);
                }
             } catch (Exception e) {
-               log.warn("Could not inject for field " + field + " in class " +fieldValueThis,e);
-            }         
+               String s = "Could not inject for field " + field + " in class " + fieldValueThis;
+               log.error(s, e);
+               throw new CacheException(s, e);
+            }
       }
       
       //and don't forget to recurse into collections of components...
@@ -66,7 +69,9 @@
                         }
                      }
                   } catch (Exception e) {
-                     log.warn("Could not inject for field " + field + " in class " +field,e);
+                     String errorMsg = "Could not inject for field " + field + " in class " + field;
+                     log.error(errorMsg,e);
+                     throw new CacheException(errorMsg, e);
                   }
                }
             }