[infinispan-commits] Infinispan SVN: r854 - trunk/cachestore/jdbm/src/main/java/org/infinispan/loaders/jdbm.

[infinispan-commits at lists.jboss.org]

Author: galder.zamarreno at jboss.com
Date: 2009-09-25 09:41:38 -0400 (Fri, 25 Sep 2009)
New Revision: 854

Modified:
   trunk/cachestore/jdbm/src/main/java/org/infinispan/loaders/jdbm/JdbmCacheStore.java
Log:
Calls to InternalCacheEntry.getExpiryTime() and InternalCacheEntry.getMaxIdle() are indeed required, so removed TODOs.

Modified: trunk/cachestore/jdbm/src/main/java/org/infinispan/loaders/jdbm/JdbmCacheStore.java
===================================================================
--- trunk/cachestore/jdbm/src/main/java/org/infinispan/loaders/jdbm/JdbmCacheStore.java	2009-09-24 14:13:37 UTC (rev 853)
+++ trunk/cachestore/jdbm/src/main/java/org/infinispan/loaders/jdbm/JdbmCacheStore.java	2009-09-25 13:41:38 UTC (rev 854)
@@ -269,7 +269,8 @@
    private void addNewExpiry(InternalCacheEntry entry) throws IOException {
       long expiry = entry.getExpiryTime();
       if (entry.getMaxIdle() > 0) {
-         // TODO do we need both?
+         // Coding getExpiryTime() for transient entries has the risk of being a moving target
+         // which could lead to unexpected results, hence, InternalCacheEntry calls are required
          expiry = entry.getMaxIdle() + System.currentTimeMillis();
       }
       Long at = new Long(expiry);