[infinispan-commits] Infinispan SVN: r892 - trunk/cachestore/bdbje/src/main/java/org/infinispan/loaders/bdbje.

[infinispan-commits at lists.jboss.org]

Author: galder.zamarreno at jboss.com
Date: 2009-09-30 03:44:57 -0400 (Wed, 30 Sep 2009)
New Revision: 892

Modified:
   trunk/cachestore/bdbje/src/main/java/org/infinispan/loaders/bdbje/BdbjeCacheStore.java
Log:
Calls to InternalCacheEntry.getExpiryTime() and InternalCacheEntry.getMaxIdle() are indeed required, so removed TODO.

Modified: trunk/cachestore/bdbje/src/main/java/org/infinispan/loaders/bdbje/BdbjeCacheStore.java
===================================================================
--- trunk/cachestore/bdbje/src/main/java/org/infinispan/loaders/bdbje/BdbjeCacheStore.java	2009-09-29 16:12:12 UTC (rev 891)
+++ trunk/cachestore/bdbje/src/main/java/org/infinispan/loaders/bdbje/BdbjeCacheStore.java	2009-09-30 07:44:57 UTC (rev 892)
@@ -392,7 +392,8 @@
     private void addNewExpiry(InternalCacheEntry entry) throws IOException {
         long expiry = entry.getExpiryTime();
         if (entry.getMaxIdle() > 0) {
-            // TODO do we need both?
+           // Coding getExpiryTime() for transient entries has the risk of being a moving target
+           // which could lead to unexpected results, hence, InternalCacheEntry calls are required
             expiry = entry.getMaxIdle() + System.currentTimeMillis();
         }
         Long at = new Long(expiry);