[infinispan-commits] Infinispan SVN: r1625 - in trunk/server: hotrod/src/main/scala/org/infinispan/server/hotrod and 1 other directories.

[infinispan-commits at lists.jboss.org]

Author: galder.zamarreno at jboss.com
Date: 2010-03-26 08:00:00 -0400 (Fri, 26 Mar 2010)
New Revision: 1625

Modified:
   trunk/server/core/src/main/scala/org/infinispan/server/core/CacheValue.scala
   trunk/server/hotrod/src/main/scala/org/infinispan/server/hotrod/HotRodEncoder.scala
   trunk/server/hotrod/src/test/scala/org/infinispan/server/hotrod/test/Utils.scala
Log:
Added some TODOs.

Modified: trunk/server/core/src/main/scala/org/infinispan/server/core/CacheValue.scala
===================================================================
--- trunk/server/core/src/main/scala/org/infinispan/server/core/CacheValue.scala	2010-03-26 08:17:03 UTC (rev 1624)
+++ trunk/server/core/src/main/scala/org/infinispan/server/core/CacheValue.scala	2010-03-26 12:00:00 UTC (rev 1625)
@@ -9,6 +9,7 @@
  * @since
  */
 // TODO: Make it a hardcoded Externalizer
+// TODO: maybe convert to scala case class -> whenever u create java beans, maybe create case classes
 class CacheValue(val data: Array[Byte], val version: Long) extends Serializable {
 
    override def toString = {

Modified: trunk/server/hotrod/src/main/scala/org/infinispan/server/hotrod/HotRodEncoder.scala
===================================================================
--- trunk/server/hotrod/src/main/scala/org/infinispan/server/hotrod/HotRodEncoder.scala	2010-03-26 08:17:03 UTC (rev 1624)
+++ trunk/server/hotrod/src/main/scala/org/infinispan/server/hotrod/HotRodEncoder.scala	2010-03-26 12:00:00 UTC (rev 1625)
@@ -17,6 +17,7 @@
    override def encode(ctx: ChannelHandlerContext, channel: Channel, msg: AnyRef): AnyRef = {
       trace("Encode msg {0}", msg)
       val buffer: ChannelBuffer = msg match {
+         // TODO: move stats response down
          case s: StatsResponse => {
             val buffer = dynamicBuffer
             writeHeader(buffer, s)
@@ -48,7 +49,7 @@
       buffer.writeUnsignedLong(r.messageId)
       buffer.writeByte(r.operation.id.byteValue)
       buffer.writeByte(r.status.id.byteValue)
-      buffer.writeByte(0) // topology change marker
+      buffer.writeByte(0) // TODO: topology change marker, implemented later
       buffer
    }
    

Modified: trunk/server/hotrod/src/test/scala/org/infinispan/server/hotrod/test/Utils.scala
===================================================================
--- trunk/server/hotrod/src/test/scala/org/infinispan/server/hotrod/test/Utils.scala	2010-03-26 08:17:03 UTC (rev 1624)
+++ trunk/server/hotrod/src/test/scala/org/infinispan/server/hotrod/test/Utils.scala	2010-03-26 12:00:00 UTC (rev 1625)
@@ -12,6 +12,7 @@
  * @since 4.1
  */
 
+// TODO: convert to object so that mircea can use it
 trait Utils {
 
    import Utils._