[infinispan-commits] Infinispan SVN: r2347 - branches/4.2.x/cachestore/jdbc/src/main/java/org/infinispan/loaders/jdbc/stringbased.

[infinispan-commits at lists.jboss.org]

Author: sannegrinovero
Date: 2010-09-12 16:58:05 -0400 (Sun, 12 Sep 2010)
New Revision: 2347

Modified:
   branches/4.2.x/cachestore/jdbc/src/main/java/org/infinispan/loaders/jdbc/stringbased/JdbcStringBasedCacheStore.java
Log:
[ISPN-641] (More information logged on storage failure of JdbcStringBasedCacheStore)

Modified: branches/4.2.x/cachestore/jdbc/src/main/java/org/infinispan/loaders/jdbc/stringbased/JdbcStringBasedCacheStore.java
===================================================================
--- branches/4.2.x/cachestore/jdbc/src/main/java/org/infinispan/loaders/jdbc/stringbased/JdbcStringBasedCacheStore.java	2010-09-07 18:08:12 UTC (rev 2346)
+++ branches/4.2.x/cachestore/jdbc/src/main/java/org/infinispan/loaders/jdbc/stringbased/JdbcStringBasedCacheStore.java	2010-09-12 20:58:05 UTC (rev 2347)
@@ -195,16 +195,16 @@
          log.trace("Running sql '" + sql + "' on " + ed + ". Key string is '" + lockingKey + "'");
       Connection connection = null;
       PreparedStatement ps = null;
+      ByteBuffer byteBuffer = JdbcUtil.marshall(getMarshaller(), ed.toInternalCacheValue());
       try {
          connection = connectionFactory.getConnection();
          ps = connection.prepareStatement(sql);
-         ByteBuffer byteBuffer = JdbcUtil.marshall(getMarshaller(), ed.toInternalCacheValue());
          ps.setBinaryStream(1, byteBuffer.getStream(), byteBuffer.getLength());
          ps.setLong(2, ed.getExpiryTime());
          ps.setString(3, lockingKey);
          ps.executeUpdate();
       } catch (SQLException ex) {
-         logAndThrow(ex, "Error while storing string keys to database");
+         logAndThrow(ex, "Error while storing string key to database; key: '"+lockingKey+"', buffer size of value: " + byteBuffer.getLength() + " bytes");
       } finally {
          JdbcUtil.safeClose(ps);
          connectionFactory.releaseConnection(connection);