[infinispan-dev] BucketBasedCacheStore#loadBucket does not set the bucketName

[Adrian Cole]

+1 for making bucket name final, set in constructor.

On Thu, Apr 9, 2009 at 6:45 PM, Manik Surtani <manik at jboss.org> wrote:
> Is there any reason for a Bucket's name *not* to be final, and as such, set
> in its constructor?
>
> On 9 Apr 2009, at 17:40, Adrian Cole wrote:
>
>> When in BucketBasedCacheStore.removeLockSafe, the following is called:
>>
>> Bucket bucket = loadBucket(keyHashCodeStr);
>>
>> now, the bucket returned does not always have its name set (at least
>> in the BaseCacheStoreTest:402)
>>
>> I would suggest to either enforce bucket's immutable name field, or
>> ensure it is set on all options.  Otherwise, all cachestore
>> implementations have to check this individually.
>>
>> WDYT?
>>
>> -Adrian
>>
>> _______________________________________________
>> infinispan-dev mailing list
>> infinispan-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
> --
> Manik Surtani
> manik at jboss.org
> Lead, Infinispan
> Lead, JBoss Cache
> http://www.infinispan.org
> http://www.jbosscache.org
>
>
>
>
>