[infinispan-dev] Re: Marshalling

[Galder Zamarreno]

Manik Surtani wrote:
> 
> On 27 Apr 2009, at 08:47, Galder Zamarreno wrote:
> 
>>
>>
>> Galder Zamarreno wrote:
>>> Galder Zamarreno wrote:
>>>>
>>>>
>>>> Manik Surtani wrote:
>>>>> Also, Galder, some things have been missed when using the "tree" 
>>>>> module with JBoss Marshalling.
>>>>>
>>>>> Running "mvn install -Ptest-jbossmarshaller" in the src root causes 
>>>>> these failures:
>>>>>
>>>>> Failed tests:
>>>>>  setUp(org.infinispan.api.tree.NodeAPITest)
>>>>>  setUp(org.infinispan.api.tree.TreeCacheAPITest)
>>>>>  createBeforeClass(org.infinispan.api.tree.NodeMoveAPITest)
>>>>>  testPutMap(org.infinispan.api.tree.SyncReplTest)
>>>>>  testReplTxRollback(org.infinispan.api.tree.NodeReplicatedMoveTest)
>>>>>  testBasicOperation(org.infinispan.api.tree.SyncReplTxTest)
>>>>>  testBasicOperation(org.infinispan.api.tree.SyncReplTest)
>>>>>  testReplicatability(org.infinispan.api.tree.NodeReplicatedMoveTest)
>>>>>  testSyncRepl(org.infinispan.api.tree.SyncReplTest)
>>>>>  testReplTxCommit(org.infinispan.api.tree.NodeReplicatedMoveTest)
>>>>
>>>> Hmmm, forgot to verify the tree module. I'll review those failures 
>>>> asap.
>>> I've been debugging this failures and some of them look to be due to 
>>> a bug in in JBMAR. David is working on it and hopes to get it fixed 
>>> today. I'll let you know when they're fixed.
>>
>> David found a fix for it and verified that it fixed the remaining 
>> failures in tree/ and it causes no regressions in core/.
> 
> What was the bug?

I believe it was a combo of https://jira.jboss.org/jira/browse/JBMAR-49 
and https://jira.jboss.org/jira/browse/JBMAR-50.

FQN was Externalizable and NodeKey is Serializable, so the combo of them 
two was not working correctly. NodeKey should at least be made 
Externalizable anyway, shouldn't it?

> 
>> I'll update trunk to new JBMAR version asap.
> 
> Great - thanks dude!
> 
> Cheers
> Manik
> 
> -- 
> Manik Surtani
> manik at jboss.org
> Lead, Infinispan
> Lead, JBoss Cache
> http://www.infinispan.org
> http://www.jbosscache.org
> 
> 
> 
> 

-- 
Galder Zamarreño
Sr. Software Maintenance Engineer
JBoss, a division of Red Hat