[infinispan-dev] Test harness: MultipleCacheManagersTest

[Manik Surtani]

On 4 Aug 2009, at 13:07, Mircea Markus wrote:

> Manik Surtani wrote:
>> Nope:
>>
>>  private void callCreateCacheManagers() {
>>      try {
>>         createCacheManagers();
>>      } catch (Throwable th) {
>>         th.printStackTrace();
>>         log.error("Error in test setup: " + th);
>>      }
>>   }
>>
>> So if there is no reason for this I'll change it to re-throw the  
>> exception.
>>
>> Cheers
>> Manik
> I was saying that the code is wrong and the exception *should* be re- 
> thrown, not that it *is* re-thrown.
> Is this a sort of public humiliation? :)

LOL!  Not at all.  I thought you meant it *is* re-thrown.

Patched and checked in.  :)


>>
>> On 4 Aug 2009, at 12:14, Mircea Markus wrote:
>>
>>> Manik Surtani wrote:
>>>> Mircea,
>>>>
>>>> Is there any good reason why exceptions thrown in   
>>>> createCacheManagers() get swallowed (well, logged) but does not  
>>>> cause  the tests being run to fail?
>>>>
>>>>
>>> No, the exception should be re-thrown so that the test will fail.
>>>> Cheers
>>>> -- 
>>>> Manik Surtani
>>>> manik at jboss.org
>>>> Lead, Infinispan
>>>> Lead, JBoss Cache
>>>> http://www.infinispan.org
>>>> http://www.jbosscache.org
>>>>
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> infinispan-dev mailing list
>>>> infinispan-dev at lists.jboss.org
>>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>>>>
>>>
>>
>> -- 
>> Manik Surtani
>> manik at jboss.org
>> Lead, Infinispan
>> Lead, JBoss Cache
>> http://www.infinispan.org
>> http://www.jbosscache.org
>>
>>
>>
>>
>

--
Manik Surtani
manik at jboss.org
Lead, Infinispan
Lead, JBoss Cache
http://www.infinispan.org
http://www.jbosscache.org