[infinispan-dev] Module configuration proposal

[Manik Surtani]

A couple of comments re 193:

How would you set this stuff programmatically? Conf.setQueryConfig(qc) ?

Also, are the <module> tags and the <query: > prefix necessary in the  
XML config? Any clever way to do without these, since the queryconfig  
bean is detected at the beginning and doesn't have to be loaded when  
specific tags are encountered, right?

Cheers
Manik

Sent from my iPhone

On 5 Nov 2009, at 22:51, Vladimir Blagojevic <vblagoje at redhat.com>  
wrote:

> Yes, I did! Check out QueryParsingTest in query module.
> I have also finished 245, not committed yet.
> Will overview code again tonight, but I think 245 is good to go as  
> well.
>
> Cheers
>
> On 09-11-05 5:35 PM, Manik Surtani wrote:
>> Wow that was quick, dude! :) I haven't had a chance to have a look
>> yet, have you set up a config bean for the query module as an example
>> of this?
>>
>> Sent from my iPhone
>>
>> On 5 Nov 2009, at 16:29, Vladimir Blagojevic<vblagoje at redhat.com>
>> wrote:
>>
>>
>>> Ok, 193 is in. Give it a quick look and I'll see now what needs to  
>>> be
>>> done for 245.
>>>
>>> On 09-11-04 2:56 PM, Manik Surtani wrote:
>>>
>>>> TBH ISPN-193 and ISPN-245 need not be joined at the hip. We could  
>>>> go
>>>> with 193 now since you already have it, and then 245 after GA. Or,
>>>> time permitting, I could implement 245 at some point next week  
>>>> maybe
>>>> and that could be rolled into the GA too, let's see, but it  
>>>> shouldn't
>>>> be a blocker for GA.
>>>>
>>>> Sent from my iPhone
>>>>
>>>> On 4 Nov 2009, at 19:43, Vladimir Blagojevic<vblagoje at redhat.com>
>>>> wrote:
>>>>
>>>>
>>>>
>>>>> On 09-11-04 1:51 PM, Manik Surtani wrote:
>>>>>
>>>>>
>>>>>> It's not that I anticipate changes, it's more a case of  
>>>>>> introducing
>>>>>> major changes in a late-stage CR.  :)  Then again, we've already
>>>>>> done
>>>>>> that with ISPN-251, etc...
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>> My gut feeling is that we go forward and implement this feature, I
>>>>> think
>>>>> it is worth it. As soon as 4.0 is out everybody out there can  
>>>>> write
>>>>> their extension modules, experiment with extending Infinispan  
>>>>> and so
>>>>> on.
>>>>> We use query module as our test bunny and a guidance to others how
>>>>> to
>>>>> extend Infinispan! For a little GA delay we get a big payoff. I
>>>>> doubt
>>>>> that we are going to introduce some major instability. I've  
>>>>> already
>>>>> implemented module configuration loading, just have to convert  
>>>>> it to
>>>>> look for this property file. The change is not major, and ISPN-245
>>>>> does
>>>>> not look too hard. Maybe you can take ISPN-245? You could do it  
>>>>> in a
>>>>> day
>>>>> or so since you are familiar with that code inside out....
>>>>>
>>>>> What does everyone else think?
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> infinispan-dev mailing list
>>>>> infinispan-dev at lists.jboss.org
>>>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>>>>>
>>>>>
>>>> _______________________________________________
>>>> infinispan-dev mailing list
>>>> infinispan-dev at lists.jboss.org
>>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>>>>
>>>>
>>> _______________________________________________
>>> infinispan-dev mailing list
>>> infinispan-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>>>
>> _______________________________________________
>> infinispan-dev mailing list
>> infinispan-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>>
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev