[infinispan-dev] RpcManagerImpl stats confusion

[Manik Surtani]

On 24 Nov 2009, at 13:52, Galder Zamarreno wrote:

> So, to make sure it's clear, we're do not wanna be tracking state 
> transfe time but only replication time, so totalReplicationTime needs to 
> be updated on invokeRemotely() and update the rest as you indicated. 
> Correct?

Yep.

> I should have this and https://jira.jboss.org/jira/browse/ISPN-289 done 
> today.

Great!

> 
> On 11/24/2009 01:30 PM, Manik Surtani wrote:
>> Seems like duplication.  Drop numReplications, getAverageReplicationTime() can be calculated using replicationCount().
>> 
>> Well spotted!
>> 
>> On 24 Nov 2009, at 12:19, Galder Zamarreno wrote:
>> 
>>> Hi Manik et al,
>>> 
>>> What's the difference between RpcManagerImpl.replicationCount and
>>> RpcManagerImpl.numReplications?
>>> 
>>> numReplications is only updated when retrieveState() is called. Maybe
>>> you wanted to call it, numberStateTransfersRequested?
>>> 
>>> Similar thing happens for totalReplicationTime, it's only updated in
>>> retrieveState(), so maybe you wanted to call it, totalStateTransferTime?
>>> 
>>> Both numReplications and totalReplicationTime produce
>>> getAverageReplicationTime() which as it is currently, it's rather
>>> confusing. It should say: getAverageStateTransferTime().
>>> 
>>> We probably wanna add to this a totalReplicationTime though that is
>>> updated in invokeRemotely(), in the same way that replicationCount is
>>> updated. That way we could certainly provider a reliable
>>> getAverageReplicationTime()
>>> 
>>> Thoughts?
>>> --
>>> Galder Zamarreño
>>> Sr. Software Engineer
>>> Infinispan, JBoss Cache
>>> _______________________________________________
>>> infinispan-dev mailing list
>>> infinispan-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>> 
>> --
>> Manik Surtani
>> manik at jboss.org
>> Lead, Infinispan
>> Lead, JBoss Cache
>> http://www.infinispan.org
>> http://www.jbosscache.org
>> 
>> 
>> 
>> 
>> 
>> _______________________________________________
>> infinispan-dev mailing list
>> infinispan-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
> 
> -- 
> Galder Zamarreño
> Sr. Software Engineer
> Infinispan, JBoss Cache
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev

--
Manik Surtani
manik at jboss.org
Lead, Infinispan
Lead, JBoss Cache
http://www.infinispan.org
http://www.jbosscache.org