[infinispan-dev] Change AbstractInfinispanTest.nullifyInstanceFields method name to zzzNullifyInstanceFields

[Mircea Markus]

On Oct 19, 2009, at 7:22 PM, Manik Surtani wrote:

> Please be careful about this - I'm sure the dependsOnMethods field was
> set for a reason.  Mircea, care to comment?
>
All fine by me as long as the tests run. Test NG is not very well  
'documented' for our use case, so there are several workarounds in use  
cases, like this one.

> On 19 Oct 2009, at 16:27, Vladimir Blagojevic wrote:
>
>> On 09-10-19 10:17 AM, Galder Zamarreno wrote:
>>>
>>> On 10/19/2009 03:46 PM, Vladimir Blagojevic wrote:
>>>
>>>> You gotta be kidding! Are you sure that your method is annotated
>>>> with
>>>> @AfterClass and not @AfterTest. Is this in svn? I'd like to try it
>>>> myself!
>>>>
>>> I'm not kidding and I'm sure :)
>>>
>>> I've just committed it, r969. Do an svn updated, revert to the
>>> AbstractInfinispanTest.nullifyInstanceFields and run
>>> org.infinispan.jndi.BindingTest and you'll see an NPE being thrown  
>>> in
>>> the preDestroy() method.
>>>
>>>
>> destroyAfterClass in SingleCacheManagerTest with its dependsOnMethods
>> annotation field is throwing the order off. If you remove
>> dependsOnMethods field and remove preDestroy method in
>> SingleCacheManagerTest everything works as expected. Try it yourself.
>>
>> These dependsOnMethods annotation fields complicate things for no
>> reason. If we do not use them the order of invocation of @AfterClass
>> methods is always from the leaf all the way up to ancestor.
>>
>> _______________________________________________
>> infinispan-dev mailing list
>> infinispan-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
> --
> Manik Surtani
> manik at jboss.org
> Lead, Infinispan
> Lead, JBoss Cache
> http://www.infinispan.org
> http://www.jbosscache.org
>
>
>
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/infinispan-dev/attachments/20091019/568b474d/attachment-0002.html