[infinispan-dev] [ISPN-165] Adding visitPutForExternalReadCommand to Visitor interface?

[Galder Zamarreno]

On 08/27/2009 01:08 PM, Manik Surtani wrote:
>
> On 26 Aug 2009, at 18:09, Mircea Markus wrote:
>
>>
>> On Aug 20, 2009, at 12:09 PM, Galder Zamarreno wrote:
>>
>>>
>>>
>>> On 08/20/2009 11:05 AM, Galder Zamarreno wrote:
>>>> Hi,
>>>>
>>>> Re: https://jira.jboss.org/jira/browse/ISPN-165
>>>>
>>>> In JBC, this was fixed by having a overriding
>>>> visitPutForExternalReadCommand in InvalidationInterceptor and
>>>> avoiding
>>>> going remote in its implementation.
>>>>
>>>> In ISPN however, there does not appear to be a similar
>>>> visitPutForExternalReadCommand method, which forces you to check the
>>>> flags passed (Flag.FAIL_SILENTLY, Flag.FORCE_ASYNCHRONOUS,
>>>> Flag.ZERO_LOCK_ACQUISITION_TIMEOUT)
>>>>
>>>> Now, not all calls to with these flags are related to
>>>> putForExternalRead, so I'd suggest adding a
>>>> visitPutForExternalReadCommand to the Visitor interface.
>>>
>>> Adding this would require a PutForExternalReadCommand. I don't see any
>>> problems with this although I'm curious to understand why these
>>> command
>>> and it's corresponding visitor* where not ported from JBC, in case
>>> there's a particular reason for it.
>> Another approach would be to add a flag on the command itself
>> PutKeyValueCommand. This won't even need to be serialized, so no
>> performance disadvantage.
>
> I believe this is the approach used in the end, after an IRC chat
> between Galder and myself. :)

Indeed, in the end a flag was simply used. Thanks for the feedback 
Mircea/Manik :)

>
> --
> Manik Surtani
> manik at jboss.org
> Lead, Infinispan
> Lead, JBoss Cache
> http://www.infinispan.org
> http://www.jbosscache.org
>
>
>
>

-- 
Galder Zamarreño
Sr. Software Engineer
Infinispan, JBoss Cache