[infinispan-dev] big patch about imports and typos

Sanne Grinovero sanne.grinovero at gmail.com
Mon Aug 23 09:33:55 EDT 2010


2010/8/23 Manik Surtani <manik at jboss.org>:
>
> On 23 Aug 2010, at 10:37, Sanne Grinovero wrote:
>
>> Hello,
>> I've been browsing through the sources of all core and some other
>> modules, and while reading I couldn't stop my compulsion for fixing
>> some typos in javadoc and code comments, and removing the unused
>> import statements.
>>
>> In some cases the imports are also binding to Sun's JRE, for example:
>> import com.sun.corba.se.impl.orb.ORBConfiguratorImpl;
>>
>> So this patch got quite large and all-around, would this be a good
>> timing to apply it, or should I isolate and apply only the
>> non-standard imports fix?
>
> You should be ok to apply now, before 4.1.0.Final.
>
>> Also this makes me think we should setup a CI server to compile
>> Infinispan on a non-sun JVM, as these import statements are introduced
>> by intelliJ AFAIK.
>
> Yeah I'll do this on hudson.infinispan.org.  Which classes had com.sun imports?

This time just one:
org.infinispan.client.hotrod.impl.async.DefaultAsyncExecutorFactory
I was talking plural as I remember fixing a similar issue some months
ago, so I think it's an Idea issue with it's auto-imports, while
Eclipse complains loudly about it (compile error).

>
> Cheers
> Manik
>
> --
> Manik Surtani
> manik at jboss.org
> Lead, Infinispan
> Lead, JBoss Cache
> http://www.infinispan.org
> http://www.jbosscache.org
>
>
>
>
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>



More information about the infinispan-dev mailing list