[infinispan-dev] CacheLoaderManagerImpl.preload() put calls

[Manik Surtani]

Preloads should definitely NOT be remote.  Thanks for spotting this, fixed in trunk:

	http://fisheye.jboss.org/changelog/Infinispan/trunk?cs=1415

Cheers
Manik


On 26 Jan 2010, at 16:42, Galder Zamarreno wrote:

> Hi,
> 
> Re: http://community.jboss.org/message/521810#521810
> 
> I'm looking at this and thinking, do we want preloading put calls to go 
> remote? Shouldn't put calls in CacheLoaderManagerImpl.preload() be 
> putForExternalRead() or similar?
> 
> I know that this happens during cache startup and that hence the cache 
> shouldn't be dealing with requests as it's not yet started, so there 
> shouldn't be lock timeouts on the local machine at least.
> 
> However, not sure about going remote with this call.
> 
> Something that's odd here as well is this:
> 
> 2010-01-22 12:53:13,596 TRACE {main} [o.i.r.t.j.JGroupsTransport:12] 
> dests=null, command=SingleRpcCommand{cacheName='isd-source', 
> command=PutKeyValueCommand{key=cle03, value=value03, putIfAbsent=false, 
> lifespanMillis=-1, maxIdleTimeMillis=-1}}, mode=ASYNCHRONOUS, timeout=15000
> 2010-01-22 12:54:13,605 ERROR {main} [o.i.r.r.RpcManagerImpl:111] 
> unexpected error while replicating 
> java.util.concurrent.TimeoutException: Timed out waiting for a 
> cluster-wide sync to be released. (timeout = 60 seconds)
>      at 
> org.infinispan.remoting.transport.jgroups.JGroupsDistSync.blockUntilReleased(JGroupsDistSync.java:51) 
> [infinispan-core-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
>      at 
> org.infinispan.remoting.transport.jgroups.JGroupsTransport.invokeRemotely(JGroupsTransport.java:397) 
> [infinispan-core-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
> 
> The call is clearly syncrhonous but the mode printed says ASYNCHRONOUS? 
> I'll see if I can create a test for the ASYNCHRONOUS bit.
> 
> Cheers,
> -- 
> Galder Zamarreño
> Sr. Software Engineer
> Infinispan, JBoss Cache
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev

--
Manik Surtani
manik at jboss.org
Lead, Infinispan
Lead, JBoss Cache
http://www.infinispan.org
http://www.jbosscache.org