[infinispan-dev] ISPN-699 - proper cancellation of cache store operations

[Galder Zamarreño]

On Oct 21, 2010, at 10:41 AM, Manik Surtani wrote:

> 
> On 21 Oct 2010, at 09:28, Galder Zamarreño wrote:
> 
>> This is what I'm trying to solve right now, a way for the FCS to get our of purging internal properly if interrupted.
> 
> 
> May be more than just the FCS.  Need to check whether all of the cache stores handle being interrupted properly.  Not just during a purge, but during any read/write operation.  I suspect this may be your problem.  A further problem - wrt purging - may be that the FCS supports async purging, where the purge operation is handed off to an executor.  If this is enabled, then this task would have to be cancelled as well.  See:
> 
> http://fisheye.jboss.org/browse/Infinispan/branches/4.2.x/core/src/main/java/org/infinispan/loaders/AbstractCacheStore.java?r=2324#l81

Yeah, that's the thing. Fixing this issue involves touching quite a bit of code and as you said, not only the FCS.

Yeah, and the problem of async purging gets even more complicated because you can have FCS configured with multiThreadedPurge. So here, you'll have a bunch of threads trying to purge. 

I'll also add the appropriate code to make sure that writing can be interrupted.

> 
> --
> Manik Surtani
> manik at jboss.org
> Lead, Infinispan
> Lead, JBoss Cache
> http://www.infinispan.org
> http://www.jbosscache.org
> 
> 
> 
> 
> 
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev

--
Galder Zamarreño
Sr. Software Engineer
Infinispan, JBoss Cache