[infinispan-dev] [ISPN-78] Feedback needed

[Olaf Bergner]

Am 15.04.11 16:56, schrieb Manik Surtani:
> On 11 Apr 2011, at 13:13, Galder Zamarreño wrote:
>
>> - Rather than modifying PutKeyValueCommand, it might be better to subclass it and add the large object logic there? i.e. PutLargeKeyValueCommand - I'd also suggest adding a new build* method in the command factory...etc. This keeps the code more fine grained.
> I don't understand why you need a specialised PutKVCommand?  How is behaviour different?
In its present shape PutKVCommand will *always* attempt to read the 
given key's value before proceeding to store the new value. I doubt that 
we need this for large objects. To determine if we are to perform a 
create or an update it suffices to consult the metadata cache. We won't 
be returning the former value anyway.

Cheers,
Olaf
> --
> Manik Surtani
> manik at jboss.org
> twitter.com/maniksurtani
>
> Lead, Infinispan
> http://www.infinispan.org
>
>
>
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>