[infinispan-dev] Adaptive marshaller buffer sizes - ISPN-1102

[Bela Ban]

Just copy the damn buffer and give it to me $@$#^%$#^%^$

Simple. Performant. Reliable.

:-)


On 6/14/11 5:42 PM, Sanne Grinovero wrote:
> 2011/6/14 Galder Zamarreño<galder at redhat.com>:
>>
>> On Jun 14, 2011, at 1:24 PM, Manik Surtani wrote:
>>
>>>
>>> On 14 Jun 2011, at 12:15, Bela Ban wrote:
>>>
>>>> +1.
>>>>
>>>>
>>>> There is also something else I wanted to bring to your attention. When
>>>> you pass reference byte[] BUF to JGroups, JGroups will store BUF in the
>>>> org.jgroups.Message MSG.
>>>>
>>>> MSG is subsequently stored in the retransmission table of NAKACK.
>>>>
>>>> If you now modify the contents of BUF, you will modify a subsequent
>>>> potential retransmission of MSG as well !
>>>>
>>>> I don't think this is done currently (Infinispan uses a new buffer every
>>>> time), but just make sure buffer reuse doesn't get rolled into a new
>>>> design...
>>>
>>> Good point.
>>
>> Uuups, that'd be rather nasty. So, once we pass it to you we can forget about it altogether.
>
> Right, so unless JGroups can notify us when it's not needing the
> buffer anymore we can forget any kind of pooling for reuse.
>
> Sanne
>
>>
>>>
>>> --
>>> Manik Surtani
>>> manik at jboss.org
>>> twitter.com/maniksurtani
>>>
>>> Lead, Infinispan
>>> http://www.infinispan.org
>>>
>>>
>>>
>>> _______________________________________________
>>> infinispan-dev mailing list
>>> infinispan-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>>
>> --
>> Galder Zamarreño
>> Sr. Software Engineer
>> Infinispan, JBoss Cache
>>
>>
>> _______________________________________________
>> infinispan-dev mailing list
>> infinispan-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>>
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev

-- 
Bela Ban
Lead JGroups / Clustering Team
JBoss