[infinispan-dev] API stability policy for major vs minor vs patch releases

[Paul Ferraro]

I see - thanks for the clarification.
So, to getLocality() is essentially an atomic composite of isLocal(...)
and isRehashInProgress(), correct?

On Tue, 2011-03-01 at 11:16 +0000, Manik Surtani wrote:
> Done
> 
> 
> https://github.com/infinispan/infinispan/commit/0f06d3667bec0b514c6a00a3464094a6edecd704
> 
> 
> 
> On 1 Mar 2011, at 10:35, Manik Surtani wrote:
> 
> > Well, the whole problem is that isLocal() is incorrect and returns
> > inaccurate results.  Unfortunately the fix does involve an API
> > change - but I agree that the API should be backward compatible.
> >  I'll make sure the method is restored and marked as deprecated, but
> > please use getLocality() instead.  :-)
> > 
> > 
> > http://docs.jboss.org/infinispan/4.2/apidocs/org/infinispan/distribution/DistributionManager.html#getLocality(java.lang.Object)
> > 
> > 
> >  
> > On 24 Feb 2011, at 16:30, Pete Muir wrote:
> > 
> > > AIUI the issue is not that the method was removed (it was
> > > refactored to dm.getLocality().isLocal()) but just that an API
> > > change in the micro series is not allowed.
> > > 
> > > On 23 Feb 2011, at 18:19, Erik Salter wrote:
> > > 
> > > > +1.5B
> > > > 
> > > > This method is a core component of my local
> > > > transaction/redirection implementation.  Hopefully, this was an
> > > > oversight and not intended to be removed.
> > > > 
> > > > Erik
> > > > 
> > > > -----Original Message-----
> > > > From: infinispan-dev-bounces at lists.jboss.org
> > > > [mailto:infinispan-dev-bounces at lists.jboss.org] On Behalf Of
> > > > Paul Ferraro
> > > > Sent: Wednesday, February 23, 2011 12:01 PM
> > > > To: infinispan-dev at lists.jboss.org
> > > > Subject: [infinispan-dev] API stability policy for major vs
> > > > minor vs patch releases
> > > > 
> > > > In my course of upgrading AS6 from 4.2.0.Final to 4.2.1.CR3, I
> > > > came across a NoSuchMethodError.  Specifically, a couple AS
> > > > components utilize DistributionManager.isLocal(String), which
> > > > was dropped from the public API sometime after 4.2.1.CR1.
> > > > 
> > > > While the fix is trivial enough (in the end I'll need to perform
> > > > several component release to compensate), this raises the larger
> > > > issue of a API stability policy for major vs minor vs patch
> > > > releases.  At the very least, I don't think its wise to remove
> > > > methods from a public interface in a patch release.  In my
> > > > opinion, removing methods from a public API should only happen
> > > > across major releases, and even then, only after being formally
> > > > deprecated.
> > > > 
> > > > Thoughts?
> > > > 
> > > > Paul
> > > > 
> > > > _______________________________________________
> > > > infinispan-dev mailing list
> > > > infinispan-dev at lists.jboss.org
> > > > https://lists.jboss.org/mailman/listinfo/infinispan-dev
> > > > 
> > > > The information contained in this message is legally privileged
> > > > and confidential, and is intended for the individual or entity
> > > > to whom it is addressed (or their designee). If this message is
> > > > read by anyone other than the intended recipient, please be
> > > > advised that distribution of this message, in any form, is
> > > > strictly prohibited. If you have received this message in error,
> > > > please notify the sender immediately and delete or destroy all
> > > > copies of this message.
> > > > 
> > > > _______________________________________________
> > > > infinispan-dev mailing list
> > > > infinispan-dev at lists.jboss.org
> > > > https://lists.jboss.org/mailman/listinfo/infinispan-dev
> > > 
> > > 
> > > _______________________________________________
> > > infinispan-dev mailing list
> > > infinispan-dev at lists.jboss.org
> > > https://lists.jboss.org/mailman/listinfo/infinispan-dev
> > > 
> > 
> > --
> > Manik Surtani
> > manik at jboss.org
> > twitter.com/maniksurtani
> > 
> > 
> > Lead, Infinispan
> > http://www.infinispan.org
> > 
> > 
> > 
> > 
> > 
> > 
> > _______________________________________________
> > infinispan-dev mailing list
> > infinispan-dev at lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/infinispan-dev
> 
> --
> Manik Surtani
> manik at jboss.org
> twitter.com/maniksurtani
> 
> 
> Lead, Infinispan
> http://www.infinispan.org
> 
> 
> 
> 
> 
> 
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev