[infinispan-dev] Cleanup of new configuration API

[Galder Zamarreño]

On Jan 19, 2012, at 4:37 PM, Pete Muir wrote:

> 
> On 19 Jan 2012, at 16:35, Galder Zamarreño wrote:
> 
>> 
>> On Jan 19, 2012, at 4:24 PM, Pete Muir wrote:
>> 
>>> 
>>> On 19 Jan 2012, at 16:14, Galder Zamarreño wrote:
>>> 
>>>> Hi all,
>>>> 
>>>> Re: https://issues.jboss.org/browse/ISPN-1745
>>>> 
>>>> The following deprecated methods belonging to the new configuration are going away for final and the methods that should be used instead:
>>>> 
>>>> - SerializationConfigurationBuilder.marshallerClass() -> SerializationConfigurationBuilder.marshaller()
>>>> - ClusteringConfigurationBuilder.stateRetrieval() -> ClusteringConfigurationBuilder.stateTransfer()
>>>> - Configuration.onePhaseCommit() -> ClusteringConfigurationBuilder.cacheMode().isSynchronous()
>>>> - StateRetrievalConfiguration -> StateTransferConfiguration
>>>> - StateRetrievalConfigurationBuilder -> StateTransferConfigurationBuilder
>>>> - TransactionConfigurationBuilder.cacheStopTimeout(int) -> TransactionConfigurationBuilder.cacheStopTimeout(long)
>>>> 
>>>> Other stuff I've spotted:
>>>> - TransactionConfiguration should not contain setters, those are already in TransactionConfigurationBuilder
>>> 
>>> Yes it should. These properties are runtime mutable (what was previously @Dynamic). Anything that is runtime mutable/dynamic is adjusted at runtime through a mutator on the configuration ofect.
>> 
>> Ah, didn't see anything mentioning this. Are you done with all javadoc'ing of the new config?
> 
> Yes, e.g. https://github.com/infinispan/infinispan/blob/master/core/src/main/java/org/infinispan/configuration/cache/TransactionConfigurationBuilder.java#L121

We need to test this: https://issues.jboss.org/browse/ISPN-1762

> 
>> 
>>> 
>>>> - TransactionConfiguration.transactionalCache() has been removed
>>>> - Configuration.stateTransferEnabled was removed (what the heck was it doing there?)
>>> 
>>> As it refers to two configuration areas (state transfer and loaders) it was placed on the common element.
>>> 
>>> These two were both helpers methods, and I'm not sure whether I like them or not. If we don't want them, no problem from me.
>> 
>> They appeared misplaced to me.
>> 
>>> 
>>>> 
>>>> If this is problematic for anyone, please reply.
>>>> 
>>>> Cheers,
>>>> --
>>>> Galder Zamarreño
>>>> Sr. Software Engineer
>>>> Infinispan, JBoss Cache
>>>> 
>>>> 
>>>> _______________________________________________
>>>> infinispan-dev mailing list
>>>> infinispan-dev at lists.jboss.org
>>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>>> 
>>> 
>>> _______________________________________________
>>> infinispan-dev mailing list
>>> infinispan-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>> 
>> --
>> Galder Zamarreño
>> Sr. Software Engineer
>> Infinispan, JBoss Cache
>> 
>> 
>> _______________________________________________
>> infinispan-dev mailing list
>> infinispan-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
> 
> 
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev

--
Galder Zamarreño
Sr. Software Engineer
Infinispan, JBoss Cache