[infinispan-dev] AbstractGlobalConfigurationBuilder.read(template) - is it needed?

[Dan Berindei]

Mircea, I think the idea was to allow users to create a new CacheManager
based on an existing CacheManager, but with some global configuration
changes.

For instance, we could have used it in TestCacheManagerFactory, to allow
the user to pass in a GlobalConfiguration instead of a
GlobalConfigurationBuilder to when creating CacheManagers. Of course, for
us it was easy enough to change all the tests to pass in a
GlobalConfigurationBuilder, but I don't really like the caller having to
know that the global configuration will be modified before creating the
CacheManager.

Cheers
Dan


On Fri, Jul 13, 2012 at 12:02 PM, Mircea Markus <mircea.markus at jboss.com>wrote:

> Hi Pete,
>
> Whilst the 'read(template)' method does make sense in the case of  cache
> level configurations(AbstractConfigurationChildBuilder) in order to
> override the values from the default cache, is 'read(template)' in the
> global configuration also needed(AbstractGlobalConfigurationBuilder)? We
> don't use any override mechanism for global configuration; it also doesn't
> seem to be used anywhere in the code.
>
> Cheers,
> Mircea
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/infinispan-dev/attachments/20120716/418f0adb/attachment.html