[infinispan-dev] Hanging testsuite / bug in TestNG?

[Adrian Nistor]

Fair point.
Done!

On 06/27/2012 03:39 PM, Dan Berindei wrote:
> On Wed, Jun 27, 2012 at 3:36 PM, Adrian Nistor <anistor at redhat.com 
> <mailto:anistor at redhat.com>> wrote:
>
>     Yup.
>
>     No iteration on elements here. Copying is done atomically because
>     it is
>     based on ArrayList's constructor which uses Collection.toArray() which
>     is also atomic in this case because the passed in List happens to be
>     wrapped by Collections.synchronizedList() in all usages. I tested this
>     and it fixes the issue.
>
>
> You should also add a comment with this info to the pull req, 
> otherwise the maintainers of surefire might reject it :)
>
>     On 06/27/2012 03:13 PM, Sanne Grinovero wrote:
>     > Are you sure that resolved the problem?
>     >
>     > When you wrap a list into a new ArrayList, it might still need to
>     > iterate on it's elements, depending on which implementation of
>     List is
>     > being used.
>     >
>     > So that might indeed fix it but depends on the List
>     implementation :-(
>     >
>     > On 27 June 2012 13:03, Sanne Grinovero <sanne at infinispan.org
>     <mailto:sanne at infinispan.org>> wrote:
>     >> On 27 June 2012 12:51, Adrian Nistor <anistor at redhat.com
>     <mailto:anistor at redhat.com>> wrote:
>     >>> I've just submitted the surefire
>     ConcurrentModificationException issue
>     >>> (http://jira.codehaus.org/browse/SUREFIRE-879) and also
>     created a pull
>     >>> request for the (trivial) fix. Let's hope they will be quick
>     to handle
>     >>> it. This has the potential of eliminating many of our random
>     test failures.
>     >> Awesome!
>     > _______________________________________________
>     > infinispan-dev mailing list
>     > infinispan-dev at lists.jboss.org
>     <mailto:infinispan-dev at lists.jboss.org>
>     > https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
>
>     _______________________________________________
>     infinispan-dev mailing list
>     infinispan-dev at lists.jboss.org <mailto:infinispan-dev at lists.jboss.org>
>     https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
>
>
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/infinispan-dev/attachments/20120627/025a881b/attachment.html