[infinispan-dev] Infinispan testsuite's tcp.xml rename

[Galder Zamarreño]

On Oct 23, 2012, at 6:20 PM, Mircea Markus <mircea.markus at jboss.com> wrote:

> 
> On 22 Oct 2012, at 15:36, Galder Zamarreño wrote:
> 
>> Actually, my problem is not so the need for the renaming (which is needed anyway), but the fact that 2LC was relying on Infinispan's test tcp.xml file, because it used:
>> 
>> <org.infinispan.test.fwk.TEST_PING ergonomics="false" testName=""/>
> how did that get into the classpath? AFAIK we're only packing the test tcp.xml in the -test.jar, so didn't you have a bad dependency somehow? Or by "2LC" you're referring to the test suite of 2LC?

It's Hibernate's Infinispan 2LC testsuite that I'm talking about here.

Till now I was relying on the existing test jgroups xml for running the 2LC testsuite too, but for now I had to create my own jgroups xml file to avoid the issue below.

>> 
>> Now, why was "relay.RELAY2" added to the base tcp.xml in Infinispan testsuite?
>> 
>> Isn't this only needed for xsite tests? And if so, can't you have a xsite specific JGroups stack for testing?
> +1.
> I've updated [1] to also track this. 
> 
> [1] https://issues.jboss.org/browse/ISPN-2307

^ Great, thanks. I'll revert back to using it once that's in place.

>> 
>> As far as 2LC is concerned, for the moment I'll use a separate tcp.xml for testing taht removes the relay stuff, but I don't wanna be duplicating stuff, and some fixes done to the base test tcp.xml can be handy for 2LC too.
>> 
>> Cheers,
>> 
>> On Oct 22, 2012, at 4:13 PM, Galder Zamarreño <galder at redhat.com> wrote:
>> 
>>> Hi,
>>> 
>>> We seem to have several tcp.xml files:
>>> 
>>> - jgroups-3.2.0.CR1.jar!/tcp.xml
>>> - infinispan-core-5.2.0.Beta2-tests.jar/tcp.xml
>>> 
>>> An external project that might want to use the standard tcp.xml for testing might have issues if it's also depending on the Infinispan tests jars, it might have issues, particularly cos that tcp.xml has RELAY2 configuration that's environment specific, i.e.
>>> 
>>> Caused by: java.lang.Exception: site configuration for "__site_name__" not found in configs/xsite/relay-config.xml
>>> 	at org.jgroups.protocols.relay.RELAY2.parseSiteConfiguration(RELAY2.java:161)
>>> 	at org.jgroups.protocols.relay.RELAY2.init(RELAY2.java:88)
>>> 	at org.jgroups.stack.ProtocolStack.initProtocolStack(ProtocolStack.java:857)
>>> 	at org.jgroups.stack.ProtocolStack.setup(ProtocolStack.java:469)
>>> 	at org.jgroups.JChannel.init(JChannel.java:749)
>>> 	at org.jgroups.JChannel.<init>(JChannel.java:167)
>>> 	at org.jgroups.JChannel.<init>(JChannel.java:137)
>>> 	at org.infinispan.remoting.transport.jgroups.JGroupsTransport.buildChannel(JGroupsTransport.java:365)
>>> 	... 74 more
>>> 
>>> So, what about we rename the tcp.xml in the infinispan testsuite?
>>> 
>>> Cheers,
>>> --
>>> Galder Zamarreño
>>> galder at redhat.com
>>> twitter.com/galderz
>>> 
>>> Project Lead, Escalante
>>> http://escalante.io
>>> 
>>> Engineer, Infinispan
>>> http://infinispan.org
>>> 
>>> 
>>> _______________________________________________
>>> infinispan-dev mailing list
>>> infinispan-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>> 
>> 
>> --
>> Galder Zamarreño
>> galder at redhat.com
>> twitter.com/galderz
>> 
>> Project Lead, Escalante
>> http://escalante.io
>> 
>> Engineer, Infinispan
>> http://infinispan.org
>> 
>> 
>> _______________________________________________
>> infinispan-dev mailing list
>> infinispan-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
> 
> Cheers,
> -- 
> Mircea Markus
> Infinispan lead (www.infinispan.org)
> 
> 
> 
> 
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev


--
Galder Zamarreño
galder at redhat.com
twitter.com/galderz

Project Lead, Escalante
http://escalante.io

Engineer, Infinispan
http://infinispan.org