[infinispan-dev] Running CDI test suite

[Sanne Grinovero]

On 5 September 2012 14:48, Tristan Tarrant <ttarrant at redhat.com> wrote:
> Oh dear, JUnit where art thou ?

+1

>
> Tristan
>
>
> On 09/05/2012 02:46 PM, Vladimir Blagojevic wrote:
>
> Dan, look at the comments for getClasses in testng, it was introduced for
> YAML, getXMLClasses is the original method. I could not get cdi testsuite
> working with any other version of testng because of weld problems. It seems
> weld likes 5.14.6 and nothing else. For example, I used testng version
> 5.14.11 and no listener and the testsuite failed due to some weld setup, so
> i concluded this path was the simplest
> https://github.com/infinispan/infinispan/pull/1287
>
> Pete made some comments in cdi pom.xml that 5.14.6 is to be used explicitly.
>
> Regards,
> Vladimir
>
> On 12-09-05 2:36 PM, Dan Berindei wrote:
>
> Replying to myself, after looking in the history of cdi/extension/pom.xml,
> it seems it was upgraded to 5.14.6 back when the core was still on 5.11.
> Actually Kevin upgraded everything to 5.14.6 and then switched everything
> but cdi back to 5.11 for some unknown reason
> (https://issues.jboss.org/browse/ISPN-1250 doesn't provide any explanation).
>
> I think the best approach here would be to remove the special case for cdi
> and use the parent testng version.
>
>
> On Wed, Sep 5, 2012 at 3:27 PM, Dan Berindei <dan.berindei at gmail.com> wrote:
>>
>> Vladimir, is there any reason why the CDI test suite doesn't use the same
>> TestNG version as the core test suite?
>>
>> BTW, the latest TestNG version is 6.7, we might want to consider an
>> upgrade for all the projects.
>>
>>
>>
>> On Wed, Sep 5, 2012 at 2:29 PM, Vladimir Blagojevic <vblagoje at redhat.com>
>> wrote:
>>>
>>> Confirmed. We can fix this issue by using XmlTest#getXmlClasses instead
>>> of XmlTest#getClasses in UnitTestTestNGListener. I'll issue a pull for
>>> this simple fix.
>>> On 12-09-05 12:24 PM, Vladimir Blagojevic wrote:
>>> > Ok looks like someone updated UnitTestTestNGListener.java from core
>>> > project to use 5.14.10 testng version where ITestContext testng class
>>> > has method getClasses but in 5.14.6 that method does not exist and it
>>> > seems like we need to use 5.14.6 in cdi project. Investigating....
>>> >
>>> >
>>> > On 12-09-05 11:50 AM, Vladimir Blagojevic wrote:
>>> >> Guys,
>>> >>
>>> >> As I prepared pull request for ISPN-2181 and I rebased to current
>>> >> master, my cdi test suite started to fail with:
>>> >>
>>> >> ------------------------------------------------------
>>> >>     T E S T S
>>> >> -------------------------------------------------------
>>> >> Running TestSuite
>>> >> Configuring TestNG with:
>>> >> org.apache.maven.surefire.testng.conf.TestNGMapConfigurator at 324a4e31
>>> >> log4j:WARN No appenders could be found for logger (org.jboss.logging).
>>> >> log4j:WARN Please initialize the log4j system properly.
>>> >> log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig
>>> >> for
>>> >> more info.
>>> >> [INFO]
>>> >>
>>> >> ------------------------------------------------------------------------
>>> >> [INFO] BUILD FAILURE
>>> >> [INFO]
>>> >>
>>> >> ------------------------------------------------------------------------
>>> >> [INFO] Total time: 33.484s
>>> >> [INFO] Finished at: Wed Sep 05 11:47:54 CEST 2012
>>> >> [INFO] Final Memory: 18M/265M
>>> >> [INFO]
>>> >>
>>> >> ------------------------------------------------------------------------
>>> >> [ERROR] Failed to execute goal
>>> >> org.apache.maven.plugins:maven-surefire-plugin:2.12.2:test
>>> >> (default-test) on project infinispan-cdi: Execution default-test of
>>> >> goal
>>> >> org.apache.maven.plugins:maven-surefire-plugin:2.12.2:test failed:
>>> >> java.lang.reflect.InvocationTargetException; nested exception is
>>> >> java.lang.reflect.InvocationTargetException: null:
>>> >> org.testng.xml.XmlTest.getClasses()Ljava/util/List; -> [Help 1]
>>> >>
>>> >>
>>> >> I thought it must have been something with my branch but then I tried
>>> >> master and it still fails. Any ideas how to fix this one?
>>> >>
>>> >> Regards,
>>> >> Vladimir
>>> >> _______________________________________________
>>> >> infinispan-dev mailing list
>>> >> infinispan-dev at lists.jboss.org
>>> >> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>>> > _______________________________________________
>>> > infinispan-dev mailing list
>>> > infinispan-dev at lists.jboss.org
>>> > https://lists.jboss.org/mailman/listinfo/infinispan-dev
>>>
>>> _______________________________________________
>>> infinispan-dev mailing list
>>> infinispan-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>>
>>
>
>
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
>
>
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
>
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev