[infinispan-dev] QueryIterator inconsistencies

Marko Lukša marko.luksa at gmail.com
Tue Sep 25 07:11:46 EDT 2012


On 25.9.2012 11:51, Sanne Grinovero wrote:
>>>> Any comments / other ideas?
>>>>
>>>> Marko
>>> That's a lot of changes needed. One would say we could deprecate all
>>> methods and rewrite the new ones, but wouldn't it be better to
>>> deprecate the interface and introduce a brand new one?
>>> What about "ResultsIterator" ? after all, we're not iterating on queries..
>> I agree. The only thing that bothers me is that CacheQuery would then
>> need new methods called (lazy)resultIterator() (instead of iterator(),
>> which already exists).
> Right. though I like "resultIterator()" more so we're having luck in
> this case ;)
>
> Any better suggestion for names? Anyone thinks it's worth to remove
> the old ones without a deprecation step to reuse the old names?
>
One thing to keep in mind is that CacheQuery extends Iterable, therefore 
a lot of users will actually implicitly invoke the iterator() method. 
This pretty much means we should not introduce resultIterator().

Marko




More information about the infinispan-dev mailing list