[infinispan-dev] Integrating Karsten's FCS

[Galder Zamarreño]

On Jul 10, 2013, at 11:43 AM, Mircea Markus <mmarkus at redhat.com> wrote:

> 
> On 9 Jul 2013, at 11:51, Pedro Ruivo <pedro at infinispan.org> wrote:
> 
>> hi,
>> 
>> On 07/09/2013 09:32 AM, Galder Zamarreño wrote:
>>> Hi,
>>> 
>>> I think we all agree that Karsten's file cache store is a good base replacement for the current file cache store, particularly for caches with relatively small keys, or not a huge amount of them.
>>> 
>>> I'm working with Radim to try to figure out what would be the tipping point at which LevelDB based cache store behaves better compared to Karsten's cache store.
>>> 
>>> In the mean time, I think we should integrate Karsten's FCS into master and have it ready for people to try from Alpha1. There's one or two things that do require a bit of review, but I can pin point them in the pull req.
>> 
>> +1 to have in Alpha1
> 
> +1
> 
>> 
>>> 
>>> The question is, how should we name it? And what should we do about the current FCS implementation?
>> 
>>> 
>>> Shall we keep the current FCS implementation, deprecate it, and get rid of it in the next minor/major version? Some users might have data stored in the current FCS and would be quite abrupt to just get rid of it right now.
>> 
>> IMO, deprecate it in next Alpha and remove it in Final.
>> Also it would be better to create some tool to convert the files from 
>> current FCS to the karsten's FCS.
> 
> the rolling upgrade functionality should have that already.
>> 
>>> 
>>> If so, what do we name karsten's file cache store? AppendOnlyFileCacheStore?
>> 
>> not so good with names but KarstenFileCacheStore or 
> there's an @author tag already in that file :-)
> 
>> AppendOnlyFileCacheStore looks good to me...
> 
> or name it FileCacheStore but move it in another package, e.g. org.infinispan.loaders.filestore

^ So, you're suggesting have two FileCacheStore classes? That sounds confusing, and we're already have a package called org.infinispan.loaders.file.

I might just call it SingleFileCacheStore for the moment, since it uses a single file to store all data.

> 
> 
> Cheers,
> -- 
> Mircea Markus
> Infinispan lead (www.infinispan.org)
> 
> 
> 
> 
> 
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev


--
Galder Zamarreño
galder at redhat.com
twitter.com/galderz

Project Lead, Escalante
http://escalante.io

Engineer, Infinispan
http://infinispan.org