[infinispan-dev] Error parsing Recovery

[Pedro Ruivo]

On 05/08/2013 01:47 PM, Mircea Markus wrote:
>
> On 8 May 2013, at 13:37, Pedro Ruivo wrote:
>
>> Hi guys,
>>
>> Is there any reason to enable the recovery when we pick from
>> TransactionConfigurationBuilder?
>>
>> public RecoveryConfigurationBuilder recovery() {
>>    recovery.enable();
>>    return recovery;
>> }
> the method documents that as the the behaviour, can't remember the logic behind it.
>>
>> This will enable the Recovery in configurations like this:
>>
>> <namedCache name="noRecovery">
>>    <transaction (...) transactionMode="NON_TRANSACTIONAL">
>>      <recovery enabled="false" recoveryInfoCacheName="someName"/>
>>    </transaction>
>> </namedCache>
>>
>> leading the RecoveryConfigTest to fail.
>
> This should result in a cache with recovery disabled so it is a bug. Please file a JIRA.

Can I do the fastest solution and remove the recovery.enable()?

or should I be safe and change the parser to invoke 
TransactionConfigurationBuilder.recovery() only once before parsing the 
attributed? Should I also change the parser for 5.1 and 5.2?

>
>>
>> ps. I detected this when working on
>> https://issues.jboss.org/browse/ISPN-3063.
>>
>> Cheers,
>> Pedro
>> _______________________________________________
>> infinispan-dev mailing list
>> infinispan-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
> Cheers,
>