[infinispan-dev] Recovery with async cache mode

[Pedro Ruivo]

I though to put a warning when recovery=true and useSynchronization=true 
to warn the users that recovery is not available with Synchronization. 
But I've realized that this is our default configuration.

I'm going to keep the warning and add it to 
SampleConfigFilesCorrectnessTest.TOLERABLE_WARNINGS (the only failing 
test so far).

I think that is ok since this configuration will not create any data 
inconsistencies neither any issue.

Do you see any problem in logging the warning?

Cheers,
Pedro

On 05/10/2013 11:49 AM, Pedro Ruivo wrote:
>
>
> On 05/10/2013 11:24 AM, Mircea Markus wrote:
>>
>> On 10 May 2013, at 09:55, Manik Surtani wrote:
>>
>>> On 9 May 2013, at 21:44, Mircea Markus <mmarkus at redhat.com> wrote:
>>>
>>>>>
>>>>> I think the correct thing to do is to fix the test suite and throw an
>>>>> exception if someone tries to enable recovery with async cache mode.
>>>> Or just raise an WARNING for now, just for backward compatibility.
>>>
>>> No, I think we should throw an exception as an invalid
>>> configuration.  Because, well, it is invalid.  If anyone is using
>>> async + recovery, it is important that they realise that it is
>>> invalid and fix their config.
>> fair enough. At the end of the day people need to turn on
>> xa-enlistment explicitly so they must be looking for recovery if they
>> do do that.
>> @Pedro - just make sure that both recovery is enabled *and* XA
>> resource enlistment is set to true if throwing an exception. I think
>> that should reduce the number of test that fail significantly.
>>
> ok got it :)
>
>> Cheers,
>>