[infinispan-dev] Style errors :(

[Sebastian Laskawiec]

Hey Galder, Sanne!

The author is no longer anonymous! It was me [1]!

Jokes aside; Galder - may I ask you to double check your configuration? I
extracted formatter archive and it seems to be fine [2]. Perhaps you didn't
enable it (watch out, the formatter name was changed some time ago from
Horizon to Infinispan) or this is some tooling problem (which probably
should be reported to Jetbrains). Anyway - could you please double check
it? I'll try to catch you tomorrow on IRC and talk about it...

BTW - There are 2 different errors in your output - the first one is the
start import which should be avoided. The second one is duplicated import
(also should be avoided). Please don't confuse those two.

@Sanne - before you trow a 'git revert' axe on me - may I ask you to import
the latest formatter and check if the amount of imports before replacing
them with star looks correctly? It looks fine to me but I may have some old
installation, old configuration etc...

Thanks
Sebastian "the Troublemaker"

[1] https://www.youtube.com/watch?v=a43kowi2ncI
[2] unzip IntelliJ_IDEA_Code_Style.jar and look into attached XML. Those
two properties are responsible for star imports.
<option name="CLASS_COUNT_TO_USE_IMPORT_ON_DEMAND" value="999" />
<option name="NAMES_COUNT_TO_USE_IMPORT_ON_DEMAND" value="999" />


On Tue, Aug 16, 2016 at 8:21 PM, Sanne Grinovero <sanne at infinispan.org>
wrote:

> Please don't forget Eclipse users. It's hard enough to contribute to
> Infinispan for non-IDEA users; if you enforce specific style rules, at
> the very least provide compatible formatters for the other IDEs or the
> barrier for contributors becomes too high.
>
> Galder: to answer your specific question I'd personally say you should
> revert the offending commit. I don't know who did it nor who merged
> it, but it's just not nice for others that such things get merged
> carelessly. Errors can be forgiven, but should be fixed by those who
> create the mess ;)
>
> On 16 August 2016 at 16:37, Galder Zamarreño <galder at redhat.com> wrote:
> > Hi all,
> >
> > After integrating [1] I'm getting build errors such as:
> >
> > [INFO] --- maven-checkstyle-plugin:2.17:checkstyle (checkstyle) @
> infinispan-core ---
> > [INFO] Starting audit...
> > /home/g/0/infinispan/git/core/src/main/java/org/infinispan/
> marshall/core/internal/InternalExternalizerTable.java:55: error: Using
> the '.*' form of import should be avoided - org.infinispan.marshall.exts.*
> .
> > /home/g/0/infinispan/git/core/src/main/java/org/infinispan/
> marshall/core/ExternalizerTable.java:76: error: Using the '.*' form of
> import should be avoided - org.infinispan.marshall.exts.*.
> > /home/g/0/infinispan/git/core/src/test/java/org/infinispan/filter/
> CompositeKeyValueFilterConverter.java:11:1: error: Duplicate import to
> line 10 - org.infinispan.metadata.Metadata.
> >
> > Even after installing the latest style for IntelliJ [2], reformatting
> InternalExternalizerTable.java won't fix those how errors.
> >
> > So, what do we do? :(
> >
> > Cheers,
> >
> > [1] https://github.com/infinispan/infinispan/commit/
> 313b19301055c6267c6f2ea9065a7ab1b68099fe
> > [2] https://github.com/infinispan/infinispan/blob/master/ide-
> settings/intellij/IntelliJ_IDEA_Code_Style.jar
> > --
> > Galder Zamarreño
> > Infinispan, Red Hat
> >
> >
> > _______________________________________________
> > infinispan-dev mailing list
> > infinispan-dev at lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/infinispan-dev/attachments/20160816/ce26e7cd/attachment.html