[infinispan-dev] Style errors :(

Wed Aug 17 02:36:31 EDT 2016

--
Galder Zamarreño
Infinispan, Red Hat

> On 17 Aug 2016, at 01:01, Adrian Nistor <anistor at redhat.com> wrote:
> 
> The master branch was building fine anyway because checkstyle does not seem to be included in default lifecycle yet, so I'm not sure why this generates so much commotion.

Hmmm, when I execute "mvn -DskipTests=true clean install --projects core -am", it appears as part of the default lifecycle:

Here: https://gist.github.com/galderz/16b126afaf6adb801473ac58c1d5e504#file-gistfile1-txt-L96
Here: https://gist.github.com/galderz/16b126afaf6adb801473ac58c1d5e504#file-gistfile1-txt-L156
And here: https://gist.github.com/galderz/16b126afaf6adb801473ac58c1d5e504#file-gistfile1-txt-L356

> But we should stop being lenient about these checkstyle violations and fail the build from now on. ATM there are no more violations for the currently enabled rules, so it is about time :).

I'm happy for that, as long as the IDEs can quickly fix those. I'm not manually handrolling things to make checkstyle happy :|

> This approach seems to work fine for hibernate-ogm and hibernate-search, and they have tons of style rules. We only have three.
> 
> On 08/16/2016 11:25 PM, Sebastian Laskawiec wrote:
>> I also integrated Adrian's PR with additional fixed (thank you Adrian!): https://github.com/infinispan/infinispan/pull/4510
>> 
>> The master branch builds fine now.
>> 
>> Thanks
>> Sebastian
>> 
>> On Tue, Aug 16, 2016 at 10:16 PM, Sebastian Laskawiec <slaskawi at redhat.com> wrote:
>> Hey Galder, Sanne!
>> 
>> The author is no longer anonymous! It was me [1]!
>> 
>> Jokes aside; Galder - may I ask you to double check your configuration? I extracted formatter archive and it seems to be fine [2]. Perhaps you didn't enable it (watch out, the formatter name was changed some time ago from Horizon to Infinispan) or this is some tooling problem (which probably should be reported to Jetbrains). Anyway - could you please double check it? I'll try to catch you tomorrow on IRC and talk about it...
>> 
>> BTW - There are 2 different errors in your output - the first one is the start import which should be avoided. The second one is duplicated import (also should be avoided). Please don't confuse those two.
>> 
>> @Sanne - before you trow a 'git revert' axe on me - may I ask you to import the latest formatter and check if the amount of imports before replacing them with star looks correctly? It looks fine to me but I may have some old installation, old configuration etc...
>> 
>> Thanks
>> Sebastian "the Troublemaker"
>> 
>> [1] https://www.youtube.com/watch?v=a43kowi2ncI
>> [2] unzip IntelliJ_IDEA_Code_Style.jar and look into attached XML. Those two properties are responsible for star imports. 
>> <option name="CLASS_COUNT_TO_USE_IMPORT_ON_DEMAND" value="999" />
>> <option name="NAMES_COUNT_TO_USE_IMPORT_ON_DEMAND" value="999" />
>> 
>> 
>> On Tue, Aug 16, 2016 at 8:21 PM, Sanne Grinovero <sanne at infinispan.org> wrote:
>> Please don't forget Eclipse users. It's hard enough to contribute to
>> Infinispan for non-IDEA users; if you enforce specific style rules, at
>> the very least provide compatible formatters for the other IDEs or the
>> barrier for contributors becomes too high.
>> 
>> Galder: to answer your specific question I'd personally say you should
>> revert the offending commit. I don't know who did it nor who merged
>> it, but it's just not nice for others that such things get merged
>> carelessly. Errors can be forgiven, but should be fixed by those who
>> create the mess ;)
>> 
>> On 16 August 2016 at 16:37, Galder Zamarreño <galder at redhat.com> wrote:
>> > Hi all,
>> >
>> > After integrating [1] I'm getting build errors such as:
>> >
>> > [INFO] --- maven-checkstyle-plugin:2.17:checkstyle (checkstyle) @ infinispan-core ---
>> > [INFO] Starting audit...
>> > /home/g/0/infinispan/git/core/src/main/java/org/infinispan/marshall/core/internal/InternalExternalizerTable.java:55: error: Using the '.*' form of import should be avoided - org.infinispan.marshall.exts.*.
>> > /home/g/0/infinispan/git/core/src/main/java/org/infinispan/marshall/core/ExternalizerTable.java:76: error: Using the '.*' form of import should be avoided - org.infinispan.marshall.exts.*.
>> > /home/g/0/infinispan/git/core/src/test/java/org/infinispan/filter/CompositeKeyValueFilterConverter.java:11:1: error: Duplicate import to line 10 - org.infinispan.metadata.Metadata.
>> >
>> > Even after installing the latest style for IntelliJ [2], reformatting InternalExternalizerTable.java won't fix those how errors.
>> >
>> > So, what do we do? :(
>> >
>> > Cheers,
>> >
>> > [1] https://github.com/infinispan/infinispan/commit/313b19301055c6267c6f2ea9065a7ab1b68099fe
>> > [2] https://github.com/infinispan/infinispan/blob/master/ide-settings/intellij/IntelliJ_IDEA_Code_Style.jar
>> > --
>> > Galder Zamarreño
>> > Infinispan, Red Hat
>> >
>> >
>> > _______________________________________________
>> > infinispan-dev mailing list
>> > infinispan-dev at lists.jboss.org
>> > https://lists.jboss.org/mailman/listinfo/infinispan-dev
>> 
>> _______________________________________________
>> infinispan-dev mailing list
>> infinispan-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>> 
>> 
>> 
>> 
>> _______________________________________________
>> infinispan-dev mailing list
>> 
>> infinispan-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
> 
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev