<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On 25 Mar 2009, at 14:08, Brian Stansberry wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Mircea Markus wrote:<br><blockquote type="cite">Manik Surtani wrote:<br></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">On 25 Mar 2009, at 13:19, Adrian Cole wrote:<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">tough call.. the jmx user may not have access to the log to see the<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">warning anyway.<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">I would prefer an info notification of coarse registration events then<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">warn or trace depending on whether the name is overloaded. That would<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">seem more grep friendly for unixy folks who scrape logs for things. I<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">think a mandatory index would me simpler in that case, although<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">slightly confusing for folks who don't have more then one.<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">+1 on the mandatory index.<br></blockquote></blockquote><blockquote type="cite">I think mandatory indexes would confuse users, as they configured an jmxDomain in clear text and see an different on the server. Even more, they might want to enforce an domainName for other reasons (e.g. thay have other modules expose under that domain name etc).<br></blockquote><blockquote type="cite">I would like the user to be aware of the fact that there is an conflict and take action, rather than dig through logs first and then curse the developer who wrote the code.</blockquote></div></blockquote><div><br></div><div>Then an ConfigurationException is the best approach.</div><div><br></div><blockquote type="cite"><div><blockquote type="cite"><span class="Apple-style-span" style="-webkit-text-stroke-width: -1; ">What about:</span></blockquote><blockquote type="cite">1) forbid a registration under same domain. Cache won't start as registration is done at startup, an exception will be thrown.</blockquote></div></blockquote><div><br></div><div>Yup</div><br><blockquote type="cite"><div><blockquote type="cite"><span class="Apple-style-span" style="-webkit-text-stroke-width: -1; ">2) add an configuration attribute named forceAutoIncrement (default=false). The user would have to manually enable it.Also, the error message at 1) would inform him about this attribute, so the change should be quite straight</span></blockquote></div></blockquote><div><br></div><div>Perhaps call this "allowDuplicateDomains"? Default to false as you say, but if this is true, always use a counter so that the first instance would be <jmxDomain>:0?</div><br><blockquote type="cite"><div>I think an option to name the manager is needed. I'll be running multiple managers in the same AS, and people are going to need to be able to access them by name, not by a number that varies based on what order the managers are started in.</div></blockquote><div><br></div><div>This is your jmxDomain. You have a single <global /> section per cache manager.</div><div><br></div><div>The issue is the overlap when you have multiple cache managers which happen to have the same name. </div><div><br></div><div>Cheers</div><div>Manik</div><div><br></div><div>--</div></div><div apple-content-edited="true"><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-infinispantal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-infinispantal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>Manik Surtani</div><div>Lead, JBoss Cache</div><div><a href="http://www.jbosscache.org">http://www.jbosscache.org</a><br><a href="mailto:manik@jboss.org" target="_blank">manik@jboss.org</a></div><div><br></div></div></span><br class="Apple-interchange-newline"></div></span><br class="Apple-interchange-newline"> </div><br></body></html>