+1<br><br><div class="gmail_quote">On Thu, May 14, 2009 at 11:05 AM, Manik Surtani <span dir="ltr"><<a href="mailto:manik@jboss.org">manik@jboss.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im"><br>
On 14 May 2009, at 09:57, Mircea Markus wrote:<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi,<br>
<br>
Currently the interface of these classes use a javax.transaction.Transaction parameter:<br>
<br>
void prepare(List<? extends Modification> modifications, Transaction tx, boolean isOnePhase) throws CacheLoaderException;<br>
<br>
The problem with this is that Transaction will not exist if this is a remotely originated call (we only propagate the GlobalTransaction on the remote nodes).<br>
I've took a look at the CacheStore impls, they do not use any specific javax.transaction.Transaction logic/methods, but rather use the param as a key in their internal caches.<br>
Do you see any issues with changing the signature of CacheStore to replace Transaction param with GlobalTransaction?<br>
</blockquote>
<br></div>
Sure, this is fine by me. Better get it in ASAP though, before I cut ALPHA3, since the CacheStore interface should be frozen after that.<br>
<br>
You would need to update cache store impls, but that should be trivial.<br>
<br>
Cheers<br><font color="#888888">
--<br>
Manik Surtani<br>
<a href="mailto:manik@jboss.org" target="_blank">manik@jboss.org</a><br>
Lead, Infinispan<br>
Lead, JBoss Cache<br>
<a href="http://www.infinispan.org" target="_blank">http://www.infinispan.org</a><br>
<a href="http://www.jbosscache.org" target="_blank">http://www.jbosscache.org</a></font><div><div></div><div class="h5"><br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
</div></div></blockquote></div><br>